Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Unified Diff: content/browser/service_worker/service_worker_url_request_job_unittest.cc

Issue 2570453002: Add CHECKs to investigate ServiceWorkerControlleeRequestHandler crash. (Closed)
Patch Set: fix compile Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/service_worker/service_worker_registration.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_url_request_job_unittest.cc
diff --git a/content/browser/service_worker/service_worker_url_request_job_unittest.cc b/content/browser/service_worker/service_worker_url_request_job_unittest.cc
index 630b018c4e877fee8af37ed3169a8f78222834da..30021b9d4b4246e941e238d21f36f07ebe74c59d 100644
--- a/content/browser/service_worker/service_worker_url_request_job_unittest.cc
+++ b/content/browser/service_worker/service_worker_url_request_job_unittest.cc
@@ -291,7 +291,7 @@ class ServiceWorkerURLRequestJobTest
void MainResourceLoadFailed() override {
CHECK(provider_host_);
// Detach the controller so subresource requests also skip the worker.
- provider_host_->NotifyControllerLost();
+ provider_host_->NotifyControllerLost(false /* was_deleted */);
}
// Runs a request where the active worker starts a request in ACTIVATING state
« no previous file with comments | « content/browser/service_worker/service_worker_registration.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698