Move getBufferSubDataAsync to an extension

Move getBufferSubDataAsync to an extension

This extension is exposed as "draft" but there isn't actually a draft of the extension spec just yet. The text in the pull request needs to be moved around.

BUG=616554
TBR=haraken@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/d21a20ac92bb56bea69eaea1b633c51e74f672f3
Cr-Commit-Position: refs/heads/master@{#438412}

[Kai Ninomiya, 2016-12-13 21:57:28]

Description was changed from

==========
Move getBufferSubDataAsync to an extension

BUG=616554
==========

to

==========
Move getBufferSubDataAsync to an extension

BUG=616554
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Kai Ninomiya, 2016-12-13 22:02:29]

Description was changed from

==========
Move getBufferSubDataAsync to an extension

BUG=616554
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Move getBufferSubDataAsync to an extension

This extension is exposed as "draft" but there isn't actually a draft of the
extension spec just yet. The text in the pull request needs to be moved around.

BUG=616554
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Kai Ninomiya, 2016-12-13 22:02:29]

kainino@chromium.org changed reviewers:
+ kbr@chromium.org

[Kai Ninomiya, 2016-12-13 22:06:14]

kbr, PTAL

I have not updated my GitHub PR yet to move this to an extension, and of course
the extension naming will be subject to bikeshedding.

And since I haven't updated the tests yet I haven't run them, but I plan to do
so before landing this. I have updated my cube picking demo and tested it.

[Ken Russell (switch to Gerrit), 2016-12-13 23:17:29]

LGTM with one minor issue. Please press forward with a pull request adding a
draft extension as well as your tests to date.

https://codereview.chromium.org/2569863005/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webgl/WebGLGetBufferSubDataAsync.cpp
(right):

https://codereview.chromium.org/2569863005/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGLGetBufferSubDataAsync.cpp:30:
"GL_EXT_texture_compression_s3tc_srgb");
This looks wrong.

[Kai Ninomiya, 2016-12-13 23:20:30]

https://codereview.chromium.org/2569863005/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webgl/WebGLGetBufferSubDataAsync.cpp
(right):

https://codereview.chromium.org/2569863005/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGLGetBufferSubDataAsync.cpp:30:
"GL_EXT_texture_compression_s3tc_srgb");
On 2016/12/13 23:17:29, Ken Russell wrote:
> This looks wrong.

uh... oops. error in context switch state restoration in my brain.

[Kai Ninomiya, 2016-12-13 23:29:58]

Okay, fixed. I copied this from that extension cpp file but it didn't look
incorrect to me because I was also looking at s3tc_srgb stuff today.

Anyway, should we land this now or wait until we've decided on the name?

[Ken Russell (switch to Gerrit), 2016-12-14 01:30:04]

Let's land this now and also land the draft extension and tests under this name.
Then the name can be bikeshedded later.

[Kai Ninomiya, 2016-12-14 01:40:29]

Description was changed from

==========
Move getBufferSubDataAsync to an extension

This extension is exposed as "draft" but there isn't actually a draft of the
extension spec just yet. The text in the pull request needs to be moved around.

BUG=616554
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Move getBufferSubDataAsync to an extension

This extension is exposed as "draft" but there isn't actually a draft of the
extension spec just yet. The text in the pull request needs to be moved around.

BUG=616554
TBR=haraken@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Kai Ninomiya, 2016-12-14 01:41:04]

The CQ bit was checked by kainino@chromium.org

[Kai Ninomiya, 2016-12-14 01:41:04]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/2569863005/#ps40001
(title: "fixup")

[commit-bot: I haz the power, 2016-12-14 01:41:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 03:24:08]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481679664367150,
"parent_rev": "54591aeddedc9fa84703320a83b0fff45082398b", "commit_rev":
"8baf986b81ee93901c8c543f495833b202c57209"}

[commit-bot: I haz the power, 2016-12-14 03:24:36]

Description was changed from

==========
Move getBufferSubDataAsync to an extension

This extension is exposed as "draft" but there isn't actually a draft of the
extension spec just yet. The text in the pull request needs to be moved around.

BUG=616554
TBR=haraken@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Move getBufferSubDataAsync to an extension

This extension is exposed as "draft" but there isn't actually a draft of the
extension spec just yet. The text in the pull request needs to be moved around.

BUG=616554
TBR=haraken@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2569863005
==========

[commit-bot: I haz the power, 2016-12-14 03:24:38]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-14 03:28:16]

Description was changed from

==========
Move getBufferSubDataAsync to an extension

This extension is exposed as "draft" but there isn't actually a draft of the
extension spec just yet. The text in the pull request needs to be moved around.

BUG=616554
TBR=haraken@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2569863005
==========

to

==========
Move getBufferSubDataAsync to an extension

This extension is exposed as "draft" but there isn't actually a draft of the
extension spec just yet. The text in the pull request needs to be moved around.

BUG=616554
TBR=haraken@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/d21a20ac92bb56bea69eaea1b633c51e74f672f3
Cr-Commit-Position: refs/heads/master@{#438412}
==========

[commit-bot: I haz the power, 2016-12-14 03:28:17]

Patchset 3 (id:??) landed as
https://crrev.com/d21a20ac92bb56bea69eaea1b633c51e74f672f3
Cr-Commit-Position: refs/heads/master@{#438412}