Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2566663004: Revert of Build services as standalone executables (Closed)

Created:
4 years ago by Ken Rockot(use gerrit already)
Modified:
4 years ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, kalyank, qsr+mojo_chromium.org, sadrul, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Build services as standalone executables (patchset #14 id:260001 of https://codereview.chromium.org/2557213002/ ) Reason for revert: Lots of test failures - ICU data not being found in service processes. Original issue's description: > Build services as standalone executables > > Cleans up a bunch of service manager details which exist to support > the currently untenable goal of dynamically loading service binaries > in a common host executable. > > Changes services to instead build as standalone executables, and > teaches the service manager how to launch them. > > BUG=642879 > > Review-Url: https://codereview.chromium.org/2557213002 TBR=ben@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=642879 Committed: https://crrev.com/3d1922bf7e1a53616f82c630eb6c0958eb574386 Cr-Commit-Position: refs/heads/master@{#437752}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1356 lines, -901 lines) Patch
M chrome/app/mash/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/mash/mash_runner.cc View 3 chunks +10 lines, -7 lines 0 comments Download
M chrome/test/base/mash_browser_tests_main.cc View 2 chunks +15 lines, -2 lines 0 comments Download
M chrome/test/base/mojo_test_connector.cc View 1 chunk +1 line, -4 lines 0 comments Download
M content/browser/service_manager/service_manager_context.cc View 3 chunks +4 lines, -17 lines 0 comments Download
M services/catalog/reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/background/background_service_manager_main.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M services/service_manager/native_runner.h View 1 chunk +4 lines, -3 lines 0 comments Download
M services/service_manager/public/cpp/lib/service_runner.cc View 1 chunk +6 lines, -1 line 0 comments Download
M services/service_manager/public/cpp/service.h View 3 chunks +1 line, -7 lines 0 comments Download
M services/service_manager/public/cpp/service.gni View 5 chunks +29 lines, -34 lines 0 comments Download
D services/service_manager/public/cpp/standalone_service/BUILD.gn View 1 chunk +0 lines, -63 lines 0 comments Download
D services/service_manager/public/cpp/standalone_service/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D services/service_manager/public/cpp/standalone_service/linux_sandbox.h View 1 chunk +0 lines, -52 lines 0 comments Download
D services/service_manager/public/cpp/standalone_service/linux_sandbox.cc View 1 chunk +0 lines, -169 lines 0 comments Download
D services/service_manager/public/cpp/standalone_service/mach_broker.h View 1 chunk +0 lines, -53 lines 0 comments Download
D services/service_manager/public/cpp/standalone_service/mach_broker.cc View 1 chunk +0 lines, -43 lines 0 comments Download
D services/service_manager/public/cpp/standalone_service/main.cc View 1 chunk +0 lines, -95 lines 0 comments Download
D services/service_manager/public/cpp/standalone_service/standalone_service.h View 1 chunk +0 lines, -25 lines 0 comments Download
D services/service_manager/public/cpp/standalone_service/standalone_service.cc View 1 chunk +0 lines, -119 lines 0 comments Download
D services/service_manager/public/cpp/standalone_service/switches.h View 1 chunk +0 lines, -11 lines 0 comments Download
D services/service_manager/public/cpp/standalone_service/switches.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M services/service_manager/runner/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A services/service_manager/runner/child/BUILD.gn View 1 chunk +32 lines, -0 lines 0 comments Download
A services/service_manager/runner/child/manifest.json View 1 chunk +11 lines, -0 lines 0 comments Download
A services/service_manager/runner/child/test_native_main.h View 1 chunk +18 lines, -0 lines 0 comments Download
A services/service_manager/runner/child/test_native_main.cc View 1 chunk +71 lines, -0 lines 0 comments Download
M services/service_manager/runner/host/BUILD.gn View 4 chunks +64 lines, -26 lines 0 comments Download
A services/service_manager/runner/host/child_process.h View 1 chunk +15 lines, -0 lines 0 comments Download
A services/service_manager/runner/host/child_process.cc View 1 chunk +72 lines, -0 lines 0 comments Download
A services/service_manager/runner/host/child_process_base.h View 1 chunk +23 lines, -0 lines 0 comments Download
A services/service_manager/runner/host/child_process_base.cc View 1 chunk +128 lines, -0 lines 0 comments Download
M services/service_manager/runner/host/child_process_host.h View 2 chunks +7 lines, -6 lines 0 comments Download
M services/service_manager/runner/host/child_process_host.cc View 6 chunks +23 lines, -36 lines 0 comments Download
M services/service_manager/runner/host/child_process_host_unittest.cc View 3 chunks +3 lines, -11 lines 0 comments Download
D services/service_manager/runner/host/host_test_service_main.cc View 1 chunk +0 lines, -12 lines 0 comments Download
D services/service_manager/runner/host/host_test_service_manifest.json View 1 chunk +0 lines, -4 lines 0 comments Download
M services/service_manager/runner/host/host_unittests.cc View 1 chunk +9 lines, -0 lines 0 comments Download
A services/service_manager/runner/host/in_process_native_runner.h View 1 chunk +70 lines, -0 lines 0 comments Download
A services/service_manager/runner/host/in_process_native_runner.cc View 1 chunk +95 lines, -0 lines 0 comments Download
A services/service_manager/runner/host/in_process_native_runner_unittest.cc View 1 chunk +16 lines, -0 lines 0 comments Download
A services/service_manager/runner/host/linux_sandbox.h View 1 chunk +51 lines, -0 lines 0 comments Download
A services/service_manager/runner/host/linux_sandbox.cc View 1 chunk +169 lines, -0 lines 0 comments Download
A services/service_manager/runner/host/mach_broker.h View 1 chunk +53 lines, -0 lines 0 comments Download
A services/service_manager/runner/host/mach_broker.cc View 1 chunk +43 lines, -0 lines 0 comments Download
A services/service_manager/runner/host/native_library_runner.h View 1 chunk +38 lines, -0 lines 0 comments Download
A services/service_manager/runner/host/native_library_runner.cc View 1 chunk +105 lines, -0 lines 0 comments Download
M services/service_manager/runner/host/out_of_process_native_runner.h View 3 chunks +6 lines, -7 lines 0 comments Download
M services/service_manager/runner/host/out_of_process_native_runner.cc View 2 chunks +10 lines, -11 lines 0 comments Download
M services/service_manager/service_manager.cc View 2 chunks +6 lines, -11 lines 0 comments Download
M services/service_manager/standalone/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M services/service_manager/standalone/context.cc View 3 chunks +17 lines, -5 lines 0 comments Download
M services/service_manager/standalone/desktop/main_helper.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M services/service_manager/switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M services/service_manager/switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M services/service_manager/tests/connect/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/tests/connect/connect_test_exe.cc View 3 chunks +13 lines, -9 lines 0 comments Download
M services/service_manager/tests/lifecycle/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/tests/lifecycle/lifecycle_exe.cc View 1 chunk +16 lines, -5 lines 0 comments Download
M services/service_manager/tests/lifecycle/package.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M services/service_manager/tests/service_manager/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M services/service_manager/tests/service_manager/embedder.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M services/service_manager/tests/service_manager/target.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M services/tracing/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M services/ui/BUILD.gn View 4 chunks +10 lines, -19 lines 0 comments Download
M testing/buildbot/chromium.android.json View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Ken Rockot(use gerrit already)
Created Revert of Build services as standalone executables
4 years ago (2016-12-10 04:37:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566663004/1
4 years ago (2016-12-10 04:37:27 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-10 04:39:35 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-12 15:06:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d1922bf7e1a53616f82c630eb6c0958eb574386
Cr-Commit-Position: refs/heads/master@{#437752}

Powered by Google App Engine
This is Rietveld 408576698