Build services as standalone executables

Build services as standalone executables

Cleans up a bunch of service manager details which exist to support
the currently untenable goal of dynamically loading service binaries
in a common host executable.

Changes services to instead build as standalone executables, and
teaches the service manager how to launch them.

BUG=642879
Review-Url: https://codereview.chromium.org/2557213002
Committed: https://crrev.com/b8b2bfc86e7c3729593c14806c8d9f9fe08bb6ea
Cr-Commit-Position: refs/heads/master@{#437776}

[Ken Rockot(use gerrit already), 2016-12-08 00:55:23]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 00:55:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-12-08 00:57:38]

rockot@chromium.org changed reviewers:
+ ben@chromium.org

[commit-bot: I haz the power, 2016-12-08 00:59:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 00:59:26]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ken Rockot(use gerrit already), 2016-12-08 01:07:38]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 01:08:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ben Goodger (Google), 2016-12-08 01:09:31]

lgtm

[commit-bot: I haz the power, 2016-12-08 01:11:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 01:11:41]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ken Rockot(use gerrit already), 2016-12-08 01:16:09]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 01:16:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 01:35:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 01:35:44]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ken Rockot(use gerrit already), 2016-12-08 02:01:00]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 02:02:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 02:46:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 02:46:15]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Rockot(use gerrit already), 2016-12-08 06:57:10]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 06:57:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 07:33:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 07:33:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Rockot(use gerrit already), 2016-12-08 08:32:31]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 08:32:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 08:36:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 08:36:57]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Rockot(use gerrit already), 2016-12-08 08:44:40]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 08:44:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-12-08 08:54:56]

The CQ bit was unchecked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-12-08 08:54:59]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-12-08 08:54:59]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org
Link to the patchset: https://codereview.chromium.org/2557213002/#ps120001
(title: ".")

[commit-bot: I haz the power, 2016-12-08 08:55:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 09:39:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 09:39:21]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Ken Rockot(use gerrit already), 2016-12-08 17:48:55]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 17:49:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 19:11:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 19:11:35]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Rockot(use gerrit already), 2016-12-08 19:18:47]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 19:19:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 20:21:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 20:21:25]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Ken Rockot(use gerrit already), 2016-12-08 23:46:11]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 23:46:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 23:57:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 23:57:08]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Ken Rockot(use gerrit already), 2016-12-09 00:13:20]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 00:13:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-12-09 00:26:39]

The CQ bit was unchecked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-12-09 00:26:52]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 00:27:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-12-09 00:45:52]

The CQ bit was unchecked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-12-09 00:45:55]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-12-09 00:45:56]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org
Link to the patchset: https://codereview.chromium.org/2557213002/#ps200001
(title: ".")

[commit-bot: I haz the power, 2016-12-09 00:46:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 01:20:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 01:20:51]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Ken Rockot(use gerrit already), 2016-12-09 04:04:24]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 04:04:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-12-09 04:22:00]

The CQ bit was unchecked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-12-09 04:22:03]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-12-09 04:22:03]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org
Link to the patchset: https://codereview.chromium.org/2557213002/#ps220001
(title: ".")

[commit-bot: I haz the power, 2016-12-09 04:22:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 04:55:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 04:55:59]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Ken Rockot(use gerrit already), 2016-12-09 18:04:51]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 18:05:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 19:53:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 19:53:10]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Ken Rockot(use gerrit already), 2016-12-09 22:17:01]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 22:18:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 01:25:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 01:25:29]

Dry run: This issue passed the CQ dry run.

[Ken Rockot(use gerrit already), 2016-12-10 01:27:59]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-12-10 01:28:00]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org
Link to the patchset: https://codereview.chromium.org/2557213002/#ps260001
(title: ".")

[commit-bot: I haz the power, 2016-12-10 01:28:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 02:09:10]

CQ is committing da patch.

Bot data: {"patchset_id": 260001, "attempt_start_ts": 1481333279986010,
"parent_rev": "3fe372def2e801ef1f63d03fd811c23aed6fd4ea", "commit_rev":
"eda0df929f49b55c6cf63f7dd09c3bdcd871d5d9"}

[commit-bot: I haz the power, 2016-12-10 02:10:12]

Description was changed from

==========
Build services as standalone executables

Cleans up a bunch of service manager details which exist to support
the currently untenable goal of dynamically loading service binaries
in a common host executable.

Changes services to instead build as standalone executables, and
teaches the service manager how to launch them.

BUG=642879
==========

to

==========
Build services as standalone executables

Cleans up a bunch of service manager details which exist to support
the currently untenable goal of dynamically loading service binaries
in a common host executable.

Changes services to instead build as standalone executables, and
teaches the service manager how to launch them.

BUG=642879

Review-Url: https://codereview.chromium.org/2557213002
==========

[commit-bot: I haz the power, 2016-12-10 02:10:14]

Committed patchset #14 (id:260001)

[Ken Rockot(use gerrit already), 2016-12-10 04:37:18]

A revert of this CL (patchset #14 id:260001) has been created in
https://codereview.chromium.org/2566663004/ by rockot@chromium.org.

The reason for reverting is: Lots of test failures - ICU data not being found in
service processes..

[Ken Rockot(use gerrit already), 2016-12-10 07:03:13]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-10 07:03:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-12-10 07:03:34]

The CQ bit was unchecked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-12-10 07:03:38]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-12-10 07:03:39]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org
Link to the patchset: https://codereview.chromium.org/2557213002/#ps280001
(title: "remove DCHECKs with side effects -_-")

[commit-bot: I haz the power, 2016-12-10 07:03:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 08:34:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 08:34:37]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ken Rockot(use gerrit already), 2016-12-10 18:44:00]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2016-12-10 18:44:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 19:29:45]

CQ is committing da patch.

Bot data: {"patchset_id": 280001, "attempt_start_ts": 1481395440320100,
"parent_rev": "3fc5d578b39045ae3990ea0c107c292116ab9149", "commit_rev":
"03bd1f6cc5386abb9313deabd28fc7349cee756c"}

[commit-bot: I haz the power, 2016-12-10 19:30:14]

Description was changed from

==========
Build services as standalone executables

Cleans up a bunch of service manager details which exist to support
the currently untenable goal of dynamically loading service binaries
in a common host executable.

Changes services to instead build as standalone executables, and
teaches the service manager how to launch them.

BUG=642879

Review-Url: https://codereview.chromium.org/2557213002
==========

to

==========
Build services as standalone executables

Cleans up a bunch of service manager details which exist to support
the currently untenable goal of dynamically loading service binaries
in a common host executable.

Changes services to instead build as standalone executables, and
teaches the service manager how to launch them.

BUG=642879

Review-Url: https://codereview.chromium.org/2557213002
Review-Url: https://codereview.chromium.org/2557213002
==========

[commit-bot: I haz the power, 2016-12-10 19:30:16]

Committed patchset #15 (id:280001)

[commit-bot: I haz the power, 2016-12-12 15:05:25]

Description was changed from

==========
Build services as standalone executables

Cleans up a bunch of service manager details which exist to support
the currently untenable goal of dynamically loading service binaries
in a common host executable.

Changes services to instead build as standalone executables, and
teaches the service manager how to launch them.

BUG=642879

Review-Url: https://codereview.chromium.org/2557213002
Review-Url: https://codereview.chromium.org/2557213002
==========

to

==========
Build services as standalone executables

Cleans up a bunch of service manager details which exist to support
the currently untenable goal of dynamically loading service binaries
in a common host executable.

Changes services to instead build as standalone executables, and
teaches the service manager how to launch them.

BUG=642879

Committed: https://crrev.com/d65d4dc16cdd2293d44b943184fc267c7bf9ffe0
Cr-Commit-Position: refs/heads/master@{#437725}
==========

[commit-bot: I haz the power, 2016-12-12 15:05:26]

Patchset 15 (id:??) landed as
https://crrev.com/d65d4dc16cdd2293d44b943184fc267c7bf9ffe0
Cr-Commit-Position: refs/heads/master@{#437725}

[commit-bot: I haz the power, 2016-12-12 15:07:15]

Description was changed from

==========
Build services as standalone executables

Cleans up a bunch of service manager details which exist to support
the currently untenable goal of dynamically loading service binaries
in a common host executable.

Changes services to instead build as standalone executables, and
teaches the service manager how to launch them.

BUG=642879

Committed: https://crrev.com/d65d4dc16cdd2293d44b943184fc267c7bf9ffe0
Cr-Commit-Position: refs/heads/master@{#437725}
==========

to

==========
Build services as standalone executables

Cleans up a bunch of service manager details which exist to support
the currently untenable goal of dynamically loading service binaries
in a common host executable.

Changes services to instead build as standalone executables, and
teaches the service manager how to launch them.

BUG=642879

Review-Url: https://codereview.chromium.org/2557213002
Committed: https://crrev.com/b8b2bfc86e7c3729593c14806c8d9f9fe08bb6ea
Cr-Commit-Position: refs/heads/master@{#437776}
==========

[commit-bot: I haz the power, 2016-12-12 15:07:17]

Patchset 15 (id:??) landed as
https://crrev.com/b8b2bfc86e7c3729593c14806c8d9f9fe08bb6ea
Cr-Commit-Position: refs/heads/master@{#437776}

[aizatsky, 2016-12-12 22:13:44]

aizatsky@chromium.org changed reviewers:
+ aizatsky@chromium.org

[aizatsky, 2016-12-12 22:13:45]

This change breaks asan libfuzzer bot:


https://build.chromium.org/p/chromium.fyi/builders/Libfuzzer%20Upload%20Linux...

http://google.github.io/sanitizers/show_bots.html

[Ken Rockot(use gerrit already), 2016-12-12 22:27:44]

On 2016/12/12 at 22:13:45, aizatsky wrote:
> This change breaks asan libfuzzer bot:
> 
> 
>
https://build.chromium.org/p/chromium.fyi/builders/Libfuzzer%20Upload%20Linux...
> 
> http://google.github.io/sanitizers/show_bots.html

Looking

[kylechar, 2016-12-12 22:29:41]

On 2016/12/12 22:13:45, aizatsky wrote:
> This change breaks asan libfuzzer bot:
> 
> 
>
https://build.chromium.org/p/chromium.fyi/builders/Libfuzzer%20Upload%20Linux...
> 
> http://google.github.io/sanitizers/show_bots.html

This change also breaks running ./chrome --mash. It produces the error:

LaunchProcess: failed to execvp:
<out_dir>/chrome

[Ken Rockot(use gerrit already), 2016-12-12 22:35:42]

That's fixed by https://codereview.chromium.org/2573593002 which hasn't
landed yet because slow CQ.

On Mon, Dec 12, 2016 at 2:29 PM, <kylechar@chromium.org> wrote:

> On 2016/12/12 22:13:45, aizatsky wrote:
> > This change breaks asan libfuzzer bot:
> >
> >
> >
> https://build.chromium.org/p/chromium.fyi/builders/
> Libfuzzer%20Upload%20Linux%20ASan%20Debug/builds/1451/
> steps/compile/logs/stdio
> >
> > http://google.github.io/sanitizers/show_bots.html
>
> This change also breaks running ./chrome --mash. It produces the error:
>
> LaunchProcess: failed to execvp:
> <out_dir>/chrome
>
>
> https://codereview.chromium.org/2557213002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Ken Rockot(use gerrit already), 2016-12-12 22:46:16]

On 2016/12/12 at 22:27:44, Ken Rockot wrote:
> On 2016/12/12 at 22:13:45, aizatsky wrote:
> > This change breaks asan libfuzzer bot:
> > 
> > 
> >
https://build.chromium.org/p/chromium.fyi/builders/Libfuzzer%20Upload%20Linux...
> > 
> > http://google.github.io/sanitizers/show_bots.html
> 
> Looking

So I can create a trivial GN executable target which does nothing more than
depend on basic stl stream stuff (in this case stringstream), and it fails to
link under an is_asan = true configuration with similar errors. I think that
means there's a problem with the ASAN configuration, not with this CL.

[Ken Rockot(use gerrit already), 2016-12-12 23:28:12]

On 2016/12/12 at 22:46:16, Ken Rockot wrote:
> On 2016/12/12 at 22:27:44, Ken Rockot wrote:
> > On 2016/12/12 at 22:13:45, aizatsky wrote:
> > > This change breaks asan libfuzzer bot:
> > > 
> > > 
> > >
https://build.chromium.org/p/chromium.fyi/builders/Libfuzzer%20Upload%20Linux...
> > > 
> > > http://google.github.io/sanitizers/show_bots.html
> > 
> > Looking
> 
> So I can create a trivial GN executable target which does nothing more than
depend on basic stl stream stuff (in this case stringstream), and it fails to
link under an is_asan = true configuration with similar errors. I think that
means there's a problem with the ASAN configuration, not with this CL.

Ah, apparently we require executable targets to explicitly link against
//build/config/sanitizers:deps to buildable in a sanitizer environment. I'm
landing a change which does this for the newly introduced executable targets.

[Łukasz Anforowicz, 2016-12-12 23:53:20]

On 2016/12/12 23:28:12, Ken Rockot wrote:
> On 2016/12/12 at 22:46:16, Ken Rockot wrote:
> > On 2016/12/12 at 22:27:44, Ken Rockot wrote:
> > > On 2016/12/12 at 22:13:45, aizatsky wrote:
> > > > This change breaks asan libfuzzer bot:
> > > > 
> > > > 
> > > >
>
https://build.chromium.org/p/chromium.fyi/builders/Libfuzzer%20Upload%20Linux...
> > > > 
> > > > http://google.github.io/sanitizers/show_bots.html
> > > 
> > > Looking
> > 
> > So I can create a trivial GN executable target which does nothing more than
> depend on basic stl stream stuff (in this case stringstream), and it fails to
> link under an is_asan = true configuration with similar errors. I think that
> means there's a problem with the ASAN configuration, not with this CL.
> 
> Ah, apparently we require executable targets to explicitly link against
> //build/config/sanitizers:deps to buildable in a sanitizer environment. I'm
> landing a change which does this for the newly introduced executable targets.

FWIW, I've also bumped into this (I use ASAN builds for local development) and
opened https://crbug.com/673535 to track this.