Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Unified Diff: services/service_manager/runner/host/out_of_process_native_runner.h

Issue 2566663004: Revert of Build services as standalone executables (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/service_manager/runner/host/out_of_process_native_runner.h
diff --git a/services/service_manager/runner/host/out_of_process_native_runner.h b/services/service_manager/runner/host/out_of_process_native_runner.h
index e2e8e4f4d73f616592bc781237ed241a4787c39a..df61565b7ef18823e0d2b1c71541d485dcd34d98 100644
--- a/services/service_manager/runner/host/out_of_process_native_runner.h
+++ b/services/service_manager/runner/host/out_of_process_native_runner.h
@@ -24,17 +24,17 @@
class ChildProcessHost;
class NativeRunnerDelegate;
-// An implementation of |NativeRunner| that runs a given service executable
-// in a separate, dedicated process.
+// An implementation of |NativeRunner| that loads/runs the given app (from the
+// file system) in a separate process (of its own).
class OutOfProcessNativeRunner : public NativeRunner {
public:
- OutOfProcessNativeRunner(const base::FilePath& service_path,
- base::TaskRunner* launch_process_runner,
+ OutOfProcessNativeRunner(base::TaskRunner* launch_process_runner,
NativeRunnerDelegate* delegate);
~OutOfProcessNativeRunner() override;
// NativeRunner:
mojom::ServicePtr Start(
+ const base::FilePath& app_path,
const Identity& identity,
bool start_sandboxed,
const base::Callback<void(base::ProcessId)>& pid_available_callback,
@@ -46,7 +46,7 @@
base::TaskRunner* const launch_process_runner_;
NativeRunnerDelegate* delegate_;
- const base::FilePath service_path_;
+ base::FilePath app_path_;
base::Closure app_completed_callback_;
std::unique_ptr<ChildProcessHost> child_process_host_;
@@ -60,8 +60,7 @@
NativeRunnerDelegate* delegate);
~OutOfProcessNativeRunnerFactory() override;
- std::unique_ptr<NativeRunner> Create(
- const base::FilePath& service_path) override;
+ std::unique_ptr<NativeRunner> Create(const base::FilePath& app_path) override;
private:
base::TaskRunner* const launch_process_runner_;

Powered by Google App Engine
This is Rietveld 408576698