Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1557)

Unified Diff: services/service_manager/native_runner.h

Issue 2566663004: Revert of Build services as standalone executables (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/service_manager/native_runner.h
diff --git a/services/service_manager/native_runner.h b/services/service_manager/native_runner.h
index 505ed509f1189b637bd90240354232885f784675..9d97c3c3aa9f9c05fd61421356be2b5ed22fd801 100644
--- a/services/service_manager/native_runner.h
+++ b/services/service_manager/native_runner.h
@@ -25,21 +25,22 @@
public:
virtual ~NativeRunner() {}
- // Loads the app in the file at |service_path| and runs it on some other
+ // Loads the app in the file at |app_path| and runs it on some other
// thread/process. Returns a Service handle the service manager can use to
// connect to the the app.
virtual mojom::ServicePtr Start(
+ const base::FilePath& app_path,
const Identity& target,
bool start_sandboxed,
const base::Callback<void(base::ProcessId)>& pid_available_callback,
- const base::Closure& service_completed_callback) = 0;
+ const base::Closure& app_completed_callback) = 0;
};
class NativeRunnerFactory {
public:
virtual ~NativeRunnerFactory() {}
virtual std::unique_ptr<NativeRunner> Create(
- const base::FilePath& service_path) = 0;
+ const base::FilePath& app_path) = 0;
};
} // namespace service_manager

Powered by Google App Engine
This is Rietveld 408576698