Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 2566453002: [OfflinePages] Rename PRERENDERING_* result terminology to LOADING_* (Closed)

Created:
4 years ago by dougarnett
Modified:
4 years ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, dewittj+watch_chromium.org, tburkard+watch_chromium.org, fgorski+watch_chromium.org, romax+watch_chromium.org, petewil+watch_chromium.org, gavinp+prer_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[OfflinePages] Rename PRERENDERING_* result terminology to LOADING_* As we prepare for making new background loader an option over the prerendering loader, we need to either generalize Offliner and BackgroundSavePageResult result terminology or create a new set of results for the new loader. This CL generalizes that terminology. BUG=670529 Committed: https://crrev.com/926b579529f4f67ab2a22364ac1d9ea1eb29a475 Cr-Commit-Position: refs/heads/master@{#437355}

Patch Set 1 #

Patch Set 2 : Updated histogram enum #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -76 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageSavePageLaterEvaluationTest.java View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/android/offline_pages/prerendering_loader.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/android/offline_pages/prerendering_loader_unittest.cc View 6 chunks +6 lines, -10 lines 0 comments Download
M chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M components/offline_pages/core/background/offliner.h View 2 chunks +9 lines, -9 lines 0 comments Download
M components/offline_pages/core/background/request_coordinator.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M components/offline_pages/core/background/request_coordinator_event_logger.cc View 2 chunks +14 lines, -14 lines 0 comments Download
M components/offline_pages/core/background/request_coordinator_unittest.cc View 6 chunks +8 lines, -10 lines 0 comments Download
M components/offline_pages/core/background/request_notifier.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/offline_pages/core/downloads/download_notifying_observer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
dougarnett
4 years ago (2016-12-08 19:01:47 UTC) #4
Pete Williamson
lgtm
4 years ago (2016-12-08 19:20:19 UTC) #5
chili
lgtm Thanks Doug!
4 years ago (2016-12-08 19:30:11 UTC) #6
dougarnett
Steven, please review this terminology change (generalization) of some existing histogram enum values.
4 years ago (2016-12-08 19:56:53 UTC) #8
Steven Holte
histograms lgtm
4 years ago (2016-12-08 20:25:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566453002/20001
4 years ago (2016-12-08 20:53:31 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-08 21:42:16 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-08 21:44:46 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/926b579529f4f67ab2a22364ac1d9ea1eb29a475
Cr-Commit-Position: refs/heads/master@{#437355}

Powered by Google App Engine
This is Rietveld 408576698