Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Side by Side Diff: components/offline_pages/core/background/request_notifier.h

Issue 2566453002: [OfflinePages] Rename PRERENDERING_* result terminology to LOADING_* (Closed)
Patch Set: Updated histogram enum Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_OFFLINE_PAGES_CORE_BACKGROUND_REQUEST_NOTIFIER_H_ 5 #ifndef COMPONENTS_OFFLINE_PAGES_CORE_BACKGROUND_REQUEST_NOTIFIER_H_
6 #define COMPONENTS_OFFLINE_PAGES_CORE_BACKGROUND_REQUEST_NOTIFIER_H_ 6 #define COMPONENTS_OFFLINE_PAGES_CORE_BACKGROUND_REQUEST_NOTIFIER_H_
7 7
8 namespace offline_pages { 8 namespace offline_pages {
9 9
10 class SavePageRequest; 10 class SavePageRequest;
11 11
12 class RequestNotifier { 12 class RequestNotifier {
13 public: 13 public:
14 // Status to return for failed notifications. 14 // Status to return for failed notifications.
15 // NOTE: for any changes to the enum, please also update related switch code 15 // NOTE: for any changes to the enum, please also update related switch code
16 // in RequestCoordinatorEventLogger. 16 // in RequestCoordinatorEventLogger.
17 // GENERATED_JAVA_ENUM_PACKAGE:org.chromium.components.offlinepages 17 // GENERATED_JAVA_ENUM_PACKAGE:org.chromium.components.offlinepages
18 enum class BackgroundSavePageResult { 18 enum class BackgroundSavePageResult {
19 SUCCESS, 19 SUCCESS,
20 PRERENDER_FAILURE, 20 LOADING_FAILURE,
21 PRERENDER_CANCELED, 21 LOADING_CANCELED,
22 FOREGROUND_CANCELED, 22 FOREGROUND_CANCELED,
23 SAVE_FAILED, 23 SAVE_FAILED,
24 EXPIRED, 24 EXPIRED,
25 RETRY_COUNT_EXCEEDED, 25 RETRY_COUNT_EXCEEDED,
26 START_COUNT_EXCEEDED, 26 START_COUNT_EXCEEDED,
27 REMOVED, 27 REMOVED,
28 }; 28 };
29 29
30 virtual ~RequestNotifier() = default; 30 virtual ~RequestNotifier() = default;
31 31
32 // Notifies observers that |request| has been added. 32 // Notifies observers that |request| has been added.
33 virtual void NotifyAdded(const SavePageRequest& request) = 0; 33 virtual void NotifyAdded(const SavePageRequest& request) = 0;
34 34
35 // Notifies observers that |request| has been completed with |status|. 35 // Notifies observers that |request| has been completed with |status|.
36 virtual void NotifyCompleted(const SavePageRequest& request, 36 virtual void NotifyCompleted(const SavePageRequest& request,
37 BackgroundSavePageResult status) = 0; 37 BackgroundSavePageResult status) = 0;
38 38
39 // Notifies observers that |request| has been changed. 39 // Notifies observers that |request| has been changed.
40 virtual void NotifyChanged(const SavePageRequest& request) = 0; 40 virtual void NotifyChanged(const SavePageRequest& request) = 0;
41 }; 41 };
42 42
43 } // namespace offline_pages 43 } // namespace offline_pages
44 44
45 #endif // COMPONENTS_OFFLINE_PAGES_CORE_BACKGROUND_REQUEST_NOTIFIER_H_ 45 #endif // COMPONENTS_OFFLINE_PAGES_CORE_BACKGROUND_REQUEST_NOTIFIER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698