components/offline_pages/core/downloads/download_notifying_observer_unittest.cc - Issue 2566453002: [OfflinePages] Rename PRERENDERING_* result terminology to LOADING_*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/core/downloads/download_notifying_observer_unittest.cc

Issue 2566453002: [OfflinePages] Rename PRERENDERING_* result terminology to LOADING_* (Closed)

Patch Set: Updated histogram enum Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/offline_pages/core/downloads/download_notifying_observer_unittest.cc

diff --git a/components/offline_pages/core/downloads/download_notifying_observer_unittest.cc b/components/offline_pages/core/downloads/download_notifying_observer_unittest.cc

index 75d1f898f20b221a9ee8389563e9f272faccabb7..6db87708702286214aeeb9cd393658b01052247f 100644

--- a/components/offline_pages/core/downloads/download_notifying_observer_unittest.cc

+++ b/components/offline_pages/core/downloads/download_notifying_observer_unittest.cc

@@ -224,7 +224,7 @@ TEST_F(DownloadNotifyingObserverTest, OnCompletedFailure) {

SavePageRequest request(kTestOfflineId, GURL(kTestUrl), kTestClientId,

kTestCreationTime, kTestUserRequested);

observer()->OnCompleted(

- request, RequestNotifier::BackgroundSavePageResult::PRERENDER_FAILURE);

+ request, RequestNotifier::BackgroundSavePageResult::LOADING_FAILURE);

EXPECT_EQ(LastNotificationType::DOWNLOAD_FAILED,

notifier()->last_notification_type());

EXPECT_EQ(kTestGuid, notifier()->download_item()->guid);

« no previous file with comments | « components/offline_pages/core/background/request_notifier.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »