Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: chrome/browser/android/offline_pages/prerendering_loader_unittest.cc

Issue 2566453002: [OfflinePages] Rename PRERENDERING_* result terminology to LOADING_* (Closed)
Patch Set: Updated histogram enum Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/prerendering_loader_unittest.cc
diff --git a/chrome/browser/android/offline_pages/prerendering_loader_unittest.cc b/chrome/browser/android/offline_pages/prerendering_loader_unittest.cc
index e51baa5a180eb142559bd60324090bf2dedaf6b9..d7ce9f82633c6bb7d37409d1ce1b14222545dcc4 100644
--- a/chrome/browser/android/offline_pages/prerendering_loader_unittest.cc
+++ b/chrome/browser/android/offline_pages/prerendering_loader_unittest.cc
@@ -236,8 +236,7 @@ TEST_F(PrerenderingLoaderTest, LoadPageLoadSucceededFromPrerenderStopLoading) {
PumpLoop();
EXPECT_TRUE(loader()->IsIdle());
EXPECT_FALSE(loader()->IsLoaded());
- EXPECT_EQ(Offliner::RequestStatus::PRERENDERING_CANCELED,
- callback_load_status());
+ EXPECT_EQ(Offliner::RequestStatus::LOADING_CANCELED, callback_load_status());
EXPECT_FALSE(test_adapter()->IsActive());
}
@@ -257,8 +256,7 @@ TEST_F(PrerenderingLoaderTest, LoadPageLoadFailedNoContent) {
EXPECT_TRUE(loader()->IsIdle());
EXPECT_TRUE(callback_called());
// We did not provide any WebContents for the callback so expect did not load.
- EXPECT_EQ(Offliner::RequestStatus::PRERENDERING_FAILED,
- callback_load_status());
+ EXPECT_EQ(Offliner::RequestStatus::LOADING_FAILED, callback_load_status());
// Stopped event causes no harm.
test_adapter()->GetObserver()->OnPrerenderStop();
@@ -282,7 +280,7 @@ TEST_F(PrerenderingLoaderTest, LoadPageLoadFailedNoRetry) {
EXPECT_TRUE(callback_called());
// We did not provide any WebContents for the callback so expect did not load.
// FinalStatus is non-retryable failure.
- EXPECT_EQ(Offliner::RequestStatus::PRERENDERING_FAILED_NO_RETRY,
+ EXPECT_EQ(Offliner::RequestStatus::LOADING_FAILED_NO_RETRY,
callback_load_status());
// Stopped event causes no harm.
@@ -307,7 +305,7 @@ TEST_F(PrerenderingLoaderTest, LoadPageLoadFailedNoNext) {
EXPECT_TRUE(callback_called());
// We did not provide any WebContents for the callback so expect did not load.
// FinalStatus is non-next failure.
- EXPECT_EQ(Offliner::RequestStatus::PRERENDERING_FAILED_NO_NEXT,
+ EXPECT_EQ(Offliner::RequestStatus::LOADING_FAILED_NO_NEXT,
callback_load_status());
// Stopped event causes no harm.
@@ -330,8 +328,7 @@ TEST_F(PrerenderingLoaderTest, LoadPageLoadCanceled) {
PumpLoop();
EXPECT_TRUE(loader()->IsIdle());
EXPECT_TRUE(callback_called());
- EXPECT_EQ(Offliner::RequestStatus::PRERENDERING_CANCELED,
- callback_load_status());
+ EXPECT_EQ(Offliner::RequestStatus::LOADING_CANCELED, callback_load_status());
// Stopped event causes no harm.
test_adapter()->GetObserver()->OnPrerenderStop();
@@ -355,8 +352,7 @@ TEST_F(PrerenderingLoaderTest, LoadPageLoadFailedUnsupportedScheme) {
EXPECT_TRUE(callback_called());
// Unsupported Scheme final status currently considered a cancel rather
// than failure in case it is due to lost network connectivity.
- EXPECT_EQ(Offliner::RequestStatus::PRERENDERING_CANCELED,
- callback_load_status());
+ EXPECT_EQ(Offliner::RequestStatus::LOADING_CANCELED, callback_load_status());
// Stopped event causes no harm.
test_adapter()->GetObserver()->OnPrerenderStop();

Powered by Google App Engine
This is Rietveld 408576698