Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2076)

Unified Diff: chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc

Issue 2566453002: [OfflinePages] Rename PRERENDERING_* result terminology to LOADING_* (Closed)
Patch Set: Updated histogram enum Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc
diff --git a/chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc b/chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc
index 50eb9f7576b6495692e87aea53788e47b9f6660e..261a6544ab8e385a38f2827bc26067b3971173f7 100644
--- a/chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc
+++ b/chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc
@@ -62,9 +62,9 @@ class MockPrerenderingLoader : public PrerenderingLoader {
mock_loading_ = false;
mock_loaded_ = false;
base::ThreadTaskRunnerHandle::Get()->PostTask(
- FROM_HERE, base::Bind(load_page_callback_,
- Offliner::RequestStatus::PRERENDERING_FAILED,
- nullptr /* web_contents */));
+ FROM_HERE,
+ base::Bind(load_page_callback_, Offliner::RequestStatus::LOADING_FAILED,
+ nullptr /* web_contents */));
}
void CompleteLoadingAsLoaded() {
@@ -84,7 +84,7 @@ class MockPrerenderingLoader : public PrerenderingLoader {
mock_loaded_ = false;
base::ThreadTaskRunnerHandle::Get()->PostTask(
FROM_HERE, base::Bind(load_page_callback_,
- Offliner::RequestStatus::PRERENDERING_CANCELED,
+ Offliner::RequestStatus::LOADING_CANCELED,
nullptr /* web_contents */));
}
@@ -255,7 +255,7 @@ TEST_F(PrerenderingOfflinerTest, LoadAndSaveLoadStartedButFails) {
loader()->CompleteLoadingAsFailed();
PumpLoop();
EXPECT_TRUE(completion_callback_called());
- EXPECT_EQ(Offliner::RequestStatus::PRERENDERING_FAILED, request_status());
+ EXPECT_EQ(Offliner::RequestStatus::LOADING_FAILED, request_status());
EXPECT_TRUE(loader()->IsIdle());
EXPECT_FALSE(SaveInProgress());
}
@@ -361,7 +361,7 @@ TEST_F(PrerenderingOfflinerTest, LoadAndSaveLoadedButThenCanceledFromLoader) {
loader()->CompleteLoadingAsCanceled();
PumpLoop();
EXPECT_TRUE(completion_callback_called());
- EXPECT_EQ(Offliner::RequestStatus::PRERENDERING_CANCELED, request_status());
+ EXPECT_EQ(Offliner::RequestStatus::LOADING_CANCELED, request_status());
EXPECT_FALSE(loader()->IsLoaded());
// Note: save still in progress since it does not support canceling.
EXPECT_TRUE(SaveInProgress());

Powered by Google App Engine
This is Rietveld 408576698