Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1855)

Unified Diff: components/offline_pages/core/background/request_coordinator_unittest.cc

Issue 2566453002: [OfflinePages] Rename PRERENDERING_* result terminology to LOADING_* (Closed)
Patch Set: Updated histogram enum Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/core/background/request_coordinator_unittest.cc
diff --git a/components/offline_pages/core/background/request_coordinator_unittest.cc b/components/offline_pages/core/background/request_coordinator_unittest.cc
index 45dddbd4d66fe0e86564508919276712efa14bb6..ecb5e8e1c16b2b5dcdebc3065a7cb1bb6427f70b 100644
--- a/components/offline_pages/core/background/request_coordinator_unittest.cc
+++ b/components/offline_pages/core/background/request_coordinator_unittest.cc
@@ -602,8 +602,7 @@ TEST_F(RequestCoordinatorTest, OfflinerDoneRequestFailed) {
// Call the OfflinerDoneCallback to simulate the request failed, wait
// for callbacks.
- SendOfflinerDoneCallback(request,
- Offliner::RequestStatus::PRERENDERING_FAILED);
+ SendOfflinerDoneCallback(request, Offliner::RequestStatus::LOADING_FAILED);
PumpLoop();
// For retriable failure, processing should continue to 2nd request so
@@ -641,8 +640,8 @@ TEST_F(RequestCoordinatorTest, OfflinerDoneRequestFailedNoRetryFailure) {
// Call the OfflinerDoneCallback to simulate the request failed, wait
// for callbacks.
- SendOfflinerDoneCallback(
- request, Offliner::RequestStatus::PRERENDERING_FAILED_NO_RETRY);
+ SendOfflinerDoneCallback(request,
+ Offliner::RequestStatus::LOADING_FAILED_NO_RETRY);
PumpLoop();
// For no retry failure, processing should continue to 2nd request so
@@ -661,7 +660,7 @@ TEST_F(RequestCoordinatorTest, OfflinerDoneRequestFailedNoRetryFailure) {
// Check that the observer got the notification that we failed (and the
// subsequent notification that the request was removed).
EXPECT_TRUE(observer().completed_called());
- EXPECT_EQ(RequestCoordinator::BackgroundSavePageResult::PRERENDER_FAILURE,
+ EXPECT_EQ(RequestCoordinator::BackgroundSavePageResult::LOADING_FAILURE,
observer().last_status());
}
@@ -678,8 +677,8 @@ TEST_F(RequestCoordinatorTest, OfflinerDoneRequestFailedNoNextFailure) {
// Call the OfflinerDoneCallback to simulate the request failed, wait
// for callbacks.
- SendOfflinerDoneCallback(
- request, Offliner::RequestStatus::PRERENDERING_FAILED_NO_NEXT);
+ SendOfflinerDoneCallback(request,
+ Offliner::RequestStatus::LOADING_FAILED_NO_NEXT);
PumpLoop();
// For no next failure, processing should not continue to 2nd request so
@@ -729,8 +728,7 @@ TEST_F(RequestCoordinatorTest, OfflinerDonePrerenderingCancel) {
// Call the OfflinerDoneCallback to simulate the request failed, wait
// for callbacks.
- SendOfflinerDoneCallback(request,
- Offliner::RequestStatus::PRERENDERING_CANCELED);
+ SendOfflinerDoneCallback(request, Offliner::RequestStatus::LOADING_CANCELED);
PumpLoop();
EXPECT_TRUE(immediate_schedule_callback_called());
@@ -840,7 +838,7 @@ TEST_F(RequestCoordinatorTest, StartProcessingWithLoadingDisabled) {
EXPECT_TRUE(immediate_schedule_callback_called());
EXPECT_FALSE(is_starting());
- EXPECT_EQ(Offliner::PRERENDERING_NOT_STARTED, last_offlining_status());
+ EXPECT_EQ(Offliner::LOADING_NOT_STARTED, last_offlining_status());
}
// This tests a StopProcessing call before we have actually started the

Powered by Google App Engine
This is Rietveld 408576698