Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2565243002: Revert of gpu: Move ShaderDiskCache into //gpu/ipc/host component. (Closed)

Created:
4 years ago by gab
Modified:
4 years ago
CC:
chromium-reviews, wjmaclean, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of gpu: Move ShaderDiskCache into //gpu/ipc/host component. (patchset #5 id:80001 of https://codereview.chromium.org/2555693005/ ) Reason for revert: Makes StoragePartitionShaderClearTest.ClearShaderCache fail on Linux Tests bot: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29 Original issue's description: > gpu: Move ShaderDiskCache into //gpu/ipc/host component. > > BUG=643746, 604369 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2555693005 TBR=piman@chromium.org,rch@chromium.org,rsleevi@chromium.org,ben@chromium.org,sadrul@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=643746, 604369 Committed: https://crrev.com/a3533cd71ad51ad93a34bfed5bf1762ef936f411 Cr-Commit-Position: refs/heads/master@{#437812}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+888 lines, -885 lines) Patch
M content/browser/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/browser_main_loop.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M content/browser/gpu/browser_gpu_channel_host_factory.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M content/browser/gpu/gpu_process_host.h View 3 chunks +2 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A content/browser/gpu/shader_disk_cache.h View 1 chunk +174 lines, -0 lines 0 comments Download
A content/browser/gpu/shader_disk_cache.cc View 1 chunk +607 lines, -0 lines 0 comments Download
A content/browser/gpu/shader_disk_cache_unittest.cc View 1 chunk +80 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/browser/storage_partition_impl.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M content/browser/storage_partition_impl_unittest.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M content/test/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M gpu/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M gpu/ipc/host/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
D gpu/ipc/host/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D gpu/ipc/host/shader_disk_cache.h View 1 chunk +0 lines, -169 lines 0 comments Download
D gpu/ipc/host/shader_disk_cache.cc View 1 chunk +0 lines, -598 lines 0 comments Download
D gpu/ipc/host/shader_disk_cache_unittest.cc View 1 chunk +0 lines, -83 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
gab
Created Revert of gpu: Move ShaderDiskCache into //gpu/ipc/host component.
4 years ago (2016-12-11 23:25:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565243002/1
4 years ago (2016-12-11 23:25:38 UTC) #3
gab
Failure log below, probably missing a content::TestBrowserThreadBundle to get BrowserThread::IO (which you probably can't use ...
4 years ago (2016-12-11 23:26:47 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/196758)
4 years ago (2016-12-12 01:11:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565243002/1
4 years ago (2016-12-12 01:48:24 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-12 02:47:06 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-12 15:10:20 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a3533cd71ad51ad93a34bfed5bf1762ef936f411
Cr-Commit-Position: refs/heads/master@{#437812}

Powered by Google App Engine
This is Rietveld 408576698