Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 2565123002: Unify code to query D3D device object from ANGLE (Closed)

Created:
4 years ago by jbauman
Modified:
4 years ago
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Unify code to query D3D device object from ANGLE We need to be able to do this in several places (soon including some outside media/). CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/575788b2f001721dc0e5f428441e244effce57a2 Cr-Commit-Position: refs/heads/master@{#438923}

Patch Set 1 #

Patch Set 2 : fix DEPS #

Patch Set 3 : add export #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -156 lines) Patch
M media/gpu/d3d11_video_decode_accelerator_win.cc View 1 3 chunks +2 lines, -78 lines 0 comments Download
M media/gpu/dxva_video_decode_accelerator_win.cc View 5 chunks +4 lines, -78 lines 0 comments Download
M ui/gl/BUILD.gn View 1 2 chunks +4 lines, -0 lines 0 comments Download
M ui/gl/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A ui/gl/gl_angle_util_win.h View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
A ui/gl/gl_angle_util_win.cc View 1 chunk +85 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (19 generated)
jbauman
4 years ago (2016-12-13 03:33:06 UTC) #13
sandersd (OOO until July 31)
lgtm
4 years ago (2016-12-15 00:47:22 UTC) #16
jbauman
Also adding ben@ for a review of adding some third_party/angle/include files to ui/gl/DEPS, I guess.
4 years ago (2016-12-15 01:21:50 UTC) #18
Ben Goodger (Google)
lgtm
4 years ago (2016-12-15 15:26:40 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565123002/40001
4 years ago (2016-12-15 18:56:30 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-15 21:07:02 UTC) #24
commit-bot: I haz the power
4 years ago (2016-12-15 21:11:45 UTC) #26
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/575788b2f001721dc0e5f428441e244effce57a2
Cr-Commit-Position: refs/heads/master@{#438923}

Powered by Google App Engine
This is Rietveld 408576698