Last round of cleaning up MD layout constants.

Last round of cleaning up MD layout constants.

BUG=660445
Committed: https://crrev.com/2c4e98197eefddf7f25cc42e6142c80a5e500323
Cr-Commit-Position: refs/heads/master@{#438014}

[Evan Stade, 2016-12-05 23:52:37]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 23:53:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2016-12-06 00:11:23]

estade@chromium.org changed reviewers:
+ pkasting@chromium.org

[commit-bot: I haz the power, 2016-12-06 01:04:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 01:04:33]

Dry run: This issue passed the CQ dry run.

[Peter Kasting, 2016-12-06 04:12:24]

https://codereview.chromium.org/2555623002/diff/1/chrome/browser/ui/layout_co...
File chrome/browser/ui/layout_constants.cc (right):

https://codereview.chromium.org/2555623002/diff/1/chrome/browser/ui/layout_co...
chrome/browser/ui/layout_constants.cc:16: return 4;
Usually with these constants that don't depend on MD state, I would suggest
making them a public constexpr member of a relevant class or namespace.  This
makes the conceptual dependency of other classes on the defining class a bit
clearer in code, and it makes it a bit easier to find the constant value in
codesearch (it's a single click of a cross reference).

(My eventual hope was that we could either kill this file entirely, or rename it
and its methods to make clear that we only really need it for constants whose
values change at runtime.)

The downside of this is consistency (some constants are kFooBar, some are
GetLayoutConstant(FOO_BAR)), but we already have that downside today, and I'm
not convinced making it worse is "that bad".

Are there other reasons to prefer leaving these here?

https://codereview.chromium.org/2555623002/diff/1/chrome/browser/ui/layout_co...
chrome/browser/ui/layout_constants.cc:66: return gfx::Size(hybrid ? 39 : 36,
hybrid ? 21 : 18);
Nit: Slightly longer, but seems easier to read:

      return hybrid ? gfx::Size(39, 21) : gfx::Size(36, 18);

[Evan Stade, 2016-12-06 18:04:36]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 18:05:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 18:16:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 18:16:19]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Evan Stade, 2016-12-07 01:13:25]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 01:13:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 01:52:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 01:52:24]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evan Stade, 2016-12-08 03:25:38]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 03:26:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 04:10:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 04:10:41]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2016-12-08 15:34:44]

https://codereview.chromium.org/2555623002/diff/1/chrome/browser/ui/layout_co...
File chrome/browser/ui/layout_constants.cc (right):

https://codereview.chromium.org/2555623002/diff/1/chrome/browser/ui/layout_co...
chrome/browser/ui/layout_constants.cc:16: return 4;
On 2016/12/06 04:12:24, Peter Kasting wrote:
> Usually with these constants that don't depend on MD state, I would suggest
> making them a public constexpr member of a relevant class or namespace.  This
> makes the conceptual dependency of other classes on the defining class a bit
> clearer in code, and it makes it a bit easier to find the constant value in
> codesearch (it's a single click of a cross reference).
> 
> (My eventual hope was that we could either kill this file entirely, or rename
it
> and its methods to make clear that we only really need it for constants whose
> values change at runtime.)
> 
> The downside of this is consistency (some constants are kFooBar, some are
> GetLayoutConstant(FOO_BAR)), but we already have that downside today, and I'm
> not convinced making it worse is "that bad".
> 
> Are there other reasons to prefer leaving these here?

not really. Moved.

https://codereview.chromium.org/2555623002/diff/1/chrome/browser/ui/layout_co...
chrome/browser/ui/layout_constants.cc:66: return gfx::Size(hybrid ? 39 : 36,
hybrid ? 21 : 18);
On 2016/12/06 04:12:24, Peter Kasting wrote:
> Nit: Slightly longer, but seems easier to read:
> 
>       return hybrid ? gfx::Size(39, 21) : gfx::Size(36, 18);

Done.

[Peter Kasting, 2016-12-08 20:57:50]

My only concern is the toolbar_button.cc changes.

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/frame/browser_non_client_frame_view.h (right):

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/browser_non_client_frame_view.h:68: static
constexpr int kAvatarIconPadding = 4;
Nit: Goes above constructor (see
http://google.github.io/styleguide/cppguide.html#Declaration_Order )

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc (right):

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc:411: const
int pad = kAvatarIconPadding;
Nit: Use directly below?  If not, could make constexpr

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc:451: const
int pad = kAvatarIconPadding;
Nit: Use directly below?  Or make constexpr

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc (right):

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc:374: const
int pad = kAvatarIconPadding;
Nit: Use directly below?

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc:427: const
int pad = kAvatarIconPadding;
Nit: Use directly below?  Or make constexpr

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/frame/browser_view_layout.cc (right):

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/browser_view_layout.cc:226: const int kOverlapDip
= 6;
Nit: Dip suffix optional (I don't mind it, but most of this CL omits it except
where it would be really unclear without)

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/frame/glass_browser_frame_view.cc (right):

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/glass_browser_frame_view.cc:741: const int pad =
kAvatarIconPadding;
Nit: Use directly below?  Or make constexpr

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc (right):

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc:372: const int
pad = OpaqueBrowserFrameView::kAvatarIconPadding;
Nit: Make constexpr?

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc (right):

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc:212: // The
location bar will add LOCATION_BAR_HORIZONTAL_PADDING after us.
Nit: Update comment

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/location_bar/location_bar_view.cc (right):

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/location_bar/location_bar_view.cc:223: const int
kDesiredFontSize = 14;
Nit: constexpr

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/location_bar/location_bar_view.cc:536: const int
item_padding = kHorizontalPadding;
Nit: Use directly below?  Or make constexpr

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/location_bar/location_bar_view.cc:741: const int
kInteriorPadding = 1;
Nit: constexpr

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/omnibox/omnibox_result_view.cc (right):

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/omnibox/omnibox_result_view.cc:592: int
horizontal_padding = LocationBarView::kHorizontalPadding;
Nit: Make constexpr?

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/tabs/tab.cc (right):

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/tabs/tab.cc:741: const int kTabPinnedContentWidth = 23;
Nit: Make constexpr

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/tabs/tab.cc:921: const int kTitleSpacing = 6;
Nit: Make constexpr

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/tabs/tab_strip.cc (right):

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/tabs/tab_strip.cc:2530: const int overlap =
Tab::kOverlap;
Nit: Use directly below

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/tabs/tab_strip.cc:2628: const int overlap =
Tab::kOverlap;
Nit: Use directly below?  Or make constexpr

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/toolbar/app_menu_button.cc (right):

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/toolbar/app_menu_button.cc:114: return rect.size();
Clever :)

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/toolbar/toolbar_button.cc (right):

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/toolbar/toolbar_button.cc:60: // TODO(estade): do we
ever actually set text on a ToolbarButton?
Maybe for extensions?

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/toolbar/toolbar_button.cc:62: CHECK_EQ(0,
label_size.width());
I'd kinda rather add something like this in a separate CL, just so you don't get
this whole one auto-reverted if this breaks something.

(Might be clearer to do as a CHECK(FALSE) inside the next conditional as well.)

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/toolbar/toolbar_button.cc:64:
size.Enlarge(label_size.width() /* + LocationBarView::kHorizontalPadding*/,
Commenting this out seems wrong?

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/toolbar/toolbar_button.h (right):

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/toolbar/toolbar_button.h:70: static constexpr int
kInteriorPadding = 6;
Nit: Goes above constructor

[Evan Stade, 2016-12-13 01:31:20]

thanks for your thoroughness.

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/frame/browser_non_client_frame_view.h (right):

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/browser_non_client_frame_view.h:68: static
constexpr int kAvatarIconPadding = 4;
On 2016/12/08 20:57:49, Peter Kasting wrote:
> Nit: Goes above constructor (see
> http://google.github.io/styleguide/cppguide.html#Declaration_Order )

thanks, for some reason my understanding stopped at "Within each section,
generally prefer grouping similar kinds of declarations together"

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc (right):

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc:411: const
int pad = kAvatarIconPadding;
On 2016/12/08 20:57:49, Peter Kasting wrote:
> Nit: Use directly below?  If not, could make constexpr

Done.

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc:451: const
int pad = kAvatarIconPadding;
On 2016/12/08 20:57:49, Peter Kasting wrote:
> Nit: Use directly below?  Or make constexpr

Done.

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc (right):

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc:374: const
int pad = kAvatarIconPadding;
On 2016/12/08 20:57:49, Peter Kasting wrote:
> Nit: Use directly below?

Done.

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc:427: const
int pad = kAvatarIconPadding;
On 2016/12/08 20:57:49, Peter Kasting wrote:
> Nit: Use directly below?  Or make constexpr

Done.

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/frame/browser_view_layout.cc (right):

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/browser_view_layout.cc:226: const int kOverlapDip
= 6;
On 2016/12/08 20:57:49, Peter Kasting wrote:
> Nit: Dip suffix optional (I don't mind it, but most of this CL omits it except
> where it would be really unclear without)

I guess I thought "kOverlap" was insufficiently descriptive. Changed to
kTopOverlap.

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/frame/glass_browser_frame_view.cc (right):

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/glass_browser_frame_view.cc:741: const int pad =
kAvatarIconPadding;
On 2016/12/08 20:57:49, Peter Kasting wrote:
> Nit: Use directly below?  Or make constexpr

Done.

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc (right):

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc:372: const int
pad = OpaqueBrowserFrameView::kAvatarIconPadding;
On 2016/12/08 20:57:49, Peter Kasting wrote:
> Nit: Make constexpr?

Done.

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc (right):

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc:212: // The
location bar will add LOCATION_BAR_HORIZONTAL_PADDING after us.
On 2016/12/08 20:57:49, Peter Kasting wrote:
> Nit: Update comment

Done.

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/location_bar/location_bar_view.cc (right):

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/location_bar/location_bar_view.cc:223: const int
kDesiredFontSize = 14;
On 2016/12/08 20:57:49, Peter Kasting wrote:
> Nit: constexpr

Done.

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/location_bar/location_bar_view.cc:536: const int
item_padding = kHorizontalPadding;
On 2016/12/08 20:57:49, Peter Kasting wrote:
> Nit: Use directly below?  Or make constexpr

Done.

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/location_bar/location_bar_view.cc:741: const int
kInteriorPadding = 1;
On 2016/12/08 20:57:49, Peter Kasting wrote:
> Nit: constexpr

Done.

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/omnibox/omnibox_result_view.cc (right):

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/omnibox/omnibox_result_view.cc:592: int
horizontal_padding = LocationBarView::kHorizontalPadding;
On 2016/12/08 20:57:49, Peter Kasting wrote:
> Nit: Make constexpr?

Done.

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/tabs/tab.cc (right):

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/tabs/tab.cc:741: const int kTabPinnedContentWidth = 23;
On 2016/12/08 20:57:50, Peter Kasting wrote:
> Nit: Make constexpr

Done.

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/tabs/tab.cc:921: const int kTitleSpacing = 6;
On 2016/12/08 20:57:50, Peter Kasting wrote:
> Nit: Make constexpr

Done.

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/tabs/tab_strip.cc (right):

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/tabs/tab_strip.cc:2530: const int overlap =
Tab::kOverlap;
On 2016/12/08 20:57:50, Peter Kasting wrote:
> Nit: Use directly below

Done.

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/tabs/tab_strip.cc:2628: const int overlap =
Tab::kOverlap;
On 2016/12/08 20:57:50, Peter Kasting wrote:
> Nit: Use directly below?  Or make constexpr

Done.

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/toolbar/app_menu_button.cc (right):

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/toolbar/app_menu_button.cc:114: return rect.size();
On 2016/12/08 20:57:50, Peter Kasting wrote:
> Clever :)

8)

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/toolbar/toolbar_button.cc (right):

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/toolbar/toolbar_button.cc:60: // TODO(estade): do we
ever actually set text on a ToolbarButton?
On 2016/12/08 20:57:50, Peter Kasting wrote:
> Maybe for extensions?

I don't see how extensions could reach this because ToolbarButton has only three
overrides: Back, Home and Reload, plus a direct instantiation for Forward.

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/toolbar/toolbar_button.cc:62: CHECK_EQ(0,
label_size.width());
On 2016/12/08 20:57:50, Peter Kasting wrote:
> I'd kinda rather add something like this in a separate CL, just so you don't
get
> this whole one auto-reverted if this breaks something.
> 
> (Might be clearer to do as a CHECK(FALSE) inside the next conditional as
well.)

oops --- this was just meant to be debug code I sent by the trybots to make sure
they were OK with removing this code. Between the trybots OK'ing this and my own
inability to find where something sets a label, I think we can simplify this
code.

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/toolbar/toolbar_button.cc:64:
size.Enlarge(label_size.width() /* + LocationBarView::kHorizontalPadding*/,
On 2016/12/08 20:57:50, Peter Kasting wrote:
> Commenting this out seems wrong?

yea, removed.

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/toolbar/toolbar_button.h (right):

https://codereview.chromium.org/2555623002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/toolbar/toolbar_button.h:70: static constexpr int
kInteriorPadding = 6;
On 2016/12/08 20:57:50, Peter Kasting wrote:
> Nit: Goes above constructor

Done.

[Evan Stade, 2016-12-13 01:31:25]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 01:32:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Kasting, 2016-12-13 01:40:01]

LGTM

[Evan Stade, 2016-12-13 01:44:38]

The CQ bit was unchecked by estade@chromium.org

[Evan Stade, 2016-12-13 01:44:43]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-12-13 01:45:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 03:08:41]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1481593483092450,
"parent_rev": "77e2361644343e5873c0dbdb5b97bf8c10c37a73", "commit_rev":
"754a82103d7685f9a68339ed2bb613386b7d5b82"}

[commit-bot: I haz the power, 2016-12-13 03:09:08]

Description was changed from

==========
Last round of cleaning up MD layout constants.

BUG=660445
==========

to

==========
Last round of cleaning up MD layout constants.

BUG=660445

Review-Url: https://codereview.chromium.org/2555623002
==========

[commit-bot: I haz the power, 2016-12-13 03:09:09]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-12-13 03:10:57]

Description was changed from

==========
Last round of cleaning up MD layout constants.

BUG=660445

Review-Url: https://codereview.chromium.org/2555623002
==========

to

==========
Last round of cleaning up MD layout constants.

BUG=660445

Committed: https://crrev.com/2c4e98197eefddf7f25cc42e6142c80a5e500323
Cr-Commit-Position: refs/heads/master@{#438014}
==========

[commit-bot: I haz the power, 2016-12-13 03:10:59]

Patchset 5 (id:??) landed as
https://crrev.com/2c4e98197eefddf7f25cc42e6142c80a5e500323
Cr-Commit-Position: refs/heads/master@{#438014}