Last round of cleaning up MD layout constants.

chrome/browser/ui/views/frame/browser_view_layout.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/browser_view_layout.h"
 
 #include "base/macros.h"
 #include "base/observer_list.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/find_bar/find_bar.h"
 #include "chrome/browser/ui/find_bar/find_bar_controller.h"
-#include "chrome/browser/ui/layout_constants.h"
 #include "chrome/browser/ui/search/search_model.h"
 #include "chrome/browser/ui/views/bookmarks/bookmark_bar_view.h"
 #include "chrome/browser/ui/views/download/download_shelf_view.h"
 #include "chrome/browser/ui/views/exclusive_access_bubble_views.h"
 #include "chrome/browser/ui/views/frame/browser_view_layout_delegate.h"
 #include "chrome/browser/ui/views/frame/contents_layout_manager.h"
 #include "chrome/browser/ui/views/frame/immersive_mode_controller.h"
 #include "chrome/browser/ui/views/frame/top_container_view.h"
 #include "chrome/browser/ui/views/infobars/infobar_container_view.h"
 #include "chrome/browser/ui/views/tabs/tab_strip.h"
@@ skipping 191 matching lines @@
       !immersive_mode_controller_->IsRevealed()) {
     // Position the find bar exactly below the top container. In immersive
     // fullscreen, when the top-of-window views are not revealed, only the
     // miniature immersive style tab strip is visible. Do not overlap the
     // find bar and the tab strip.
     find_bar_y = top_container_bounds.bottom();
   } else {
     // Overlap the find bar atop |top_container_|.
     // The find bar should look connected to the top container when material
     // design is not enabled.
-    find_bar_y = top_container_bounds.bottom() -
-                 GetLayoutConstant(FIND_BAR_TOOLBAR_OVERLAP);
+    const int kOverlapDip = 6;

[Peter Kasting, 2016/12/08 20:57:49]

Nit: Dip suffix optional (I don't mind it, but most of this CL omits it except
where it would be really unclear without)

[Evan Stade, 2016/12/13 01:31:17]

I guess I thought "kOverlap" was insufficiently descriptive. Changed to
kTopOverlap.

+    find_bar_y = top_container_bounds.bottom() - kOverlapDip;
   }
 
   // Grow the height of |bounding_box| by the height of any elements between
   // the top container and |contents_container_| such as the detached bookmark
   // bar and any infobars.
   int height_delta = bounding_box.y() - find_bar_y;
   bounding_box.set_y(find_bar_y);
   bounding_box.set_height(std::max(0, bounding_box.height() + height_delta));
 
   // Finally decrease the width of the bounding box by the width of
@@ skipping 298 matching lines @@
   return bottom;
 }
 
 bool BrowserViewLayout::InfobarVisible() const {
   // Cast to a views::View to access GetPreferredSize().
   views::View* infobar_container = infobar_container_;
   // NOTE: Can't check if the size IsEmpty() since it's always 0-width.
   return browser_->SupportsWindowFeature(Browser::FEATURE_INFOBAR) &&
       (infobar_container->GetPreferredSize().height() != 0);
 }