chrome/browser/ui/views/frame/browser_view_unittest.cc - Issue 2555623002: Last round of cleaning up MD layout constants.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/frame/browser_view_unittest.cc

Issue 2555623002: Last round of cleaning up MD layout constants. (Closed)

Patch Set: pkasting review, remove debug code, rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/ui/views/frame/browser_view_layout.cc ('k') | chrome/browser/ui/views/frame/glass_browser_frame_view.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/views/frame/browser_view.h"	5 #include "chrome/browser/ui/views/frame/browser_view.h"

6	6

7 #include "base/macros.h"	7 #include "base/macros.h"

8 #include "chrome/app/chrome_command_ids.h"	8 #include "chrome/app/chrome_command_ids.h"

9 #include "chrome/browser/ui/browser_commands.h"	9 #include "chrome/browser/ui/browser_commands.h"

10 #include "chrome/browser/ui/layout_constants.h"

11 #include "chrome/browser/ui/views/bookmarks/bookmark_bar_view.h"	10 #include "chrome/browser/ui/views/bookmarks/bookmark_bar_view.h"

12 #include "chrome/browser/ui/views/frame/browser_view_layout.h"	11 #include "chrome/browser/ui/views/frame/browser_view_layout.h"

13 #include "chrome/browser/ui/views/frame/test_with_browser_view.h"	12 #include "chrome/browser/ui/views/frame/test_with_browser_view.h"

14 #include "chrome/browser/ui/views/frame/top_container_view.h"	13 #include "chrome/browser/ui/views/frame/top_container_view.h"

15 #include "chrome/browser/ui/views/infobars/infobar_container_view.h"	14 #include "chrome/browser/ui/views/infobars/infobar_container_view.h"

16 #include "chrome/browser/ui/views/tabs/tab_strip.h"	15 #include "chrome/browser/ui/views/tabs/tab_strip.h"

17 #include "chrome/browser/ui/views/toolbar/toolbar_view.h"	16 #include "chrome/browser/ui/views/toolbar/toolbar_view.h"

18 #include "chrome/common/url_constants.h"	17 #include "chrome/common/url_constants.h"

19 #include "ui/base/accelerators/accelerator.h"	18 #include "ui/base/accelerators/accelerator.h"

20 #include "ui/views/controls/webview/webview.h"	19 #include "ui/views/controls/webview/webview.h"

(...skipping 200 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
221 header_offset.y();	220 header_offset.y();

222	221

223 // The web contents should be flush with the bottom of the header.	222 // The web contents should be flush with the bottom of the header.

224 EXPECT_EQ(bottom_of_header, contents_container->y());	223 EXPECT_EQ(bottom_of_header, contents_container->y());

225	224

226 // The find bar should overlap the 1px header/web-contents separator at the	225 // The find bar should overlap the 1px header/web-contents separator at the

227 // bottom of the header.	226 // bottom of the header.

228 EXPECT_LT(browser_view()->GetFindBarBoundingBox().y(),	227 EXPECT_LT(browser_view()->GetFindBarBoundingBox().y(),

229 browser_view()->frame()->GetTopInset(false));	228 browser_view()->frame()->GetTopInset(false));

230 }	229 }

OLD	NEW