Last round of cleaning up MD layout constants.

chrome/browser/ui/views/frame/browser_non_client_frame_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_NON_CLIENT_FRAME_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_NON_CLIENT_FRAME_VIEW_H_
 
 #include "chrome/browser/profiles/profile_attributes_storage.h"
 #include "chrome/browser/ui/views/profiles/profile_indicator_icon.h"
 #include "ui/views/window/non_client_view.h"
@@ skipping 46 matching lines @@
 
   // Returns the location icon, if this frame has any.
   virtual views::View* GetLocationIconView() const;
 
   // Returns the profile switcher button, if this frame has any.
   virtual views::View* GetProfileSwitcherView() const;
 
   // Overriden from views::View.
   void VisibilityChanged(views::View* starting_from, bool is_visible) override;
 
+  // The padding on the left, right, and bottom of the avatar icon.
+  static constexpr int kAvatarIconPadding = 4;

[Peter Kasting, 2016/12/08 20:57:49]

Nit: Goes above constructor (see
http://google.github.io/styleguide/cppguide.html#Declaration_Order )

[Evan Stade, 2016/12/13 01:31:16]

thanks, for some reason my understanding stopped at "Within each section,
generally prefer grouping similar kinds of declarations together"

+
  protected:
   // Whether the frame should be painted with theming.
   // By default, tabbed browser windows are themed but popup and app windows are
   // not.
   virtual bool ShouldPaintAsThemed() const;
 
   // Compute aspects of the frame needed to paint the frame background.
   SkColor GetFrameColor(bool active) const;
   gfx::ImageSkia GetFrameImage(bool active) const;
   gfx::ImageSkia GetFrameOverlayImage(bool active) const;
@@ skipping 56 matching lines @@
 
 namespace chrome {
 
 // Provided by a browser_non_client_frame_view_factory_*.cc implementation
 BrowserNonClientFrameView* CreateBrowserNonClientFrameView(
     BrowserFrame* frame, BrowserView* browser_view);
 
 }  // namespace chrome
 
 #endif  // CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_NON_CLIENT_FRAME_VIEW_H_