chrome/browser/ui/views/location_bar/icon_label_bubble_view_unittest.cc - Issue 2555623002: Last round of cleaning up MD layout constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/icon_label_bubble_view_unittest.cc

Issue 2555623002: Last round of cleaning up MD layout constants. (Closed)

Patch Set: pkasting review, remove debug code, rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc ('k') | chrome/browser/ui/views/location_bar/keyword_hint_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/icon_label_bubble_view_unittest.cc

diff --git a/chrome/browser/ui/views/location_bar/icon_label_bubble_view_unittest.cc b/chrome/browser/ui/views/location_bar/icon_label_bubble_view_unittest.cc

index 74e0664a2ce2a4fde77d168cfb2f63cfd98e9bd3..28f3efe0645baeefaad69eb061d8859dc4144c00 100644

--- a/chrome/browser/ui/views/location_bar/icon_label_bubble_view_unittest.cc

+++ b/chrome/browser/ui/views/location_bar/icon_label_bubble_view_unittest.cc

@@ -5,7 +5,7 @@

#include "chrome/browser/ui/views/location_bar/icon_label_bubble_view.h"

#include "base/strings/utf_string_conversions.h"

-#include "chrome/browser/ui/layout_constants.h"

+#include "chrome/browser/ui/views/location_bar/location_bar_view.h"

#include "testing/gtest/include/gtest/gtest.h"

#include "ui/views/controls/image_view.h"

#include "ui/views/test/views_test_base.h"

@@ -65,7 +65,7 @@ class TestIconLabelBubbleView : public IconLabelBubbleView {

bool ShouldShowLabel() const override {

return !IsShrinking() ||

(width() > (image()->GetPreferredSize().width() +

- 2 * GetLayoutConstant(LOCATION_BAR_HORIZONTAL_PADDING)));

+ 2 * LocationBarView::kHorizontalPadding));

}

double WidthMultiplier() const override {