Implement color management for ImageData

Implement color management for ImageData

Implement color management for ImageData as described in this proposal:
github.com/junov/CanvasColorSpace/blob/master/CanvasColorSpaceProposal.md

Intent to implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/qu73qpdGunE

BUG=670712
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2555213002
Cr-Original-Commit-Position: refs/heads/master@{#442973}
Committed: https://chromium.googlesource.com/chromium/src/+/7fb9535883e50ab0d7262ea8a0e8470934e57a9c
Review-Url: https://codereview.chromium.org/2555213002
Cr-Commit-Position: refs/heads/master@{#443939}
Committed: https://chromium.googlesource.com/chromium/src/+/96126d2114d57d2bea3a6de79214e22d92fd444a

[zakerinasab, 2016-12-07 20:32:23]

Description was changed from

==========
Implement color management for ImageData

Implement color management for ImageData as described in this proposal:
github.com/junov/CanvasColorSpace/blob/master/CanvasColorSpaceProposal.md

BUG=670712
==========

to

==========
Implement color management for ImageData

Implement color management for ImageData as described in this proposal:
github.com/junov/CanvasColorSpace/blob/master/CanvasColorSpaceProposal.md

BUG=670712
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[zakerinasab, 2016-12-08 16:18:23]

Description was changed from

==========
Implement color management for ImageData

Implement color management for ImageData as described in this proposal:
github.com/junov/CanvasColorSpace/blob/master/CanvasColorSpaceProposal.md

BUG=670712
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Implement color management for ImageData

Implement color management for ImageData as described in this proposal:
github.com/junov/CanvasColorSpace/blob/master/CanvasColorSpaceProposal.md

BUG=670712
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[zakerinasab, 2016-12-08 16:18:23]

zakerinasab@chromium.org changed reviewers:
+ junov@chromium.org

[Justin Novosad, 2016-12-08 18:16:35]

CL is missing tests. It needs lot of tests.

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp
(right):

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp:14:
#include "bindings/core/v8/V8Float32ImageData.h"
Why is this needed?

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.cpp
(right):

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.cpp:12:
#include "bindings/core/v8/V8Float32ImageData.h"
Why is this needed?

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp
(right):

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp:16:
#include "bindings/core/v8/V8Float32ImageData.h"
Why is this needed?

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/Float32ImageData.cpp (right):

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/Float32ImageData.cpp:42:
CheckedNumeric<unsigned> dataSize = 8;
This should be 16.  Even better, write it as 4*sizeof(float)
You would have caught this is you had rigorous testing.

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/Float32ImageData.cpp:80:
CheckedNumeric<unsigned> dataSize = 8;
oops

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/Float32ImageData.cpp:113:
CheckedNumeric<unsigned> dataSize = 8;
oops

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/Float32ImageData.cpp:214: "The input data
byte length is not equal to (8 * width * height).");
16

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/Float32ImageData.cpp:236: "The input data
byte length is not equal to (8 * width * height).");
16

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/Float32ImageData.h (right):

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/Float32ImageData.h:35: #include
"core/html/ImageData.h"
Why is this needed?

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/Float32ImageData.h:115: String m_colorSpace;
You should not store this as a string. Use an enum, and define an attribute
getter that converts to a string.

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/Float32ImageData.idl (right):

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/Float32ImageData.idl:35:
RaisesException=Constructor,
This is an experimental feature, so the interface should be hidden behind a
runtime flag.

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/Float32ImageData.idl:39: readonly attribute
Float32Array data;
this should not be readonly

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp (right):

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp:45: #include
"core/html/Float32ImageData.h"
Why is this needed?

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLCanvasElement.h (right):

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLCanvasElement.h:61: class
Float32ImageData;
Why is this needed?

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/ImageData.h (right):

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/ImageData.h:121: String m_colorSpace;
You should store this as an enum, and use an attribute getter that serializes to
a string.

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/ImageData.idl (right):

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/ImageData.idl:32: //    Constructor(unsigned
long sw, unsigned long sh),
Remove this comment block

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/ImageData.idl:52: readonly attribute
Uint8ClampedArray data;
This should not be read-only

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h
(right):

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h:45: class
Float32ImageData;
Why is this needed?

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp
(right):

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp:96: return
value.getAsFloat32ImageData();
should have a DCHECK on the runtim flag that exposes Float32ImageData

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp
(right):

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp:13:
#include "core/html/Float32ImageData.h"
Why?

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
(right):

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp:10:
#include "core/html/Float32ImageData.h"
Why?

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
(right):

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp:41:
#include "core/html/Float32ImageData.h"
Why?

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h
(right):

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h:72: class
Float32ImageData;
Why?

[zakerinasab, 2016-12-08 20:40:52]

Comments addressed. Working on layout tests now.

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp
(right):

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp:14:
#include "bindings/core/v8/V8Float32ImageData.h"
On 2016/12/08 18:16:34, Justin Novosad wrote:
> Why is this needed?

Can be removed for now as we have not covered serialization yet. When we do it
will be needed.

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.cpp
(right):

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.cpp:12:
#include "bindings/core/v8/V8Float32ImageData.h"
On 2016/12/08 18:16:34, Justin Novosad wrote:
> Why is this needed?

Removed. Must be added later for serialization.

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp
(right):

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp:16:
#include "bindings/core/v8/V8Float32ImageData.h"
On 2016/12/08 18:16:34, Justin Novosad wrote:
> Why is this needed?

Removed.

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/Float32ImageData.cpp (right):

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/Float32ImageData.cpp:42:
CheckedNumeric<unsigned> dataSize = 8;
On 2016/12/08 18:16:34, Justin Novosad wrote:
> This should be 16.  Even better, write it as 4*sizeof(float)
> You would have caught this is you had rigorous testing.

No, it should be 4 as RGBA has four elements. Fixed now.

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/Float32ImageData.cpp:80:
CheckedNumeric<unsigned> dataSize = 8;
On 2016/12/08 18:16:34, Justin Novosad wrote:
> oops

No, it should be 4 as RGBA has four elements. Fixed now.

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/Float32ImageData.cpp:113:
CheckedNumeric<unsigned> dataSize = 8;
On 2016/12/08 18:16:34, Justin Novosad wrote:
> oops

No, it should be 4 as RGBA has four elements. Fixed now.

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/Float32ImageData.cpp:214: "The input data
byte length is not equal to (8 * width * height).");
On 2016/12/08 18:16:34, Justin Novosad wrote:
> 16

No, it should be 4 as RGBA has four elements. Fixed now.

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/Float32ImageData.cpp:236: "The input data
byte length is not equal to (8 * width * height).");
On 2016/12/08 18:16:34, Justin Novosad wrote:
> 16

No, it should be 4 as RGBA has four elements. Fixed now.

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/Float32ImageData.h (right):

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/Float32ImageData.h:35: #include
"core/html/ImageData.h"
On 2016/12/08 18:16:34, Justin Novosad wrote:
> Why is this needed?

To have access to ImageDataColorSpace enum and strings.

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/Float32ImageData.h:115: String m_colorSpace;
On 2016/12/08 18:16:35, Justin Novosad wrote:
> You should not store this as a string. Use an enum, and define an attribute
> getter that converts to a string.

This is an older version. Fixed now.

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/Float32ImageData.idl (right):

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/Float32ImageData.idl:35:
RaisesException=Constructor,
On 2016/12/08 18:16:35, Justin Novosad wrote:
> This is an experimental feature, so the interface should be hidden behind a
> runtime flag.

Done.

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/Float32ImageData.idl:39: readonly attribute
Float32Array data;
On 2016/12/08 18:16:35, Justin Novosad wrote:
> this should not be readonly

Resolved.

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp (right):

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp:45: #include
"core/html/Float32ImageData.h"
On 2016/12/08 18:16:35, Justin Novosad wrote:
> Why is this needed?

Removed for now.

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLCanvasElement.h (right):

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLCanvasElement.h:61: class
Float32ImageData;
On 2016/12/08 18:16:35, Justin Novosad wrote:
> Why is this needed?

Removed for now.

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/ImageData.h (right):

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/ImageData.h:121: String m_colorSpace;
On 2016/12/08 18:16:35, Justin Novosad wrote:
> You should store this as an enum, and use an attribute getter that serializes
to
> a string.

Fixed.

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/ImageData.idl (right):

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/ImageData.idl:32: //    Constructor(unsigned
long sw, unsigned long sh),
On 2016/12/08 18:16:35, Justin Novosad wrote:
> Remove this comment block

Done.

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/ImageData.idl:52: readonly attribute
Uint8ClampedArray data;
On 2016/12/08 18:16:35, Justin Novosad wrote:
> This should not be read-only

Resolved. Remains readonly.

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h
(right):

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h:45: class
Float32ImageData;
On 2016/12/08 18:16:35, Justin Novosad wrote:
> Why is this needed?

Removed for now.

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp
(right):

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp:96: return
value.getAsFloat32ImageData();
On 2016/12/08 18:16:35, Justin Novosad wrote:
> should have a DCHECK on the runtim flag that exposes Float32ImageData

Done.

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp
(right):

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp:13:
#include "core/html/Float32ImageData.h"
On 2016/12/08 18:16:35, Justin Novosad wrote:
> Why?

Removed for now.

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
(right):

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp:10:
#include "core/html/Float32ImageData.h"
On 2016/12/08 18:16:35, Justin Novosad wrote:
> Why?

Removed for now.

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
(right):

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp:41:
#include "core/html/Float32ImageData.h"
On 2016/12/08 18:16:35, Justin Novosad wrote:
> Why?

Removed for now.

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h
(right):

https://codereview.chromium.org/2555213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h:72: class
Float32ImageData;
On 2016/12/08 18:16:35, Justin Novosad wrote:
> Why?

Removed for now.

[Justin Novosad, 2016-12-08 20:58:59]

https://codereview.chromium.org/2555213002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/ImageData.cpp (right):

https://codereview.chromium.org/2555213002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/ImageData.cpp:127:
exceptionState.throwDOMException(V8Error,
this should be V8RangeError

https://codereview.chromium.org/2555213002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/ImageData.idl (right):

https://codereview.chromium.org/2555213002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/ImageData.idl:34: Constructor(unsigned long
sw, unsigned long sh, optional ImageDataColorSpace colorSpace = "legacy-srgb"),
We need to hide this behind a flag.  To do this, instead of using 'optional' you
should create an overload of the constructor that takes a mandatory colorspace
argument, and hide that behind the runtime flag.

https://codereview.chromium.org/2555213002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/ImageData.idl:35:
Constructor(Uint8ClampedArray data, unsigned long sw, optional unsigned long sh,
optional ImageDataColorSpace colorSpace),
same here.

https://codereview.chromium.org/2555213002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp
(right):

https://codereview.chromium.org/2555213002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp:97: if
(value.isFloat32ImageData())
Would be useful to give helpful guidance to devs trying out this feature.  If a
Float32ImageData was passed, but neither trueColor or colorCorrect are enabled,
we should throw an exception with a message that tells the dev what to do to
make things work.

[zakerinasab, 2016-12-08 22:13:52]

New patch submitted to address the comments.

https://codereview.chromium.org/2555213002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/ImageData.cpp (right):

https://codereview.chromium.org/2555213002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/ImageData.cpp:127:
exceptionState.throwDOMException(V8Error,
On 2016/12/08 20:58:59, Justin Novosad wrote:
> this should be V8RangeError

Fixed for this and similar occurrences.

https://codereview.chromium.org/2555213002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/ImageData.idl (right):

https://codereview.chromium.org/2555213002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/ImageData.idl:34: Constructor(unsigned long
sw, unsigned long sh, optional ImageDataColorSpace colorSpace = "legacy-srgb"),
On 2016/12/08 20:58:59, Justin Novosad wrote:
> We need to hide this behind a flag.  To do this, instead of using 'optional'
you
> should create an overload of the constructor that takes a mandatory colorspace
> argument, and hide that behind the runtime flag.

Done.

https://codereview.chromium.org/2555213002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/ImageData.idl:35:
Constructor(Uint8ClampedArray data, unsigned long sw, optional unsigned long sh,
optional ImageDataColorSpace colorSpace),
On 2016/12/08 20:58:59, Justin Novosad wrote:
> same here.

Done.

https://codereview.chromium.org/2555213002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp
(right):

https://codereview.chromium.org/2555213002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp:97: if
(value.isFloat32ImageData())
On 2016/12/08 20:58:59, Justin Novosad wrote:
> Would be useful to give helpful guidance to devs trying out this feature.  If
a
> Float32ImageData was passed, but neither trueColor or colorCorrect are
enabled,
> we should throw an exception with a message that tells the dev what to do to
> make things work.

Done.

[Justin Novosad, 2016-12-09 19:45:12]

The CQ bit was checked by junov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 19:46:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 20:04:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 20:04:28]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[zakerinasab, 2016-12-15 23:14:26]

Patchset #7 (id:120001) has been deleted

[zakerinasab, 2016-12-15 23:14:36]

Patchset #6 (id:100001) has been deleted

[zakerinasab, 2016-12-15 23:14:49]

Patchset #1 (id:1) has been deleted

[zakerinasab, 2016-12-15 23:14:59]

Patchset #1 (id:20001) has been deleted

[zakerinasab, 2016-12-15 23:15:07]

Patchset #1 (id:40001) has been deleted

[zakerinasab1, 2016-12-16 16:43:57]

zakerinasab@google.com changed reviewers:
+ jochen@chromium.org

[zakerinasab1, 2016-12-16 16:46:14]

zakerinasab@google.com changed reviewers:
+ zakerinasab@google.com

[zakerinasab1, 2016-12-16 16:46:15]

New patch submitted. PTAL.

jochen@ for bindings/core/v8/BUILD.gn
junov@ for everything else.

Thanks.

[zakerinasab1, 2016-12-16 17:08:39]

Patchset #6 (id:200001) has been deleted

[zakerinasab1, 2016-12-16 17:08:45]

Patchset #5 (id:180001) has been deleted

[Justin Novosad, 2016-12-16 18:38:11]

https://codereview.chromium.org/2555213002/diff/220001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/fast/canvas/color-space/float32ImageData-colorSpace.html
(right):

https://codereview.chromium.org/2555213002/diff/220001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/canvas/color-space/float32ImageData-colorSpace.html:12:
assert_equals((new Float32ImageData(1, 1)).colorSpace, "linear-rgb");
Each of these assertions is checking a specific behavior. In this case you
should specify a description for each one (optional 3rd argument).

https://codereview.chromium.org/2555213002/diff/220001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/fast/canvas/color-space/imageData-colorSpace.html
(right):

https://codereview.chromium.org/2555213002/diff/220001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/canvas/color-space/imageData-colorSpace.html:29:
assert_equals((new ImageData(1,1)).colorSpace, "legacy-srgb");
Please add descriptions.

https://codereview.chromium.org/2555213002/diff/220001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/html/Float32ImageData.cpp (right):

https://codereview.chromium.org/2555213002/diff/220001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/html/Float32ImageData.cpp:173: "The source data
has been neutered.");
We now prefer the term "detached" instead of neutered.

https://codereview.chromium.org/2555213002/diff/220001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/html/ImageData.h (right):

https://codereview.chromium.org/2555213002/diff/220001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/html/ImageData.h:171: bool
ImageData::validateConstructorArguments(const unsigned& paramFlags,
Would be more efficient not to write this method as a tmplate.  You could just
use DOMArrayBufferView* as the type for the data argument.  This is a common
base class for Uint8ClampedArray as well as Floate32Array, and it provides the
API necessary for doing the check you need to do here.  Then you can move this
function definition to the cpp file.

https://codereview.chromium.org/2555213002/diff/220001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/html/ImageData.idl (right):

https://codereview.chromium.org/2555213002/diff/220001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/html/ImageData.idl:47: readonly attribute
Uint8ClampedArray data;
Do you understand how this worked before, without the data attribute?

https://codereview.chromium.org/2555213002/diff/220001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/html/ImageData.idl:51: 
remove whitespace

https://codereview.chromium.org/2555213002/diff/220001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp
(right):

https://codereview.chromium.org/2555213002/diff/220001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp:102:
exceptionState.throwDOMException(
This should never be reached since the creation of Float32ImageData is guarded
by exparimental flags.  So you should just call NOTREACHED() instead of
throwing.

https://codereview.chromium.org/2555213002/diff/220001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.idl
(right):

https://codereview.chromium.org/2555213002/diff/220001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.idl:38:
Float32ImageData or
I don't see any tests for using Float32ImageData as an ImageBitmap source.  This
CL is already very big. I recomment you should revert this file and save it for
a future CL. Also remove ImageBitmapSource from the list of base classes of
Float32ImageData, as well as the ImageBitmapSource method implementations in
Float32ImageData.  Save that for a follow-up patch.

[jochen (gone - plz use gerrit), 2016-12-19 12:02:27]

can you please point to the "intent to implement" thread? (link it from the CL
description)

bindings lgtm

[zakerinasab1, 2016-12-19 19:56:45]

Patchset #6 (id:240001) has been deleted

[zakerinasab1, 2016-12-19 19:57:39]

New patch submitted addressing junov@ comments and adding the functionality
layout tests for Float32ImageData.

https://codereview.chromium.org/2555213002/diff/220001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/fast/canvas/color-space/float32ImageData-colorSpace.html
(right):

https://codereview.chromium.org/2555213002/diff/220001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/canvas/color-space/float32ImageData-colorSpace.html:12:
assert_equals((new Float32ImageData(1, 1)).colorSpace, "linear-rgb");
On 2016/12/16 18:38:11, Justin Novosad wrote:
> Each of these assertions is checking a specific behavior. In this case you
> should specify a description for each one (optional 3rd argument).

Done.

https://codereview.chromium.org/2555213002/diff/220001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/fast/canvas/color-space/imageData-colorSpace.html
(right):

https://codereview.chromium.org/2555213002/diff/220001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/canvas/color-space/imageData-colorSpace.html:29:
assert_equals((new ImageData(1,1)).colorSpace, "legacy-srgb");
On 2016/12/16 18:38:11, Justin Novosad wrote:
> Please add descriptions.

Done.

https://codereview.chromium.org/2555213002/diff/220001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/html/Float32ImageData.cpp (right):

https://codereview.chromium.org/2555213002/diff/220001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/html/Float32ImageData.cpp:173: "The source data
has been neutered.");
On 2016/12/16 18:38:11, Justin Novosad wrote:
> We now prefer the term "detached" instead of neutered.

Done.

https://codereview.chromium.org/2555213002/diff/220001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/html/ImageData.h (right):

https://codereview.chromium.org/2555213002/diff/220001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/html/ImageData.h:171: bool
ImageData::validateConstructorArguments(const unsigned& paramFlags,
On 2016/12/16 18:38:11, Justin Novosad wrote:
> Would be more efficient not to write this method as a tmplate.  You could just
> use DOMArrayBufferView* as the type for the data argument.  This is a common
> base class for Uint8ClampedArray as well as Floate32Array, and it provides the
> API necessary for doing the check you need to do here.  Then you can move this
> function definition to the cpp file.

Done.

https://codereview.chromium.org/2555213002/diff/220001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/html/ImageData.idl (right):

https://codereview.chromium.org/2555213002/diff/220001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/html/ImageData.idl:47: readonly attribute
Uint8ClampedArray data;
On 2016/12/16 18:38:11, Justin Novosad wrote:
> Do you understand how this worked before, without the data attribute?

Not yet. I've asked foolip about this but he couldn't remember too. I'll try to
find out how this was working when preparing the usage layout test for
Float32ImageData.

https://codereview.chromium.org/2555213002/diff/220001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/html/ImageData.idl:51: 
On 2016/12/16 18:38:11, Justin Novosad wrote:
> remove whitespace

Done.

https://codereview.chromium.org/2555213002/diff/220001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp
(right):

https://codereview.chromium.org/2555213002/diff/220001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp:102:
exceptionState.throwDOMException(
On 2016/12/16 18:38:11, Justin Novosad wrote:
> This should never be reached since the creation of Float32ImageData is guarded
> by exparimental flags.  So you should just call NOTREACHED() instead of
> throwing.

Done.

https://codereview.chromium.org/2555213002/diff/220001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.idl
(right):

https://codereview.chromium.org/2555213002/diff/220001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.idl:38:
Float32ImageData or
On 2016/12/16 18:38:11, Justin Novosad wrote:
> I don't see any tests for using Float32ImageData as an ImageBitmap source. 
This
> CL is already very big. I recomment you should revert this file and save it
for
> a future CL. Also remove ImageBitmapSource from the list of base classes of
> Float32ImageData, as well as the ImageBitmapSource method implementations in
> Float32ImageData.  Save that for a follow-up patch.

Done.

[Justin Novosad, 2016-12-20 17:50:02]

lgtm

[zakerinasab1, 2016-12-21 16:14:08]

Patchset #7 (id:280001) has been deleted

[zakerinasab1, 2016-12-21 17:03:11]

Patchset #8 (id:320001) has been deleted

[zakerinasab1, 2016-12-21 17:03:18]

Patchset #7 (id:300001) has been deleted

[zakerinasab1, 2016-12-21 18:27:02]

Patchset #7 (id:340001) has been deleted

[zakerinasab1, 2016-12-21 19:28:52]

The CQ bit was checked by zakerinasab@google.com

[zakerinasab1, 2016-12-21 19:28:52]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
junov@chromium.org
Link to the patchset: https://codereview.chromium.org/2555213002/#ps360001
(title: "Rebaselining layout tests")

[commit-bot: I haz the power, 2016-12-21 19:29:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 00:12:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 00:12:09]

Try jobs failed on following builders:
  win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)

[zakerinasab1, 2016-12-22 15:20:31]

The CQ bit was unchecked by zakerinasab@google.com

[zakerinasab1, 2016-12-22 15:49:44]

The CQ bit was checked by zakerinasab@google.com

[zakerinasab1, 2016-12-22 15:49:45]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
junov@chromium.org
Link to the patchset: https://codereview.chromium.org/2555213002/#ps380001
(title: "Rebaseline")

[commit-bot: I haz the power, 2016-12-22 15:50:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2016-12-22 16:02:30]

The CQ bit was unchecked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-12-22 16:03:31]

I cancelled commit as the CL description still doesn't include the "intent to
implement" link, see http://dev.chromium.org/blink/launching-features for
instructions

[zakerinasab1, 2017-01-09 19:34:30]

zakerinasab@google.com changed reviewers:
- zakerinasab@google.com

[zakerinasab1, 2017-01-10 19:39:47]

Description was changed from

==========
Implement color management for ImageData

Implement color management for ImageData as described in this proposal:
github.com/junov/CanvasColorSpace/blob/master/CanvasColorSpaceProposal.md

BUG=670712
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Implement color management for ImageData

Implement color management for ImageData as described in this proposal:
github.com/junov/CanvasColorSpace/blob/master/CanvasColorSpaceProposal.md

Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/qu73qpdGunE

BUG=670712
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[zakerinasab1, 2017-01-10 19:43:22]

The CQ bit was checked by zakerinasab@google.com

[zakerinasab1, 2017-01-10 19:43:23]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
junov@chromium.org
Link to the patchset: https://codereview.chromium.org/2555213002/#ps420001
(title: "Rebaseline")

[commit-bot: I haz the power, 2017-01-10 19:44:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 21:34:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 21:34:32]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[zakerinasab1, 2017-01-11 17:18:27]

The CQ bit was checked by zakerinasab@google.com

[zakerinasab1, 2017-01-11 17:18:27]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
junov@chromium.org
Link to the patchset: https://codereview.chromium.org/2555213002/#ps440001
(title: "Rebaselining layout tests")

[commit-bot: I haz the power, 2017-01-11 17:18:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 19:09:18]

CQ is committing da patch.

Bot data: {"patchset_id": 440001, "attempt_start_ts": 1484155107278450,
"parent_rev": "1ff21f95261daa80eeff96b7df798da9b85b5eee", "commit_rev":
"7fb9535883e50ab0d7262ea8a0e8470934e57a9c"}

[commit-bot: I haz the power, 2017-01-11 19:09:47]

Description was changed from

==========
Implement color management for ImageData

Implement color management for ImageData as described in this proposal:
github.com/junov/CanvasColorSpace/blob/master/CanvasColorSpaceProposal.md

Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/qu73qpdGunE

BUG=670712
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Implement color management for ImageData

Implement color management for ImageData as described in this proposal:
github.com/junov/CanvasColorSpace/blob/master/CanvasColorSpaceProposal.md

Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/qu73qpdGunE

BUG=670712
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2555213002
Cr-Commit-Position: refs/heads/master@{#442973}
Committed:
https://chromium.googlesource.com/chromium/src/+/7fb9535883e50ab0d7262ea8a0e8...
==========

[commit-bot: I haz the power, 2017-01-11 19:09:48]

Committed patchset #11 (id:440001) as
https://chromium.googlesource.com/chromium/src/+/7fb9535883e50ab0d7262ea8a0e8...

[sullivan, 2017-01-13 14:04:27]

A revert of this CL (patchset #11 id:440001) has been created in
https://codereview.chromium.org/2636533002/ by sullivan@chromium.org.

The reason for reverting is: This caused Windows test failures on the perf
waterfall. See http://crbug.com/680776.

[sullivan, 2017-01-13 14:19:44]

On 2017/01/13 14:04:27, sullivan wrote:
> A revert of this CL (patchset #11 id:440001) has been created in
> https://codereview.chromium.org/2636533002/ by mailto:sullivan@chromium.org.
> 
> The reason for reverting is: This caused Windows test failures on the perf
> waterfall. See http://crbug.com/680776.

This patch won't revert cleanly. Please look into crbug.com/680776 ASAP

[esprehn, 2017-01-13 22:39:10]

esprehn@chromium.org changed reviewers:
+ esprehn@chromium.org

[esprehn, 2017-01-13 22:39:11]

https://codereview.chromium.org/2555213002/diff/440001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/html/Float32ImageData.cpp (right):

https://codereview.chromium.org/2555213002/diff/440001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/html/Float32ImageData.cpp:2: * Copyright (C) 2016
Google Inc. All rights reserved.
Please use the short 4 line copyright for all new files.

[zakerinasab1, 2017-01-16 15:51:59]

Description was changed from

==========
Implement color management for ImageData

Implement color management for ImageData as described in this proposal:
github.com/junov/CanvasColorSpace/blob/master/CanvasColorSpaceProposal.md

Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/qu73qpdGunE

BUG=670712
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2555213002
Cr-Commit-Position: refs/heads/master@{#442973}
Committed:
https://chromium.googlesource.com/chromium/src/+/7fb9535883e50ab0d7262ea8a0e8...
==========

to

==========
Implement color management for ImageData

Implement color management for ImageData as described in this proposal:
github.com/junov/CanvasColorSpace/blob/master/CanvasColorSpaceProposal.md

Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/qu73qpdGunE

BUG=670712
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2555213002
Cr-Commit-Position: refs/heads/master@{#442973}
Committed:
https://chromium.googlesource.com/chromium/src/+/7fb9535883e50ab0d7262ea8a0e8...
==========

[zakerinasab1, 2017-01-16 15:58:34]

Patchset #12 (id:460001) has been deleted

[Justin Novosad, 2017-01-16 16:29:49]

patch 12 lgtm

[zakerinasab1, 2017-01-16 17:04:35]

Patchset #14 (id:520001) has been deleted

[zakerinasab1, 2017-01-16 17:14:36]

Patchset #13 (id:500001) has been deleted

[zakerinasab1, 2017-01-16 19:22:06]

The CQ bit was checked by zakerinasab@google.com

[zakerinasab1, 2017-01-16 19:22:07]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
junov@chromium.org
Link to the patchset: https://codereview.chromium.org/2555213002/#ps540001
(title: "Fixing ImageData::validateConstructorArguments")

[commit-bot: I haz the power, 2017-01-16 19:22:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 20:24:14]

CQ is committing da patch.

Bot data: {"patchset_id": 540001, "attempt_start_ts": 1484594526483960,
"parent_rev": "f803c032acae563628c615e6aa2472c0e18f9151", "commit_rev":
"96126d2114d57d2bea3a6de79214e22d92fd444a"}

[commit-bot: I haz the power, 2017-01-16 20:24:41]

Description was changed from

==========
Implement color management for ImageData

Implement color management for ImageData as described in this proposal:
github.com/junov/CanvasColorSpace/blob/master/CanvasColorSpaceProposal.md

Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/qu73qpdGunE

BUG=670712
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2555213002
Cr-Commit-Position: refs/heads/master@{#442973}
Committed:
https://chromium.googlesource.com/chromium/src/+/7fb9535883e50ab0d7262ea8a0e8...
==========

to

==========
Implement color management for ImageData

Implement color management for ImageData as described in this proposal:
github.com/junov/CanvasColorSpace/blob/master/CanvasColorSpaceProposal.md

Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/qu73qpdGunE

BUG=670712
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2555213002
Cr-Original-Commit-Position: refs/heads/master@{#442973}
Committed:
https://chromium.googlesource.com/chromium/src/+/7fb9535883e50ab0d7262ea8a0e8...
Review-Url: https://codereview.chromium.org/2555213002
Cr-Commit-Position: refs/heads/master@{#443939}
Committed:
https://chromium.googlesource.com/chromium/src/+/96126d2114d57d2bea3a6de79214...
==========

[commit-bot: I haz the power, 2017-01-16 20:24:42]

Committed patchset #13 (id:540001) as
https://chromium.googlesource.com/chromium/src/+/96126d2114d57d2bea3a6de79214...