Implement color management for ImageData

third_party/WebKit/Source/core/html/ImageData.h

 /*
  * Copyright (C) 2008, 2009 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 19 matching lines @@
 #define ImageData_h
 
 #include "bindings/core/v8/ScriptWrappable.h"
 #include "core/CoreExport.h"
 #include "core/dom/DOMTypedArray.h"
 #include "core/imagebitmap/ImageBitmapSource.h"
 #include "platform/geometry/IntRect.h"
 #include "platform/geometry/IntSize.h"
 #include "platform/heap/Handle.h"
 #include "wtf/Compiler.h"
+#include "wtf/text/WTFString.h"
 
 namespace blink {
 
 class ExceptionState;
 class ImageBitmapOptions;
 
+enum ImageDataColorSpace {
+  kLegacyImageDataColorSpace,
+  kSRGBImageDataColorSpace,
+  kLinearRGBImageDataColorSpace,
+};
+
+const char* const kLegacyImageDataColorSpaceName = "linear-rgb";
+const char* const kSRGBImageDataColorSpaceName = "srgb";
+const char* const kLinearRGBImageDataColorSpaceName = "legacy-srgb";
+
 class CORE_EXPORT ImageData final : public GarbageCollectedFinalized<ImageData>,
                                     public ScriptWrappable,
                                     public ImageBitmapSource {
   DEFINE_WRAPPERTYPEINFO();
 
  public:
   static ImageData* create(const IntSize&);
   static ImageData* create(const IntSize&, DOMUint8ClampedArray*);
   static ImageData* create(unsigned width, unsigned height, ExceptionState&);
+  static ImageData* create(unsigned width,
+                           unsigned height,
+                           String colorSpace,
+                           ExceptionState&);
   static ImageData* create(DOMUint8ClampedArray*,
                            unsigned width,
                            ExceptionState&);
   static ImageData* create(DOMUint8ClampedArray*,
                            unsigned width,
                            unsigned height,
                            ExceptionState&);
+  static ImageData* create(DOMUint8ClampedArray*,
+                           unsigned width,
+                           unsigned height,
+                           String colorSpace,
+                           ExceptionState&);
 
   IntSize size() const { return m_size; }
   int width() const { return m_size.width(); }
   int height() const { return m_size.height(); }
+  String colorSpace() const { return m_colorSpace; }
   const DOMUint8ClampedArray* data() const { return m_data.get(); }
   DOMUint8ClampedArray* data() { return m_data.get(); }
 
   // ImageBitmapSource implementation
   IntSize bitmapSourceSize() const override { return m_size; }
   ScriptPromise createImageBitmap(ScriptState*,
                                   EventTarget&,
                                   Optional<IntRect> cropRect,
                                   const ImageBitmapOptions&,
                                   ExceptionState&) override;
 
   DEFINE_INLINE_TRACE() { visitor->trace(m_data); }
 
   WARN_UNUSED_RESULT v8::Local<v8::Object> associateWithWrapper(
       v8::Isolate*,
       const WrapperTypeInfo*,
       v8::Local<v8::Object> wrapper) override;
 
  private:
-  ImageData(const IntSize&, DOMUint8ClampedArray*);
+  ImageData(const IntSize&,
+            DOMUint8ClampedArray*,
+            String = kLegacyImageDataColorSpaceName);
 
   static bool validateConstructorArguments(DOMUint8ClampedArray*,
                                            unsigned width,
                                            unsigned&,
                                            ExceptionState&);
+  static bool validateConstructorArguments(DOMUint8ClampedArray*,
+                                           unsigned width,
+                                           unsigned&,
+                                           String,
+                                           ExceptionState&);
 
   IntSize m_size;
+  String m_colorSpace;

[Justin Novosad, 2016/12/08 18:16:35]

You should store this as an enum, and use an attribute getter that serializes to
a string.

[zakerinasab, 2016/12/08 20:40:52]

Fixed.

   Member<DOMUint8ClampedArray> m_data;
 };
 
 }  // namespace blink
 
 #endif  // ImageData_h