Implement color management for ImageData

third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp

 /*
  * Copyright (c) 2013, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 19 matching lines @@
 
 #include "core/imagebitmap/ImageBitmapFactories.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "core/dom/DOMException.h"
 #include "core/dom/ExecutionContext.h"
 #include "core/fileapi/Blob.h"
 #include "core/frame/ImageBitmap.h"
 #include "core/frame/LocalDOMWindow.h"
 #include "core/frame/UseCounter.h"
+#include "core/html/Float32ImageData.h"
 #include "core/html/HTMLCanvasElement.h"
 #include "core/html/HTMLImageElement.h"
 #include "core/html/HTMLVideoElement.h"
 #include "core/html/ImageData.h"
 #include "core/imagebitmap/ImageBitmapOptions.h"
 #include "core/offscreencanvas/OffscreenCanvas.h"
 #include "core/svg/graphics/SVGImage.h"
 #include "core/workers/WorkerGlobalScope.h"
 #include "platform/CrossThreadFunctional.h"
 #include "platform/SharedBuffer.h"
@@ skipping 35 matching lines @@
     return imageElement;
   }
   if (value.isHTMLVideoElement())
     return value.getAsHTMLVideoElement();
   if (value.isHTMLCanvasElement())
     return value.getAsHTMLCanvasElement();
   if (value.isBlob())
     return value.getAsBlob();
   if (value.isImageData())
     return value.getAsImageData();
+  if (value.isFloat32ImageData()) {
+    if (RuntimeEnabledFeatures::experimentalCanvasFeaturesEnabled() &&
+        (RuntimeEnabledFeatures::trueColorRenderingEnabled() ||
+         RuntimeEnabledFeatures::colorCorrectRenderingEnabled())) {
+      return value.getAsFloat32ImageData();
+    }
+    exceptionState.throwDOMException(

[Justin Novosad, 2016/12/16 18:38:11]

This should never be reached since the creation of Float32ImageData is guarded
by exparimental flags.  So you should just call NOTREACHED() instead of
throwing.

[zakerinasab1, 2016/12/19 19:57:39]

Done.

+        V8TypeError,
+        "Float32ImageData is still experimental. It needs one of "
+        "enable-color-correct-rendering or enable-true-color-rendering flags "
+        "besides enable-experimental-canvas-features flag to work.");
+  }
+
   if (value.isImageBitmap())
     return value.getAsImageBitmap();
   if (value.isOffscreenCanvas())
     return value.getAsOffscreenCanvas();
   ASSERT_NOT_REACHED();
   return nullptr;
 }
 
 ScriptPromise ImageBitmapFactories::createImageBitmapFromBlob(
     ScriptState* scriptState,
@@ skipping 216 matching lines @@
   }
   m_factory->didFinishLoading(this);
 }
 
 DEFINE_TRACE(ImageBitmapFactories::ImageBitmapLoader) {
   visitor->trace(m_factory);
   visitor->trace(m_resolver);
 }
 
 }  // namespace blink