Remove ash_unittests/mash_unittests from Windows build targets

Remove ash_unittests/mash_unittests from the Windows build

Ash has not shipped on Windows for years so we're removing support. A previous
CL stopped running these tests on the Windows bots.

This also removes the test build targets on Linux, but we have never shipped
ash on non-chromeos Linux, and those tests have never run on the bots.

Future CLs will clean up use_ash vs. is_win vs. is_chromeos in BUILD.gn files.

BUG=666775
TEST=bots

Committed: https://crrev.com/4c02a0b830b3ee86df411772408344a926c52a86
Cr-Commit-Position: refs/heads/master@{#436074}

[James Cook, 2016-12-01 18:19:09]

Description was changed from

==========
Remove ash_unittests/mash_unittests from Windows build targets

Ash has not shipped on Windows for years so we're removing support.

This also removes the test build targets on Linux, but we have never shipped
ash on non-chromeos Linux, so we don't need those either.

BUG=666775
TEST=bots
==========

to

==========
Remove ash_unittests/mash_unittests from the Windows build

Ash has not shipped on Windows for years so we're removing support. A previous
CL stopped running these tests on the Windows bots.

This also removes the test build targets on Linux, but we have never shipped
ash on non-chromeos Linux, and those tests have never run on the bots.

Future CLs will clean up use_ash vs. is_win vs. is_chromeos in BUILD.gn files.

BUG=666775
TEST=bots
==========

[James Cook, 2016-12-01 18:19:14]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 18:19:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-12-01 18:29:52]

jamescook@chromium.org changed reviewers:
+ sky@chromium.org

[James Cook, 2016-12-01 18:29:53]

sky, please take a look.

https://codereview.chromium.org/2549583002/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2549583002/diff/1/BUILD.gn#newcode350
BUILD.gn:350: if (use_ash) {
use_ash is currently is_chromeos && !is_chromecast

https://codereview.chromium.org/2549583002/diff/1/BUILD.gn#newcode484
BUILD.gn:484: "//components/session_manager/core",
This is just cleanup.

[sky, 2016-12-01 19:00:52]

LGTM - you might also add an ASSERT to ash/BUILD.gn that is_chromeos is true

[James Cook, 2016-12-01 19:12:12]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 19:12:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-12-01 19:13:11]

jamescook@chromium.org changed reviewers:
+ dpranke@chromium.org

[James Cook, 2016-12-01 19:13:11]

dpranke, can I get OWNERS for src/BUILD.gn ?

[commit-bot: I haz the power, 2016-12-01 19:16:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 19:16:21]

Dry run: Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/blimp_linux_dbg...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[James Cook, 2016-12-01 19:24:03]

Actually, hold off. Adding the assert reveals that I need to do more build file
surgery.

[James Cook, 2016-12-01 22:30:02]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 22:30:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 22:39:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 22:39:45]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[James Cook, 2016-12-01 23:10:37]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 23:11:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-12-01 23:16:41]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 23:17:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 00:13:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 00:13:16]

Dry run: This issue passed the CQ dry run.

[James Cook, 2016-12-02 03:32:26]

jamescook@chromium.org changed reviewers:
- dpranke@chromium.org

[James Cook, 2016-12-02 03:32:27]

sky, please take another look.

[sky, 2016-12-02 17:04:26]

https://codereview.chromium.org/2549583002/diff/80001/mash/example/BUILD.gn
File mash/example/BUILD.gn (left):

https://codereview.chromium.org/2549583002/diff/80001/mash/example/BUILD.gn#o...
mash/example/BUILD.gn:11: "//ash/mus",
The idea with this dep is if you build mash/example you would have everything
needed to run mash. So, should this dep be conditional based on chromeos?

https://codereview.chromium.org/2549583002/diff/80001/tools/determinism/deter...
File tools/determinism/deterministic_build_whitelist.pyl (right):

https://codereview.chromium.org/2549583002/diff/80001/tools/determinism/deter...
tools/determinism/deterministic_build_whitelist.pyl:179: 'ash_library.dll',
Because of the assert you added we know we're not building ash anymore on
windows at all. Should you remove this and the next line?

[James Cook, 2016-12-02 18:34:17]

Patchset #6 (id:100001) has been deleted

[James Cook, 2016-12-02 18:38:40]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[James Cook, 2016-12-02 18:38:55]

sky, please take another look.

https://codereview.chromium.org/2549583002/diff/80001/mash/example/BUILD.gn
File mash/example/BUILD.gn (left):

https://codereview.chromium.org/2549583002/diff/80001/mash/example/BUILD.gn#o...
mash/example/BUILD.gn:11: "//ash/mus",
On 2016/12/02 17:04:26, sky wrote:
> The idea with this dep is if you build mash/example you would have everything
> needed to run mash. So, should this dep be conditional based on chromeos?

Done. Should I also add a dep on simple_wm for Windows?

https://codereview.chromium.org/2549583002/diff/80001/tools/determinism/deter...
File tools/determinism/deterministic_build_whitelist.pyl (right):

https://codereview.chromium.org/2549583002/diff/80001/tools/determinism/deter...
tools/determinism/deterministic_build_whitelist.pyl:179: 'ash_library.dll',
On 2016/12/02 17:04:26, sky wrote:
> Because of the assert you added we know we're not building ash anymore on
> windows at all. Should you remove this and the next line?

Doh! Good catch. Done.

[commit-bot: I haz the power, 2016-12-02 18:39:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2016-12-02 18:57:06]

LGTM

https://codereview.chromium.org/2549583002/diff/80001/mash/example/BUILD.gn
File mash/example/BUILD.gn (left):

https://codereview.chromium.org/2549583002/diff/80001/mash/example/BUILD.gn#o...
mash/example/BUILD.gn:11: "//ash/mus",
On 2016/12/02 18:38:55, James Cook wrote:
> On 2016/12/02 17:04:26, sky wrote:
> > The idea with this dep is if you build mash/example you would have
everything
> > needed to run mash. So, should this dep be conditional based on chromeos?
> 
> Done. Should I also add a dep on simple_wm for Windows?

How about always adding the dep on simple_wm. That way if people want to switch
(there is a command line to change the wm) they won't need to remember to build
simple_wm too.

[James Cook, 2016-12-02 19:12:21]

Thanks for the quick review.

https://codereview.chromium.org/2549583002/diff/80001/mash/example/BUILD.gn
File mash/example/BUILD.gn (left):

https://codereview.chromium.org/2549583002/diff/80001/mash/example/BUILD.gn#o...
mash/example/BUILD.gn:11: "//ash/mus",
On 2016/12/02 18:57:06, sky wrote:
> On 2016/12/02 18:38:55, James Cook wrote:
> > On 2016/12/02 17:04:26, sky wrote:
> > > The idea with this dep is if you build mash/example you would have
> everything
> > > needed to run mash. So, should this dep be conditional based on chromeos?
> > 
> > Done. Should I also add a dep on simple_wm for Windows?
> 
> How about always adding the dep on simple_wm. That way if people want to
switch
> (there is a command line to change the wm) they won't need to remember to
build
> simple_wm too.

Done.

[James Cook, 2016-12-02 19:13:34]

jamescook@chromium.org changed reviewers:
+ dpranke@chromium.org

[James Cook, 2016-12-02 19:13:35]

dpranke, can I get OWNERS for src/BUILD.gn and tools/determinism?

[James Cook, 2016-12-02 20:46:36]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 20:47:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 21:46:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 21:46:57]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2016-12-02 22:51:00]

lgtm

[James Cook, 2016-12-02 23:07:24]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-12-02 23:07:24]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2549583002/#ps160001
(title: "review comments 2")

[commit-bot: I haz the power, 2016-12-02 23:08:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 23:14:45]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1480720044575510,
"parent_rev": "418c881c8beb4cce8a818ec604f07734515a92af", "commit_rev":
"d154aed2d92bc2889237f0433165031dc8cba54c"}

[commit-bot: I haz the power, 2016-12-02 23:15:14]

Committed patchset #8 (id:160001)

[commit-bot: I haz the power, 2016-12-02 23:18:44]

Description was changed from

==========
Remove ash_unittests/mash_unittests from the Windows build

Ash has not shipped on Windows for years so we're removing support. A previous
CL stopped running these tests on the Windows bots.

This also removes the test build targets on Linux, but we have never shipped
ash on non-chromeos Linux, and those tests have never run on the bots.

Future CLs will clean up use_ash vs. is_win vs. is_chromeos in BUILD.gn files.

BUG=666775
TEST=bots
==========

to

==========
Remove ash_unittests/mash_unittests from the Windows build

Ash has not shipped on Windows for years so we're removing support. A previous
CL stopped running these tests on the Windows bots.

This also removes the test build targets on Linux, but we have never shipped
ash on non-chromeos Linux, and those tests have never run on the bots.

Future CLs will clean up use_ash vs. is_win vs. is_chromeos in BUILD.gn files.

BUG=666775
TEST=bots

Committed: https://crrev.com/4c02a0b830b3ee86df411772408344a926c52a86
Cr-Commit-Position: refs/heads/master@{#436074}
==========

[commit-bot: I haz the power, 2016-12-02 23:18:45]

Patchset 8 (id:??) landed as
https://crrev.com/4c02a0b830b3ee86df411772408344a926c52a86
Cr-Commit-Position: refs/heads/master@{#436074}