Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: BUILD.gn

Issue 2549583002: Remove ash_unittests/mash_unittests from Windows build targets (Closed)
Patch Set: review comments 2 Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index f06d672dd5869d691e330cea4823485550957baa..2892e385c251eb3733fb307c3e83f7597f576dfb 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -347,11 +347,16 @@ group("both_gn_and_gyp") {
]
}
- if (use_aura) {
+ if (use_ash) {
deps += [
"//ash:ash_content_unittests",
"//ash:ash_shell_with_content",
"//ash:ash_unittests",
+ ]
+ }
+
+ if (use_aura) {
+ deps += [
"//ui/app_list:app_list_unittests",
"//ui/app_list/presenter:app_list_presenter_unittests",
"//ui/aura:aura_unittests",
@@ -476,6 +481,7 @@ group("both_gn_and_gyp") {
if (is_chromeos) {
deps += [
"//chromeos:chromeos_unittests",
+ "//components/session_manager/core",
"//ui/arc:ui_arc_unittests",
"//ui/chromeos:ui_chromeos_unittests",
]
@@ -508,10 +514,6 @@ group("both_gn_and_gyp") {
]
}
- if (is_chromeos || use_ash) {
- deps += [ "//components/session_manager/core" ]
- }
-
if (is_chrome_branded && is_official_build) {
# TODO(dpranke): add the linux_dump_symbols flag?
deps += [ "//chrome:linux_symbols" ]
« no previous file with comments | « no previous file | ash/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698