Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: chrome/tools/build/win/create_installer_archive.py

Issue 2549583002: Remove ash_unittests/mash_unittests from Windows build targets (Closed)
Patch Set: review comments 2 Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/mus/BUILD.gn ('k') | mash/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/tools/build/win/create_installer_archive.py
diff --git a/chrome/tools/build/win/create_installer_archive.py b/chrome/tools/build/win/create_installer_archive.py
index c2b7cda3507f9f70118c5b48ae38a782da76c596..8c0f8144670e4e1116c04e62bb1d3578c32416dc 100755
--- a/chrome/tools/build/win/create_installer_archive.py
+++ b/chrome/tools/build/win/create_installer_archive.py
@@ -530,12 +530,11 @@ def DoComponentBuildTasks(staging_dir, build_dir, target_arch,
for component_dll in [dll for dll in build_dlls if \
os.path.basename(dll) not in staged_dll_basenames]:
component_dll_name = os.path.basename(component_dll)
- # ash*.dll remoting_*.dll's don't belong in the archive (it doesn't depend
+ # These remoting_*.dll's don't belong in the archive (it doesn't depend
# on them in gyp). Trying to copy them causes a build race when creating the
# installer archive in component mode. See: crbug.com/180996 and
# crbug.com/586967
- if (component_dll_name.startswith('remoting_') or
- component_dll_name.startswith('ash')):
+ if (component_dll_name.startswith('remoting_')):
continue
component_dll_filenames.append(component_dll_name)
« no previous file with comments | « ash/mus/BUILD.gn ('k') | mash/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698