mash/example/BUILD.gn - Issue 2549583002: Remove ash_unittests/mash_unittests from Windows build targets

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mash/example/BUILD.gn

Issue 2549583002: Remove ash_unittests/mash_unittests from Windows build targets (Closed)

Patch Set: ash_content_unittests dependent CL Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2015 The Chromium Authors. All rights reserved.	1 # Copyright 2015 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 import("//testing/test.gni")	5 import("//testing/test.gni")

6	6

7 group("example") {	7 group("example") {

8 testonly = true	8 testonly = true

9	9

10 deps = [	10 deps = [

11 "//ash/mus",
sky 2016/12/02 17:04:26 The idea with this dep is if you build mash/exampl The idea with this dep is if you build mash/example you would have everything needed to run mash. So, should this dep be conditional based on chromeos? James Cook 2016/12/02 18:38:55 Done. Should I also add a dep on simple_wm for Win Show quoted text On 2016/12/02 17:04:26, sky wrote: > The idea with this dep is if you build mash/example you would have everything > needed to run mash. So, should this dep be conditional based on chromeos? Done. Should I also add a dep on simple_wm for Windows? sky 2016/12/02 18:57:06 How about always adding the dep on simple_wm. That Show quoted text On 2016/12/02 18:38:55, James Cook wrote: > On 2016/12/02 17:04:26, sky wrote: > > The idea with this dep is if you build mash/example you would have everything > > needed to run mash. So, should this dep be conditional based on chromeos? > > Done. Should I also add a dep on simple_wm for Windows? How about always adding the dep on simple_wm. That way if people want to switch (there is a command line to change the wm) they won't need to remember to build simple_wm too. James Cook 2016/12/02 19:12:21 Done. Show quoted text On 2016/12/02 18:57:06, sky wrote: > On 2016/12/02 18:38:55, James Cook wrote: > > On 2016/12/02 17:04:26, sky wrote: > > > The idea with this dep is if you build mash/example you would have > everything > > > needed to run mash. So, should this dep be conditional based on chromeos? > > > > Done. Should I also add a dep on simple_wm for Windows? > > How about always adding the dep on simple_wm. That way if people want to switch > (there is a command line to change the wm) they won't need to remember to build > simple_wm too. Done.
12 "//mash/example/views_examples",	11 "//mash/example/views_examples",

13 "//mash/example/window_type_launcher",	12 "//mash/example/window_type_launcher",

14 "//services/service_manager/standalone",	13 "//services/service_manager/standalone",

15 ]	14 ]

16 }	15 }

OLD	NEW

« no previous file with comments | « mash/BUILD.gn ('k') | mash/session/BUILD.gn » ('j') | tools/determinism/deterministic_build_whitelist.pyl » ('J')