Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2529293014: Remove Windows ifdefs in AshNativeCursorManagerTest (Closed)

Created:
4 years ago by James Cook
Modified:
4 years ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Windows ifdefs in AshNativeCursorManagerTest Now that we don't support Ash on Windows we don't need all the conditional code in this test. The reason I'm cleaning up this one first is because it contains the string "ash_unittests.exe" and I'm eliminating all references to Windows-specific binaries. BUG=670351 TEST=ash_unittests Committed: https://crrev.com/bcf395838d0cd24c5c804abc0adba3395964fde8 Cr-Commit-Position: refs/heads/master@{#436088}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -36 lines) Patch
M ash/wm/ash_native_cursor_manager_unittest.cc View 6 chunks +3 lines, -36 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
James Cook
oshima, please take a look.
4 years ago (2016-12-02 21:38:53 UTC) #2
oshima
lgtm
4 years ago (2016-12-02 21:47:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2529293014/20001
4 years ago (2016-12-02 23:52:36 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-03 00:06:34 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-03 00:10:49 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bcf395838d0cd24c5c804abc0adba3395964fde8
Cr-Commit-Position: refs/heads/master@{#436088}

Powered by Google App Engine
This is Rietveld 408576698