Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Unified Diff: mash/BUILD.gn

Issue 2549583002: Remove ash_unittests/mash_unittests from Windows build targets (Closed)
Patch Set: review comments 2 Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/tools/build/win/create_installer_archive.py ('k') | mash/example/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mash/BUILD.gn
diff --git a/mash/BUILD.gn b/mash/BUILD.gn
index c1eb630e10b139b55e733a7eb451212cbbd3fb1f..bc6acf62ea43d6c9e1a373df2d071482f79e8248 100644
--- a/mash/BUILD.gn
+++ b/mash/BUILD.gn
@@ -22,7 +22,7 @@ group("all") {
]
# Build on platforms that support ash.
- if (is_win || is_chromeos) {
+ if (is_chromeos) {
deps += [ "//mash:mash_unittests" ]
}
}
@@ -37,32 +37,35 @@ group("browser") {
]
}
-test("mash_unittests") {
- sources = [
- "test/mash_test_suite.cc",
- "test/mash_test_suite.h",
- "test/mash_unittests.cc",
- ]
- deps = [
- "//ash/common:unittests",
- "//ash/common/test:test_support",
- "//ash/mus:resources",
- "//ash/mus:unittests",
- "//base",
- "//base/test:test_support",
- "//services/service_manager/background:main",
- "//ui/aura",
- "//ui/base",
- "//ui/compositor:test_support",
- "//ui/gl:test_support",
- ]
- data_deps = [
- ":unittests_manifest",
- "//ash/mus:resources",
- ]
-}
+if (is_chromeos) {
+ # TODO(jamescook): Move these tests into //ash/mus.
+ test("mash_unittests") {
+ sources = [
+ "test/mash_test_suite.cc",
+ "test/mash_test_suite.h",
+ "test/mash_unittests.cc",
+ ]
+ deps = [
+ "//ash/common:unittests",
+ "//ash/common/test:test_support",
+ "//ash/mus:resources",
+ "//ash/mus:unittests",
+ "//base",
+ "//base/test:test_support",
+ "//services/service_manager/background:main",
+ "//ui/aura",
+ "//ui/base",
+ "//ui/compositor:test_support",
+ "//ui/gl:test_support",
+ ]
+ data_deps = [
+ ":unittests_manifest",
+ "//ash/mus:resources",
+ ]
+ }
-service_manifest("unittests_manifest") {
- name = "mash_unittests"
- source = "unittests_manifest.json"
+ service_manifest("unittests_manifest") {
+ name = "mash_unittests"
+ source = "unittests_manifest.json"
+ }
}
« no previous file with comments | « chrome/tools/build/win/create_installer_archive.py ('k') | mash/example/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698