Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Issue 2549223003: [Sync] Rename NonUIDataTypeController to AsyncDirectoryTypeController (Closed)

Created:
4 years ago by pavely
Modified:
4 years ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, extensions-reviews_chromium.org, lhchavez+watch_chromium.org, vabr+watchlistpasswordmanager_chromium.org, yusukes+watch_chromium.org, rouslan+autofill_chromium.org, tfarina, hidehiko+watch_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, mathp+autofillwatch_chromium.org, pam+watch_chromium.org, estade+watch_chromium.org, vabr+watchlistautofill_chromium.org, chromium-apps-reviews_chromium.org, gcasto+watchlist_chromium.org, sebsg+autofillwatch_chromium.org, sync-reviews_chromium.org, Matt Giuca
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Rename NonUIDataTypeController to AsyncDirectoryTypeController This change is mechanical. I renamed files, replaced references and ran through git cl format. BUG=647505 R=maxbogue@chromium.org TBR=treib@chromium.org,mgiuca@chromium.org,vabr@chromium.org,sdefresne@chromium.org,pkasting@chromium.org Committed: https://crrev.com/3778079943f27e7cd301ffce30b50ea9d1e2dbb5 Cr-Commit-Position: refs/heads/master@{#436480}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -1165 lines) Patch
M chrome/browser/supervised_user/supervised_user_sync_data_type_controller.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_sync_data_type_controller.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/sync/chrome_sync_client.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sync/glue/extension_data_type_controller.h View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/extension_data_type_controller.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/sync/glue/extension_setting_data_type_controller.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/extension_setting_data_type_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/theme_data_type_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/theme_data_type_controller.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.h View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M components/autofill/core/browser/autofill_wallet_data_type_controller.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/autofill/core/browser/autofill_wallet_data_type_controller.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_data_type_controller.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_data_type_controller.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_profile_data_type_controller.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_profile_data_type_controller.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M components/browser_sync/profile_sync_components_factory_impl.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M components/history/core/browser/history_delete_directives_data_type_controller.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/history/core/browser/history_delete_directives_data_type_controller.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M components/history/core/browser/typed_url_data_type_controller.h View 2 chunks +4 lines, -4 lines 0 comments Download
M components/history/core/browser/typed_url_data_type_controller.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M components/password_manager/sync/browser/password_data_type_controller.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/password_manager/sync/browser/password_data_type_controller.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M components/search_engines/search_engine_data_type_controller.h View 2 chunks +4 lines, -3 lines 0 comments Download
M components/search_engines/search_engine_data_type_controller.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M components/search_engines/search_engine_data_type_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/BUILD.gn View 6 chunks +5 lines, -5 lines 0 comments Download
M components/sync/device_info/device_info_data_type_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/sync/device_info/device_info_data_type_controller.cc View 1 chunk +5 lines, -5 lines 0 comments Download
A + components/sync/driver/async_directory_type_controller.h View 4 chunks +10 lines, -11 lines 0 comments Download
A + components/sync/driver/async_directory_type_controller.cc View 11 chunks +28 lines, -26 lines 0 comments Download
A + components/sync/driver/async_directory_type_controller_mock.h View 3 chunks +8 lines, -8 lines 0 comments Download
A components/sync/driver/async_directory_type_controller_mock.cc View 1 chunk +13 lines, -0 lines 0 comments Download
A + components/sync/driver/async_directory_type_controller_unittest.cc View 17 chunks +34 lines, -33 lines 0 comments Download
D components/sync/driver/non_ui_data_type_controller.h View 1 chunk +0 lines, -154 lines 0 comments Download
D components/sync/driver/non_ui_data_type_controller.cc View 1 chunk +0 lines, -269 lines 0 comments Download
D components/sync/driver/non_ui_data_type_controller_mock.h View 1 chunk +0 lines, -43 lines 0 comments Download
D components/sync/driver/non_ui_data_type_controller_mock.cc View 1 chunk +0 lines, -13 lines 0 comments Download
D components/sync/driver/non_ui_data_type_controller_unittest.cc View 1 chunk +0 lines, -480 lines 0 comments Download
M components/sync_sessions/session_data_type_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/sync_sessions/session_data_type_controller.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
pavely
4 years ago (2016-12-05 23:09:04 UTC) #3
maxbogue
lgtm
4 years ago (2016-12-05 23:48:12 UTC) #6
pavely
Adding OWNERS reviewers to TBR: chrome/browser/supervised_user - treib@chromium.org chrome/browser/ui/app_list - mgiuca@chromium.org components/autofill components/password_manager - vabr@chromium.org ...
4 years ago (2016-12-06 01:10:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2549223003/1
4 years ago (2016-12-06 01:11:18 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 01:18:15 UTC) #15
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3778079943f27e7cd301ffce30b50ea9d1e2dbb5 Cr-Commit-Position: refs/heads/master@{#436480}
4 years ago (2016-12-06 01:20:41 UTC) #17
Peter Kasting
LGTM
4 years ago (2016-12-06 01:28:10 UTC) #18
vabr (Chromium)
4 years ago (2016-12-06 08:12:17 UTC) #19
Message was sent while issue was closed.
> components/autofill
> components/password_manager
> - mailto:vabr@chromium.org

Both those groups of changes LGTM. Thanks!
Vaclav

Powered by Google App Engine
This is Rietveld 408576698