Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: components/sync/driver/non_ui_data_type_controller.h

Issue 2549223003: [Sync] Rename NonUIDataTypeController to AsyncDirectoryTypeController (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/driver/non_ui_data_type_controller.h
diff --git a/components/sync/driver/non_ui_data_type_controller.h b/components/sync/driver/non_ui_data_type_controller.h
deleted file mode 100644
index e7ecc24a9f3d2376386c349eebf75e2e757787c6..0000000000000000000000000000000000000000
--- a/components/sync/driver/non_ui_data_type_controller.h
+++ /dev/null
@@ -1,154 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef COMPONENTS_SYNC_DRIVER_NON_UI_DATA_TYPE_CONTROLLER_H_
-#define COMPONENTS_SYNC_DRIVER_NON_UI_DATA_TYPE_CONTROLLER_H_
-
-#include <memory>
-#include <string>
-
-#include "base/compiler_specific.h"
-#include "base/memory/ref_counted.h"
-#include "base/memory/weak_ptr.h"
-#include "base/sequenced_task_runner.h"
-#include "components/sync/driver/directory_data_type_controller.h"
-#include "components/sync/driver/shared_change_processor.h"
-
-namespace syncer {
-
-class SyncClient;
-struct UserShare;
-
-// Implementation for datatypes that reside on non-UI thread. All interaction
-// with datatype controller happens on UI thread. Calls to SyncableService are
-// posted to model thread through PostTaskOnModelThread().
-// Note: RefCountedThreadSafe by way of DataTypeController.
-class NonUIDataTypeController : public DirectoryDataTypeController {
- public:
- // |dump_stack| is called when an unrecoverable error occurs.
- NonUIDataTypeController(
- ModelType type,
- const base::Closure& dump_stack,
- SyncClient* sync_client,
- ModelSafeGroup model_safe_group,
- scoped_refptr<base::SequencedTaskRunner> model_thread);
- ~NonUIDataTypeController() override;
-
- // DataTypeController interface.
- void LoadModels(const ModelLoadCallback& model_load_callback) override;
- void StartAssociating(const StartCallback& start_callback) override;
- void Stop() override;
- ChangeProcessor* GetChangeProcessor() const override;
- std::string name() const override;
- State state() const override;
-
- // Used by tests to override the factory used to create
- // GenericChangeProcessors.
- void SetGenericChangeProcessorFactoryForTest(
- std::unique_ptr<GenericChangeProcessorFactory> factory);
-
- protected:
- // For testing only.
- NonUIDataTypeController();
-
- // Start any dependent services that need to be running before we can
- // associate models. The default implementation is a no-op.
- // Return value:
- // True - if models are ready and association can proceed.
- // False - if models are not ready. StartAssociationAsync should be called
- // when the models are ready.
- // Note: this is performed on the UI thread.
- virtual bool StartModels();
-
- // Perform any DataType controller specific state cleanup before stopping
- // the datatype controller. The default implementation is a no-op.
- // Note: this is performed on the UI thread.
- virtual void StopModels();
-
- // Posts the given task to the model thread, i.e. the thread the datatype
- // lives on. Return value: True if task posted successfully, false otherwise.
- // Default implementation posts task to model_thread_. Types that don't use
- // TaskRunner need to override this method.
- virtual bool PostTaskOnModelThread(const tracked_objects::Location& from_here,
- const base::Closure& task);
-
- // Start up complete, update the state and invoke the callback.
- virtual void StartDone(DataTypeController::ConfigureResult start_result,
- const SyncMergeResult& local_merge_result,
- const SyncMergeResult& syncer_merge_result);
-
- // Kick off the association process.
- virtual bool StartAssociationAsync();
-
- // Record causes of start failure.
- virtual void RecordStartFailure(ConfigureResult result);
-
- // To allow unit tests to control thread interaction during non-ui startup
- // and shutdown, use a factory method to create the SharedChangeProcessor.
- virtual SharedChangeProcessor* CreateSharedChangeProcessor();
-
- // If the DTC is waiting for models to load, once the models are
- // loaded the datatype service will call this function on DTC to let
- // us know that it is safe to start associating.
- void OnModelLoaded();
-
- std::unique_ptr<DataTypeErrorHandler> CreateErrorHandler() override;
-
- private:
- // Posted on the backend thread by StartAssociationAsync().
- void StartAssociationWithSharedChangeProcessor(
- const scoped_refptr<SharedChangeProcessor>& shared_change_processor);
-
- // Calls Disconnect() on |shared_change_processor_|, then sets it to
- // null. Must be called only by StartDoneImpl() or Stop() (on the
- // UI thread) and only after a call to Start() (i.e.,
- // |shared_change_processor_| must be non-null).
- void DisconnectSharedChangeProcessor();
-
- // Posts StopLocalService() to the processor on the model type thread.
- void StopSyncableService();
-
- // Disable this type with the sync service. Should only be invoked in case of
- // an unrecoverable error.
- // Note: this is performed on the UI thread.
- void DisableImpl(const SyncError& error);
-
- // UserShare is stored in StartAssociating while on UI thread and
- // passed to SharedChangeProcessor::Connect on the model thread.
- UserShare* user_share_;
-
- // Factory is used by tests to inject custom implementation of
- // GenericChangeProcessor.
- std::unique_ptr<GenericChangeProcessorFactory> processor_factory_;
-
- // State of this datatype controller.
- State state_;
-
- // Callbacks for use when starting the datatype.
- StartCallback start_callback_;
- ModelLoadCallback model_load_callback_;
-
- // Task runner of the model thread. Can be nullptr in which case datatype
- // controller needs to override PostTaskOnModelThread().
- scoped_refptr<base::SequencedTaskRunner> model_thread_;
-
- // The shared change processor is the thread-safe interface to the
- // datatype. We hold a reference to it from the UI thread so that
- // we can call Disconnect() on it from Stop()/StartDoneImpl(). Most
- // of the work is done on the backend thread, and in
- // StartAssociationWithSharedChangeProcessor() for this class in
- // particular.
- //
- // Lifetime: The SharedChangeProcessor object is created on the UI
- // thread and passed on to the backend thread. This reference is
- // released on the UI thread in Stop()/StartDoneImpl(), but the
- // backend thread may still have references to it (which is okay,
- // since we call Disconnect() before releasing the UI thread
- // reference).
- scoped_refptr<SharedChangeProcessor> shared_change_processor_;
-};
-
-} // namespace syncer
-
-#endif // COMPONENTS_SYNC_DRIVER_NON_UI_DATA_TYPE_CONTROLLER_H_

Powered by Google App Engine
This is Rietveld 408576698