Fix WebBluetooth generator to distinguish between different methods.

Fix WebBluetooth generator to distinguish between different methods.

This change allows tests to be created that exercise both
characteristic.readValue/writeValue and descriptor.readValue/writeValue.
script-tests's name determine what feature they are testing.  For example, a
test that wants to tests gatt operations on a descriptor can be named:

bluetooth/script-tests/descriptor/<>

then in bluetooth/descriptor/<>/ each of the gatt calls will be generated.

In addition and prep for this change, we are moving files around.  The
structure now is the following:

device
    gattserverdisconnected-event

service
   getCharacteristic
   getCharacteristics

server
    getPrimaryService
    getPrimaryServices
    connect
    disconnect

characterisitic
   startNotifications
   stopNotifications
   readValue
   writeValue
   getDescriptor
   getDescriptors
   notifications

BUG=668836
R=ortuno

Committed: https://crrev.com/36c5c1c79009ee041372a8487ec3317606e9f5f4
Cr-Commit-Position: refs/heads/master@{#436173}

[dougt, 2016-12-01 21:01:41]

The CQ bit was checked by dougt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 21:02:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 22:10:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 22:10:34]

Dry run: This issue passed the CQ dry run.

[dougt, 2016-12-02 02:36:53]

Ortuno, please take a look.

[ortuno, 2016-12-02 09:57:50]

lgtm bar some nits.

https://codereview.chromium.org/2544513004/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/bluetooth/generate.py (right):

https://codereview.chromium.org/2544513004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/bluetooth/generate.py:82: print template_path
nit: no need to print.

https://codereview.chromium.org/2544513004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/bluetooth/generate.py:104: new_test_file_data =
base_template_file_data.replace('TEST', template_file_data)
nit: break line.

https://codereview.chromium.org/2544513004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/bluetooth/generate.py:127: directory =
os.path.basename(os.path.abspath(os.path.join(template, os.pardir)))
hmm current_path, directory, name, call_test_file_name make things really
confusing. Strawman proposal: 

s/current_path/bluetooth_tests_dir/
s/directory/group_dir/ 
s/name/function_name/

Which results in:

os.path.join(bluetooth_tests_dir, group_dir, function_name,
call_test_file_name);

WDYT?

[dougt, 2016-12-02 18:34:25]

The CQ bit was checked by dougt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 18:35:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dougt, 2016-12-02 22:00:53]

Good suggestions. Please review the changes.

[commit-bot: I haz the power, 2016-12-02 22:08:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 22:08:42]

Dry run: This issue passed the CQ dry run.

[ortuno, 2016-12-02 22:34:03]

lgtm

[scheib, 2016-12-02 22:40:34]

scheib@chromium.org changed reviewers:
+ scheib@chromium.org

[scheib, 2016-12-02 22:40:37]

I like the change! Would you include some of the description about how the file
paths are managed from the change description into the generate.py file and or
readme?

https://codereview.chromium.org/2544513004/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/bluetooth/README (right):

https://codereview.chromium.org/2544513004/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/bluetooth/README:7: TL;DR
:P I have TL;DR phobia. Just remove the "TL;DR" line and leave the summary.
"Overview" Also seems unnecessary, but keep it you like.

[dougt, 2016-12-03 18:17:19]

On 2016/12/02 22:40:37, scheib wrote:
> I like the change! Would you include some of the description about how the
file
> paths are managed from the change description into the generate.py file and or
> readme?

Thanks scheib.  This change will make it easier to use CALL for other methods
(like getDescriptor[s]).

As far as more docs, does this work for you?  I left the generate.py without
this comment because the code is pretty straight forward.

https://codereview.chromium.org/2544513004/diff/20001/third_party/WebKit/Layo...


>
https://codereview.chromium.org/2544513004/diff/20001/third_party/WebKit/Layo...
> third_party/WebKit/LayoutTests/bluetooth/README:7: TL;DR
> :P I have TL;DR phobia. Just remove the "TL;DR" line and leave the summary.
> "Overview" Also seems unnecessary, but keep it you like.

I <3 TL;DRs! ;)

TL;DR:  Done.

[dougt, 2016-12-03 18:36:40]

The CQ bit was checked by dougt@chromium.org

[dougt, 2016-12-03 18:36:42]

The patchset sent to the CQ was uploaded after l-g-t-m from ortuno@chromium.org
Link to the patchset: https://codereview.chromium.org/2544513004/#ps40001
(title: "Remove TL;DR in README")

[commit-bot: I haz the power, 2016-12-03 18:36:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-03 21:09:08]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480790200482760,
"parent_rev": "4918da1f7b4853059605e25b95d045ad82b13cd4", "commit_rev":
"0605578c2bd52fe1d207e2ed92fab273a9ebb99c"}

[commit-bot: I haz the power, 2016-12-03 21:09:34]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-03 21:12:02]

Description was changed from

==========
Fix WebBluetooth generator to distinguish between different methods.

This change allows tests to be created that exercise both
characteristic.readValue/writeValue and descriptor.readValue/writeValue.
script-tests's name determine what feature they are testing.  For example, a
test that wants to tests gatt operations on a descriptor can be named:

bluetooth/script-tests/descriptor/<>

then in bluetooth/descriptor/<>/ each of the gatt calls will be generated.

In addition and prep for this change, we are moving files around.  The
structure now is the following:

device
    gattserverdisconnected-event

service
   getCharacteristic
   getCharacteristics

server
    getPrimaryService
    getPrimaryServices
    connect
    disconnect

characterisitic
   startNotifications
   stopNotifications
   readValue
   writeValue
   getDescriptor
   getDescriptors
   notifications

BUG=668836
R=ortuno
==========

to

==========
Fix WebBluetooth generator to distinguish between different methods.

This change allows tests to be created that exercise both
characteristic.readValue/writeValue and descriptor.readValue/writeValue.
script-tests's name determine what feature they are testing.  For example, a
test that wants to tests gatt operations on a descriptor can be named:

bluetooth/script-tests/descriptor/<>

then in bluetooth/descriptor/<>/ each of the gatt calls will be generated.

In addition and prep for this change, we are moving files around.  The
structure now is the following:

device
    gattserverdisconnected-event

service
   getCharacteristic
   getCharacteristics

server
    getPrimaryService
    getPrimaryServices
    connect
    disconnect

characterisitic
   startNotifications
   stopNotifications
   readValue
   writeValue
   getDescriptor
   getDescriptors
   notifications

BUG=668836
R=ortuno

Committed: https://crrev.com/36c5c1c79009ee041372a8487ec3317606e9f5f4
Cr-Commit-Position: refs/heads/master@{#436173}
==========

[commit-bot: I haz the power, 2016-12-03 21:12:04]

Patchset 3 (id:??) landed as
https://crrev.com/36c5c1c79009ee041372a8487ec3317606e9f5f4
Cr-Commit-Position: refs/heads/master@{#436173}

[scheib, 2016-12-05 04:19:07]

On 2016/12/03 18:17:19, dougt wrote:
> On 2016/12/02 22:40:37, scheib wrote:
> > I like the change! Would you include some of the description about how the
> file
> > paths are managed from the change description into the generate.py file and
or
> > readme?
> 
> Thanks scheib.  This change will make it easier to use CALL for other methods
> (like getDescriptor[s]).
> 
> As far as more docs, does this work for you?  I left the generate.py without
> this comment because the code is pretty straight forward.

I'd seen the README and saw that the change description had better summary
information about what the code was doing. My request was to include that into
the README.

> 
>
https://codereview.chromium.org/2544513004/diff/20001/third_party/WebKit/Layo...
> 
> 
> >
>
https://codereview.chromium.org/2544513004/diff/20001/third_party/WebKit/Layo...
> > third_party/WebKit/LayoutTests/bluetooth/README:7: TL;DR
> > :P I have TL;DR phobia. Just remove the "TL;DR" line and leave the summary.
> > "Overview" Also seems unnecessary, but keep it you like.
> 
> I <3 TL;DRs! ;)

I like summaries, and don't think they need to be prefixed with 'summary', and
especially not a acronym. I'm sorry I wasn't clearer in the request, it was only
to remove the literal "TL;DR\n" line, the actual summary sentence was good.
 
> 
> TL;DR:  Done.