third_party/WebKit/LayoutTests/bluetooth/notifications/gc-with-pending-start.html - Issue 2544513004: Fix WebBluetooth generator to distinguish between different methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/bluetooth/notifications/gc-with-pending-start.html

Issue 2544513004: Fix WebBluetooth generator to distinguish between different methods. (Closed)

Patch Set: Remove TL;DR in README Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/bluetooth/notifications/event-after-starting.html ('k') | third_party/WebKit/LayoutTests/bluetooth/notifications/gc-with-pending-stop.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/bluetooth/notifications/gc-with-pending-start.html

diff --git a/third_party/WebKit/LayoutTests/bluetooth/notifications/gc-with-pending-start.html b/third_party/WebKit/LayoutTests/bluetooth/notifications/gc-with-pending-start.html

deleted file mode 100644

index d3db2f8e3aa22f707289e005c8d8d398c1a18b4f..0000000000000000000000000000000000000000

--- a/third_party/WebKit/LayoutTests/bluetooth/notifications/gc-with-pending-start.html

+++ /dev/null

@@ -1,29 +0,0 @@

-<!DOCTYPE html>

-<script src="../../resources/testharness.js"></script>

-<script src="../../resources/testharnessreport.js"></script>

-<script src="../../resources/bluetooth/bluetooth-helpers.js"></script>

-<script>

-'use strict';

-promise_test(() => {

- let start_promise;

- return setBluetoothFakeAdapter('HeartRateAdapter')

- .then(() => requestDeviceWithKeyDown({

- filters: [{services: ['heart_rate']}]}))

- .then(device => device.gatt.connect())

- .then(gattServer => gattServer.getPrimaryService('heart_rate'))

- .then(service => service.getCharacteristic('heart_rate_measurement'))

- .then(characteristic => {

- start_promise = characteristic.startNotifications();

- // We intentionally don't return the promise so that 'characteristic' goes

- // out of scope while the request is still pending.

- })

- .then(() => runGarbageCollection())

- .then(() => start_promise);

- // TODO(ortuno): Assert that notifications are not active.

- // http://crbug.com/600762

- // Objects will no longer get garbage collected once we implement the

- // bluetooth tree.

- // https://crbug.com/495270

-}, 'Object gets garbage collected while start request is pending. Make ' +

- 'sure we don\' crash.');

-</script>