third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/gc-with-pending-start.html - Issue 2544513004: Fix WebBluetooth generator to distinguish between different methods.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/gc-with-pending-start.html

Issue 2544513004: Fix WebBluetooth generator to distinguish between different methods. (Closed)

Patch Set: Remove TL;DR in README Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/event-after-starting.html ('k') | third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/gc-with-pending-stop.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../resources/testharness.js"></script>	2 <script src="../../../resources/testharness.js"></script>

3 <script src="../../resources/testharnessreport.js"></script>	3 <script src="../../../resources/testharnessreport.js"></script>

4 <script src="../../resources/bluetooth/bluetooth-helpers.js"></script>	4 <script src="../../../resources/bluetooth/bluetooth-helpers.js"></script>

5 <script>	5 <script>

6 'use strict';	6 'use strict';

7 promise_test(() => {	7 promise_test(() => {

8 let start_promise;	8 let start_promise;

9 return setBluetoothFakeAdapter('HeartRateAdapter')	9 return setBluetoothFakeAdapter('HeartRateAdapter')

10 .then(() => requestDeviceWithKeyDown({	10 .then(() => requestDeviceWithKeyDown({

11 filters: [{services: ['heart_rate']}]}))	11 filters: [{services: ['heart_rate']}]}))

12 .then(device => device.gatt.connect())	12 .then(device => device.gatt.connect())

13 .then(gattServer => gattServer.getPrimaryService('heart_rate'))	13 .then(gattServer => gattServer.getPrimaryService('heart_rate'))

14 .then(service => service.getCharacteristic('heart_rate_measurement'))	14 .then(service => service.getCharacteristic('heart_rate_measurement'))

15 .then(characteristic => {	15 .then(characteristic => {

16 start_promise = characteristic.startNotifications();	16 start_promise = characteristic.startNotifications();

17 // We intentionally don't return the promise so that 'characteristic' goes	17 // We intentionally don't return the promise so that 'characteristic' goes

18 // out of scope while the request is still pending.	18 // out of scope while the request is still pending.

19 })	19 })

20 .then(() => runGarbageCollection())	20 .then(() => runGarbageCollection())

21 .then(() => start_promise);	21 .then(() => start_promise);

22 // TODO(ortuno): Assert that notifications are not active.	22 // TODO(ortuno): Assert that notifications are not active.

23 // http://crbug.com/600762	23 // http://crbug.com/600762

24 // Objects will no longer get garbage collected once we implement the	24 // Objects will no longer get garbage collected once we implement the

25 // bluetooth tree.	25 // bluetooth tree.

26 // https://crbug.com/495270	26 // https://crbug.com/495270

27 }, 'Object gets garbage collected while start request is pending. Make ' +	27 }, 'Object gets garbage collected while start request is pending. Make ' +

28 'sure we don\' crash.');	28 'sure we don\' crash.');

29 </script>	29 </script>

OLD	NEW