third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/invalid-characteristic-name.html - Issue 2544513004: Fix WebBluetooth generator to distinguish between different methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/invalid-characteristic-name.html

Issue 2544513004: Fix WebBluetooth generator to distinguish between different methods. (Closed)

Patch Set: Remove TL;DR in README Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/gen-characteristic-get-same-object-with-uuid.html ('k') | third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/reconnect-during.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/invalid-characteristic-name.html

diff --git a/third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/invalid-characteristic-name.html b/third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/invalid-characteristic-name.html

deleted file mode 100644

index 79aef581248b2ea2248f44bd6524c20e7f9b5dcd..0000000000000000000000000000000000000000

--- a/third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/invalid-characteristic-name.html

+++ /dev/null

@@ -1,31 +0,0 @@

-<!DOCTYPE html>

-<script src="../../resources/testharness.js"></script>

-<script src="../../resources/testharnessreport.js"></script>

-<script src="../../resources/bluetooth/bluetooth-helpers.js"></script>

-<script>

-'use strict';

-promise_test(() => {

- return setBluetoothFakeAdapter('HeartRateAdapter')

- .then(() => requestDeviceWithKeyDown({

- filters: [{services: ['heart_rate']}],

- optionalServices: ['generic_access']}))

- .then(device => device.gatt.connect())

- .then(gattServer => gattServer.getPrimaryService('generic_access'))

- .then(service => {

- return assert_promise_rejects_with_message(

- service.getCharacteristics('wrong_name'), new DOMException(

- 'Failed to execute \'getCharacteristics\' on ' +

- '\'BluetoothRemoteGATTService\': Invalid Characteristic name: ' +

- '\'wrong_name\'. ' +

- 'It must be a valid UUID alias (e.g. 0x1234), ' +

- 'UUID (lowercase hex characters e.g. ' +

- '\'00001234-0000-1000-8000-00805f9b34fb\'), ' +

- 'or recognized standard name from ' +

- 'https://developer.bluetooth.org/gatt/characteristics/' +

- 'Pages/CharacteristicsHome.aspx' +

- ' e.g. \'aerobic_heart_rate_lower_limit\'.',

- 'TypeError'),

- 'Wrong Characteristic name passed.');

- });

-}, 'Invalid Characteristic name. Reject with TypeError.');

-</script>