Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/README

Issue 2544513004: Fix WebBluetooth generator to distinguish between different methods. (Closed)
Patch Set: fixes to address comments from ortuno Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 Web Bluetooth API LayoutTests README 1 Web Bluetooth API LayoutTests README
2 2
3 This directory contains Web Bluetooth API layout tests. 3 This directory contains Web Bluetooth API layout tests.
4 4
5 # generator.py 5 # generator.py
6 6
7 The following files are generated by the generator.py script: 7 TL;DR
scheib 2016/12/02 22:40:36 :P I have TL;DR phobia. Just remove the "TL;DR" li
8 - /getPrimaryService/gen-*
9 - /getPrimaryServices/gen-*
10 8
11 TODO(crbug.com/654670): Generate tests for getCharacteristic(s) and 9 Directories in bluetooth/script-tests generate tests in bluetooth/
12 readValue/writeValue/startNotifications. 10
11 Overview
12
13 For all .js files in script-tests/, generator.py will attempt to build test
14 in bluetooth/.
15
16 Note that for each subdirectory in script-test there is a matching directory
17 under bluetooth/. The generator will expand CALL functions into this
18 corresponding directory.
19
20 Example:
21
22 bluetooth/script-tests/server/get-same-object.js expanded CALL will generate 3
23 files:
24
25 bluetooth/server/getPrimaryService/gen-get-same-object.html
26 bluetooth/server/getPrimaryServices/gen-get-same-object.html
27 bluetooth/server/getPrimaryServices/gen-get-same-object-with-uuid.html
28
29 This is because of the following lines CALL:
30
31 gattServer.CALLS([
32 getPrimaryService('heart_rate')|
33 getPrimaryServices()|
34 getPrimaryServices('heart_rate')[UUID]]),
35
13 36
14 Run 37 Run
38
15 $ python //third_party/WebKit/LayoutTests/bluetooth/generate.py 39 $ python //third_party/WebKit/LayoutTests/bluetooth/generate.py
16 to generate these files from templates in script-tests/*.js 40 to generate these files from templates in script-tests/*.js
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698