Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: third_party/WebKit/LayoutTests/bluetooth/README

Issue 2544513004: Fix WebBluetooth generator to distinguish between different methods. (Closed)
Patch Set: Remove TL;DR in README Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/bluetooth/README
diff --git a/third_party/WebKit/LayoutTests/bluetooth/README b/third_party/WebKit/LayoutTests/bluetooth/README
index 66ef8a7aec1c1d818258b73aa71d4ddbea0f59d3..18c7f569b060372bdc743d1d141743e2f1a2315e 100644
--- a/third_party/WebKit/LayoutTests/bluetooth/README
+++ b/third_party/WebKit/LayoutTests/bluetooth/README
@@ -4,13 +4,31 @@ This directory contains Web Bluetooth API layout tests.
# generator.py
-The following files are generated by the generator.py script:
- - /getPrimaryService/gen-*
- - /getPrimaryServices/gen-*
+For all .js files in script-tests/, generator.py will attempt to build test
+in bluetooth/.
+
+Note that for each subdirectory in script-test there is a matching directory
+under bluetooth/. The generator will expand CALL functions into this
+corresponding directory.
+
+Example:
+
+bluetooth/script-tests/server/get-same-object.js expanded CALL will generate 3
+files:
+
+bluetooth/server/getPrimaryService/gen-get-same-object.html
+bluetooth/server/getPrimaryServices/gen-get-same-object.html
+bluetooth/server/getPrimaryServices/gen-get-same-object-with-uuid.html
+
+This is because of the following lines CALL:
+
+gattServer.CALLS([
+ getPrimaryService('heart_rate')|
+ getPrimaryServices()|
+ getPrimaryServices('heart_rate')[UUID]]),
-TODO(crbug.com/654670): Generate tests for getCharacteristic(s) and
-readValue/writeValue/startNotifications.
Run
+
$ python //third_party/WebKit/LayoutTests/bluetooth/generate.py
to generate these files from templates in script-tests/*.js

Powered by Google App Engine
This is Rietveld 408576698