WebString: makes string16 conversions explicit (part 1: blink, content)

WebString: makes string16 conversions explicit (part 1: blink, content)

This is a series of patches that make WebString <-> string16 conversions
explicit.  Implicit conversions between WebString and string16 used to make
it really easy to write inefficient code and should be removed.
(More details can be found on crbug.com/667131)

This CL changes implicit conversions to/from string16 by adding following methods:

* static WebString WebString::fromUTF16(const string16&);
* static WebString WebString::fromUTF16(const NullableString16&);
* string16 WebString::utf16();
* static NullableString16 WebString::toNullableString16();

Revises/removes following unnecessary conversions:

* UTF16ToUTF8(StringPiece16(webstring)) -> webstring.utf8()
* WebString(UTF8ToUTF16(string)) -> WebString::fromUTF8(string)
* WebString(ASCIIToUTF16(string)) -> WebString::fromASCII(string)
* WebString(path.AsUTF8Unsafe()) -> FilePathToWebString(path)
* base::IsStringASCII(webstring) -> webstring.containsOnlyASCII()
* base::FilePath::FromUTF8Unsafe(webstring.utf8()) ->
  WebStringToFilePath(webstring)

(This still doesn't fix inefficient String comparisons that require unnecessary string copies,
it should be able to be fixed in a separate patch)

BUG=667131

[kinuko, 2016-11-30 05:07:02]

Description was changed from

==========
WebString: makes string16 conversions explicit

Changes implicit conversions to/from string16 by adding following methods:

* static WebString WebString::fromUTF16(const string16&);
* static WebString WebString::fromUTF16(const NullableString16&);
* string16 WebString::utf16();
* static NullableString16 WebString::toNullableString16();

Also adds following helper methods/templates:

* WebVector<WebString> CopyStringVectorFromUTF16(const std::vector<string16>&)
* WebVector<WebString> CopyStringVectorFromUTF8(const std::vector<string>&)
* WebVector<WebString> CopyStringVectorFromLatin1(const std::vector<string>&)
* WebString WebStringToFilePath(base::FilePath&)

Revises/removes following unnecessary conversions:

* UTF16ToUTF8(StringPiece16(webstring)) -> webstring.utf8()
* WebString(UTF8ToUTF16(string)) -> WebString::fromUTF8(string)
* WebString(ASCIIToUTF16(string)) -> WebString::fromASCII(string)
* WebString(path.AsUTF8Unsafe()) -> FilePathToWebString(path)
* base::FilePath::FromUTF8Unsafe(webstring.utf8()) ->
  WebStringToFilePath(webstring)

BUG=667131
==========

to

==========
WebString: makes string16 conversions explicit

Changes implicit conversions to/from string16 by adding following methods:

* static WebString WebString::fromUTF16(const string16&);
* static WebString WebString::fromUTF16(const NullableString16&);
* string16 WebString::utf16();
* static NullableString16 WebString::toNullableString16();

Also adds following helper methods/templates:

* WebVector<WebString> CopyStringVectorFromUTF16(const std::vector<string16>&)
* WebVector<WebString> CopyStringVectorFromUTF8(const std::vector<string>&)
* WebVector<WebString> CopyStringVectorFromLatin1(const std::vector<string>&)
* WebString WebStringToFilePath(base::FilePath&)

Revises/removes following unnecessary conversions:

* UTF16ToUTF8(StringPiece16(webstring)) -> webstring.utf8()
* WebString(UTF8ToUTF16(string)) -> WebString::fromUTF8(string)
* WebString(ASCIIToUTF16(string)) -> WebString::fromASCII(string)
* WebString(path.AsUTF8Unsafe()) -> FilePathToWebString(path)
* base::FilePath::FromUTF8Unsafe(webstring.utf8()) ->
  WebStringToFilePath(webstring)

BUG=667131
==========

[kinuko, 2016-11-30 05:07:02]

kinuko@chromium.org changed reviewers:
+ dcheng@chromium.org, esprehn@chromium.org

[kinuko, 2016-11-30 05:14:35]

Description was changed from

==========
WebString: makes string16 conversions explicit

Changes implicit conversions to/from string16 by adding following methods:

* static WebString WebString::fromUTF16(const string16&);
* static WebString WebString::fromUTF16(const NullableString16&);
* string16 WebString::utf16();
* static NullableString16 WebString::toNullableString16();

Also adds following helper methods/templates:

* WebVector<WebString> CopyStringVectorFromUTF16(const std::vector<string16>&)
* WebVector<WebString> CopyStringVectorFromUTF8(const std::vector<string>&)
* WebVector<WebString> CopyStringVectorFromLatin1(const std::vector<string>&)
* WebString WebStringToFilePath(base::FilePath&)

Revises/removes following unnecessary conversions:

* UTF16ToUTF8(StringPiece16(webstring)) -> webstring.utf8()
* WebString(UTF8ToUTF16(string)) -> WebString::fromUTF8(string)
* WebString(ASCIIToUTF16(string)) -> WebString::fromASCII(string)
* WebString(path.AsUTF8Unsafe()) -> FilePathToWebString(path)
* base::FilePath::FromUTF8Unsafe(webstring.utf8()) ->
  WebStringToFilePath(webstring)

BUG=667131
==========

to

==========
WebString: makes string16 conversions explicit

Implicit conversions between WebString and string16 makes it really easy
to write inefficient code.  (More details can be found on crbug.com/667131)

This CL changes implicit conversions to/from string16 by adding following
methods:

* static WebString WebString::fromUTF16(const string16&);
* static WebString WebString::fromUTF16(const NullableString16&);
* string16 WebString::utf16();
* static NullableString16 WebString::toNullableString16();

Also adds following helper methods/templates:

* WebVector<WebString> CopyStringVectorFromUTF16(const std::vector<string16>&)
* WebVector<WebString> CopyStringVectorFromUTF8(const std::vector<string>&)
* WebVector<WebString> CopyStringVectorFromLatin1(const std::vector<string>&)
* WebString WebStringToFilePath(base::FilePath&)

Revises/removes following unnecessary conversions:

* UTF16ToUTF8(StringPiece16(webstring)) -> webstring.utf8()
* WebString(UTF8ToUTF16(string)) -> WebString::fromUTF8(string)
* WebString(ASCIIToUTF16(string)) -> WebString::fromASCII(string)
* WebString(path.AsUTF8Unsafe()) -> FilePathToWebString(path)
* base::IsStringASCII(webstring) -> webstring.containsOnlyASCII()
* base::FilePath::FromUTF8Unsafe(webstring.utf8()) ->
  WebStringToFilePath(webstring)

(This still doesn't fix inefficient String comparisons that require unnecessary
string copies,
it should be able to be fixed in a separate patch)

BUG=667131
==========

[kinuko, 2016-11-30 05:24:17]

Just started to take a stab and then realized this touches large number of files
and may need to be done in multiple shots.

Anyways here's what I have now-- what do you think of this change?

[dcheng, 2016-11-30 06:10:53]

I am definitely in favor of this.

However, I'm curious: do we really need to support latin1?

[kinuko, 2016-11-30 12:18:26]

On 2016/11/30 06:10:53, dcheng wrote:
> I am definitely in favor of this.
> 
> However, I'm curious: do we really need to support latin1?

I believe most (if not all) of callsites should be able to be replaced with
corresponding utf-8 or ASCII methods but I'm not yet 100% sure.  We could
probably try removing latin1 methods in this series of patches and see how it
goes.

[kinuko, 2016-12-01 04:21:46]

Description was changed from

==========
WebString: makes string16 conversions explicit

Implicit conversions between WebString and string16 makes it really easy
to write inefficient code.  (More details can be found on crbug.com/667131)

This CL changes implicit conversions to/from string16 by adding following
methods:

* static WebString WebString::fromUTF16(const string16&);
* static WebString WebString::fromUTF16(const NullableString16&);
* string16 WebString::utf16();
* static NullableString16 WebString::toNullableString16();

Also adds following helper methods/templates:

* WebVector<WebString> CopyStringVectorFromUTF16(const std::vector<string16>&)
* WebVector<WebString> CopyStringVectorFromUTF8(const std::vector<string>&)
* WebVector<WebString> CopyStringVectorFromLatin1(const std::vector<string>&)
* WebString WebStringToFilePath(base::FilePath&)

Revises/removes following unnecessary conversions:

* UTF16ToUTF8(StringPiece16(webstring)) -> webstring.utf8()
* WebString(UTF8ToUTF16(string)) -> WebString::fromUTF8(string)
* WebString(ASCIIToUTF16(string)) -> WebString::fromASCII(string)
* WebString(path.AsUTF8Unsafe()) -> FilePathToWebString(path)
* base::IsStringASCII(webstring) -> webstring.containsOnlyASCII()
* base::FilePath::FromUTF8Unsafe(webstring.utf8()) ->
  WebStringToFilePath(webstring)

(This still doesn't fix inefficient String comparisons that require unnecessary
string copies,
it should be able to be fixed in a separate patch)

BUG=667131
==========

to

==========
WebString: makes string16 conversions explicit

[Not-for-commit, will split the CL]

Implicit conversions between WebString and string16 makes it really easy
to write inefficient code.  (More details can be found on crbug.com/667131)

This CL changes implicit conversions to/from string16 by adding following
methods:

* static WebString WebString::fromUTF16(const string16&);
* static WebString WebString::fromUTF16(const NullableString16&);
* string16 WebString::utf16();
* static NullableString16 WebString::toNullableString16();

Also adds following helper methods/templates:

* WebVector<WebString> CopyStringVectorFromUTF16(const std::vector<string16>&)
* WebVector<WebString> CopyStringVectorFromUTF8(const std::vector<string>&)
* WebVector<WebString> CopyStringVectorFromLatin1(const std::vector<string>&)
* WebString WebStringToFilePath(base::FilePath&)

Revises/removes following unnecessary conversions:

* UTF16ToUTF8(StringPiece16(webstring)) -> webstring.utf8()
* WebString(UTF8ToUTF16(string)) -> WebString::fromUTF8(string)
* WebString(ASCIIToUTF16(string)) -> WebString::fromASCII(string)
* WebString(path.AsUTF8Unsafe()) -> FilePathToWebString(path)
* base::IsStringASCII(webstring) -> webstring.containsOnlyASCII()
* base::FilePath::FromUTF8Unsafe(webstring.utf8()) ->
  WebStringToFilePath(webstring)

(This still doesn't fix inefficient String comparisons that require unnecessary
string copies,
it should be able to be fixed in a separate patch)

BUG=667131
==========

[kinuko, 2016-12-01 07:17:21]

Description was changed from

==========
WebString: makes string16 conversions explicit

[Not-for-commit, will split the CL]

Implicit conversions between WebString and string16 makes it really easy
to write inefficient code.  (More details can be found on crbug.com/667131)

This CL changes implicit conversions to/from string16 by adding following
methods:

* static WebString WebString::fromUTF16(const string16&);
* static WebString WebString::fromUTF16(const NullableString16&);
* string16 WebString::utf16();
* static NullableString16 WebString::toNullableString16();

Also adds following helper methods/templates:

* WebVector<WebString> CopyStringVectorFromUTF16(const std::vector<string16>&)
* WebVector<WebString> CopyStringVectorFromUTF8(const std::vector<string>&)
* WebVector<WebString> CopyStringVectorFromLatin1(const std::vector<string>&)
* WebString WebStringToFilePath(base::FilePath&)

Revises/removes following unnecessary conversions:

* UTF16ToUTF8(StringPiece16(webstring)) -> webstring.utf8()
* WebString(UTF8ToUTF16(string)) -> WebString::fromUTF8(string)
* WebString(ASCIIToUTF16(string)) -> WebString::fromASCII(string)
* WebString(path.AsUTF8Unsafe()) -> FilePathToWebString(path)
* base::IsStringASCII(webstring) -> webstring.containsOnlyASCII()
* base::FilePath::FromUTF8Unsafe(webstring.utf8()) ->
  WebStringToFilePath(webstring)

(This still doesn't fix inefficient String comparisons that require unnecessary
string copies,
it should be able to be fixed in a separate patch)

BUG=667131
==========

to

==========
WebString: makes string16 conversions explicit (blink, content)

Implicit conversions between WebString and string16 makes it really easy
to write inefficient code.  (More details can be found on crbug.com/667131)

This CL changes implicit conversions to/from string16 by adding following
methods:

* static WebString WebString::fromUTF16(const string16&);
* static WebString WebString::fromUTF16(const NullableString16&);
* string16 WebString::utf16();
* static NullableString16 WebString::toNullableString16();

Also adds following helper methods/templates:

* WebVector<WebString> CopyStringVectorFromUTF16(const std::vector<string16>&)
* WebVector<WebString> CopyStringVectorFromUTF8(const std::vector<string>&)
* WebVector<WebString> CopyStringVectorFromLatin1(const std::vector<string>&)
* WebString WebStringToFilePath(base::FilePath&)

Revises/removes following unnecessary conversions:

* UTF16ToUTF8(StringPiece16(webstring)) -> webstring.utf8()
* WebString(UTF8ToUTF16(string)) -> WebString::fromUTF8(string)
* WebString(ASCIIToUTF16(string)) -> WebString::fromASCII(string)
* WebString(path.AsUTF8Unsafe()) -> FilePathToWebString(path)
* base::IsStringASCII(webstring) -> webstring.containsOnlyASCII()
* base::FilePath::FromUTF8Unsafe(webstring.utf8()) ->
  WebStringToFilePath(webstring)

(This still doesn't fix inefficient String comparisons that require unnecessary
string copies,
it should be able to be fixed in a separate patch)

BUG=667131
==========

[kinuko, 2016-12-01 07:18:33]

Description was changed from

==========
WebString: makes string16 conversions explicit (blink, content)

Implicit conversions between WebString and string16 makes it really easy
to write inefficient code.  (More details can be found on crbug.com/667131)

This CL changes implicit conversions to/from string16 by adding following
methods:

* static WebString WebString::fromUTF16(const string16&);
* static WebString WebString::fromUTF16(const NullableString16&);
* string16 WebString::utf16();
* static NullableString16 WebString::toNullableString16();

Also adds following helper methods/templates:

* WebVector<WebString> CopyStringVectorFromUTF16(const std::vector<string16>&)
* WebVector<WebString> CopyStringVectorFromUTF8(const std::vector<string>&)
* WebVector<WebString> CopyStringVectorFromLatin1(const std::vector<string>&)
* WebString WebStringToFilePath(base::FilePath&)

Revises/removes following unnecessary conversions:

* UTF16ToUTF8(StringPiece16(webstring)) -> webstring.utf8()
* WebString(UTF8ToUTF16(string)) -> WebString::fromUTF8(string)
* WebString(ASCIIToUTF16(string)) -> WebString::fromASCII(string)
* WebString(path.AsUTF8Unsafe()) -> FilePathToWebString(path)
* base::IsStringASCII(webstring) -> webstring.containsOnlyASCII()
* base::FilePath::FromUTF8Unsafe(webstring.utf8()) ->
  WebStringToFilePath(webstring)

(This still doesn't fix inefficient String comparisons that require unnecessary
string copies,
it should be able to be fixed in a separate patch)

BUG=667131
==========

to

==========
WebString: makes string16 conversions explicit (part 1: blink, content)

This is a series of patches that make WebString <-> string16 conversions
explicit.  Implicit conversions between WebString and string16 used to make
it really easy to write inefficient code and should be removed.
(More details can be found on crbug.com/667131)

This CL changes implicit conversions to/from string16 by adding following
methods:

* static WebString WebString::fromUTF16(const string16&);
* static WebString WebString::fromUTF16(const NullableString16&);
* string16 WebString::utf16();
* static NullableString16 WebString::toNullableString16();

Also adds following helper methods/templates:

* WebVector<WebString> CopyStringVectorFromUTF16(const std::vector<string16>&)
* WebVector<WebString> CopyStringVectorFromUTF8(const std::vector<string>&)
* WebVector<WebString> CopyStringVectorFromLatin1(const std::vector<string>&)
* WebString WebStringToFilePath(base::FilePath&)

Revises/removes following unnecessary conversions:

* UTF16ToUTF8(StringPiece16(webstring)) -> webstring.utf8()
* WebString(UTF8ToUTF16(string)) -> WebString::fromUTF8(string)
* WebString(ASCIIToUTF16(string)) -> WebString::fromASCII(string)
* WebString(path.AsUTF8Unsafe()) -> FilePathToWebString(path)
* base::IsStringASCII(webstring) -> webstring.containsOnlyASCII()
* base::FilePath::FromUTF8Unsafe(webstring.utf8()) ->
  WebStringToFilePath(webstring)

(This still doesn't fix inefficient String comparisons that require unnecessary
string copies,
it should be able to be fixed in a separate patch)

BUG=667131
==========

[kinuko, 2016-12-01 07:22:44]

Patchset #2 (id:20001) has been deleted

[kinuko, 2016-12-01 07:23:06]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 07:23:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 07:26:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 07:26:57]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[kinuko, 2016-12-02 03:26:52]

Description was changed from

==========
WebString: makes string16 conversions explicit (part 1: blink, content)

This is a series of patches that make WebString <-> string16 conversions
explicit.  Implicit conversions between WebString and string16 used to make
it really easy to write inefficient code and should be removed.
(More details can be found on crbug.com/667131)

This CL changes implicit conversions to/from string16 by adding following
methods:

* static WebString WebString::fromUTF16(const string16&);
* static WebString WebString::fromUTF16(const NullableString16&);
* string16 WebString::utf16();
* static NullableString16 WebString::toNullableString16();

Also adds following helper methods/templates:

* WebVector<WebString> CopyStringVectorFromUTF16(const std::vector<string16>&)
* WebVector<WebString> CopyStringVectorFromUTF8(const std::vector<string>&)
* WebVector<WebString> CopyStringVectorFromLatin1(const std::vector<string>&)
* WebString WebStringToFilePath(base::FilePath&)

Revises/removes following unnecessary conversions:

* UTF16ToUTF8(StringPiece16(webstring)) -> webstring.utf8()
* WebString(UTF8ToUTF16(string)) -> WebString::fromUTF8(string)
* WebString(ASCIIToUTF16(string)) -> WebString::fromASCII(string)
* WebString(path.AsUTF8Unsafe()) -> FilePathToWebString(path)
* base::IsStringASCII(webstring) -> webstring.containsOnlyASCII()
* base::FilePath::FromUTF8Unsafe(webstring.utf8()) ->
  WebStringToFilePath(webstring)

(This still doesn't fix inefficient String comparisons that require unnecessary
string copies,
it should be able to be fixed in a separate patch)

BUG=667131
==========

to

==========
WebString: makes string16 conversions explicit (part 1: blink, content)

This is a series of patches that make WebString <-> string16 conversions
explicit.  Implicit conversions between WebString and string16 used to make
it really easy to write inefficient code and should be removed.
(More details can be found on crbug.com/667131)

This CL changes implicit conversions to/from string16 by adding following
methods:

* static WebString WebString::fromUTF16(const string16&);
* static WebString WebString::fromUTF16(const NullableString16&);
* string16 WebString::utf16();
* static NullableString16 WebString::toNullableString16();

Also adds following helper methods/templates:

* WebVector<WebString> CopyStringVectorFromUTF16(const std::vector<string16>&)
* WebVector<WebString> CopyStringVectorFromLatin1(const std::vector<string>&)
* WebString WebStringToFilePath(base::FilePath&)

Revises/removes following unnecessary conversions:

* UTF16ToUTF8(StringPiece16(webstring)) -> webstring.utf8()
* WebString(UTF8ToUTF16(string)) -> WebString::fromUTF8(string)
* WebString(ASCIIToUTF16(string)) -> WebString::fromASCII(string)
* WebString(path.AsUTF8Unsafe()) -> FilePathToWebString(path)
* base::IsStringASCII(webstring) -> webstring.containsOnlyASCII()
* base::FilePath::FromUTF8Unsafe(webstring.utf8()) ->
  WebStringToFilePath(webstring)

(This still doesn't fix inefficient String comparisons that require unnecessary
string copies,
it should be able to be fixed in a separate patch)

BUG=667131
==========

[kinuko, 2016-12-02 03:27:03]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 03:27:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 03:36:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 03:36:25]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[kinuko, 2016-12-02 10:25:23]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 10:25:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 10:33:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 10:33:27]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[kinuko, 2016-12-02 13:41:41]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 13:41:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 13:50:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 13:50:25]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[kinuko, 2016-12-02 14:33:54]

Patchset #4 (id:80001) has been deleted

[kinuko, 2016-12-02 14:34:08]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 14:34:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 14:42:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 14:42:23]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[kinuko, 2016-12-02 15:36:30]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[kinuko, 2016-12-02 15:36:38]

Patchset #4 (id:100001) has been deleted

[commit-bot: I haz the power, 2016-12-02 15:36:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 15:47:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 15:47:27]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[kinuko, 2016-12-04 06:20:07]

Patchset #4 (id:120001) has been deleted

[kinuko, 2016-12-04 06:20:20]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-04 06:20:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-04 07:29:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-04 07:29:21]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[kinuko, 2016-12-04 16:41:19]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-04 16:41:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-04 18:10:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-04 18:10:14]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[kinuko, 2016-12-06 12:31:46]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 12:31:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 14:09:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 14:09:58]

Dry run: This issue passed the CQ dry run.

[kinuko, 2016-12-07 03:24:38]

It's ready for review now, stripped the change and now this CL only has changes
for content/ and blink/.  Latin1 related methods are still left as is in this
patch (looks like some can be easily converted but a few are not).

PTL (Esp. changes in public/platform)

[kinuko, 2016-12-12 03:07:17]

Description was changed from

==========
WebString: makes string16 conversions explicit (part 1: blink, content)

This is a series of patches that make WebString <-> string16 conversions
explicit.  Implicit conversions between WebString and string16 used to make
it really easy to write inefficient code and should be removed.
(More details can be found on crbug.com/667131)

This CL changes implicit conversions to/from string16 by adding following
methods:

* static WebString WebString::fromUTF16(const string16&);
* static WebString WebString::fromUTF16(const NullableString16&);
* string16 WebString::utf16();
* static NullableString16 WebString::toNullableString16();

Also adds following helper methods/templates:

* WebVector<WebString> CopyStringVectorFromUTF16(const std::vector<string16>&)
* WebVector<WebString> CopyStringVectorFromLatin1(const std::vector<string>&)
* WebString WebStringToFilePath(base::FilePath&)

Revises/removes following unnecessary conversions:

* UTF16ToUTF8(StringPiece16(webstring)) -> webstring.utf8()
* WebString(UTF8ToUTF16(string)) -> WebString::fromUTF8(string)
* WebString(ASCIIToUTF16(string)) -> WebString::fromASCII(string)
* WebString(path.AsUTF8Unsafe()) -> FilePathToWebString(path)
* base::IsStringASCII(webstring) -> webstring.containsOnlyASCII()
* base::FilePath::FromUTF8Unsafe(webstring.utf8()) ->
  WebStringToFilePath(webstring)

(This still doesn't fix inefficient String comparisons that require unnecessary
string copies,
it should be able to be fixed in a separate patch)

BUG=667131
==========

to

==========
WebString: makes string16 conversions explicit (part 1: blink, content)

This is a series of patches that make WebString <-> string16 conversions
explicit.  Implicit conversions between WebString and string16 used to make
it really easy to write inefficient code and should be removed.
(More details can be found on crbug.com/667131)

This CL changes implicit conversions to/from string16 by adding following
methods:

* static WebString WebString::fromUTF16(const string16&);
* static WebString WebString::fromUTF16(const NullableString16&);
* string16 WebString::utf16();
* static NullableString16 WebString::toNullableString16();

Revises/removes following unnecessary conversions:

* UTF16ToUTF8(StringPiece16(webstring)) -> webstring.utf8()
* WebString(UTF8ToUTF16(string)) -> WebString::fromUTF8(string)
* WebString(ASCIIToUTF16(string)) -> WebString::fromASCII(string)
* WebString(path.AsUTF8Unsafe()) -> FilePathToWebString(path)
* base::IsStringASCII(webstring) -> webstring.containsOnlyASCII()
* base::FilePath::FromUTF8Unsafe(webstring.utf8()) ->
  WebStringToFilePath(webstring)

(This still doesn't fix inefficient String comparisons that require unnecessary
string copies,
it should be able to be fixed in a separate patch)

BUG=667131
==========

[kinuko, 2016-12-12 08:06:55]

On 2016/12/07 03:24:38, kinuko wrote:
> It's ready for review now, stripped the change and now this CL only has
changes
> for content/ and blink/.  Latin1 related methods are still left as is in this
> patch (looks like some can be easily converted but a few are not).
> 
> PTL (Esp. changes in public/platform)

Hm.  I'll upload a cleaner patch in a fresh issue.