Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1725)

Unified Diff: content/renderer/browser_plugin/browser_plugin.cc

Issue 2537953003: WebString: makes string16 conversions explicit (part 1: blink, content) (Closed)
Patch Set: fix Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/browser_plugin/browser_plugin.cc
diff --git a/content/renderer/browser_plugin/browser_plugin.cc b/content/renderer/browser_plugin/browser_plugin.cc
index 248b36b1b203f00cdf854ae0652388790a3a634f..0c700ffaee0a9be3c9f609803ca53db4726f243e 100644
--- a/content/renderer/browser_plugin/browser_plugin.cc
+++ b/content/renderer/browser_plugin/browser_plugin.cc
@@ -143,9 +143,8 @@ void BrowserPlugin::UpdateDOMAttribute(const std::string& attribute_name,
return;
blink::WebElement element = container()->element();
- blink::WebString web_attribute_name =
- blink::WebString::fromUTF8(attribute_name);
- element.setAttribute(web_attribute_name, attribute_value);
+ element.setAttribute(blink::WebString::fromUTF8(attribute_name),
+ blink::WebString::fromUTF16(attribute_value));
}
void BrowserPlugin::Attach() {

Powered by Google App Engine
This is Rietveld 408576698