Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: content/renderer/savable_resources.cc

Issue 2537953003: WebString: makes string16 conversions explicit (part 1: blink, content) (Closed)
Patch Set: fix Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/savable_resources.cc
diff --git a/content/renderer/savable_resources.cc b/content/renderer/savable_resources.cc
index c1a702bd0fc5909b9bb4f46897c92e5b83a239d6..b1a9d533b69d77997b2d2227271d41db8a25eae2 100644
--- a/content/renderer/savable_resources.cc
+++ b/content/renderer/savable_resources.cc
@@ -157,10 +157,12 @@ WebString GetSubResourceLinkFromElement(const WebElement& element) {
attribute_name = "data";
} else if (element.hasHTMLTagName("link")) {
// If the link element is not linked to css, ignore it.
- if (base::LowerCaseEqualsASCII(
- base::StringPiece16(element.getAttribute("type")), "text/css") ||
- base::LowerCaseEqualsASCII(
- base::StringPiece16(element.getAttribute("rel")), "stylesheet")) {
+ WebString type = element.getAttribute("type");
+ WebString rel = element.getAttribute("rel");
+ if ((type.containsOnlyASCII() &&
+ base::LowerCaseEqualsASCII(type.ascii(), "text/css")) ||
+ (rel.containsOnlyASCII() &&
+ base::LowerCaseEqualsASCII(rel.ascii(), "stylesheet"))) {
// TODO(jnd): Add support for extracting links of sub-resources which
// are inside style-sheet such as @import, url(), etc.
// See bug: http://b/issue?id=1111667.
« no previous file with comments | « content/renderer/renderer_webcookiejar_impl.cc ('k') | content/renderer/service_worker/embedded_worker_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698