Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Unified Diff: content/renderer/renderer_blink_platform_impl.cc

Issue 2537953003: WebString: makes string16 conversions explicit (part 1: blink, content) (Closed)
Patch Set: fix Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_widget.cc ('k') | content/renderer/renderer_webcookiejar_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/renderer_blink_platform_impl.cc
diff --git a/content/renderer/renderer_blink_platform_impl.cc b/content/renderer/renderer_blink_platform_impl.cc
index 8295ac864c70d110b334e1333f509a42e3db4b39..94250e57f6a70765ec295240fc109c3c713c8931 100644
--- a/content/renderer/renderer_blink_platform_impl.cc
+++ b/content/renderer/renderer_blink_platform_impl.cc
@@ -708,8 +708,7 @@ WebAudioDevice* RendererBlinkPlatformImpl::createAudioDevice(
int session_id = 0;
if (input_device_id.isNull() ||
- !base::StringToInt(base::UTF16ToUTF8(
- base::StringPiece16(input_device_id)), &session_id)) {
+ !base::StringToInt(input_device_id.utf8(), &session_id)) {
if (input_channels > 0)
DLOG(WARNING) << "createAudioDevice(): request for audio input ignored";
@@ -758,13 +757,14 @@ void RendererBlinkPlatformImpl::getPluginList(
RenderThread::Get()->Send(
new FrameHostMsg_GetPlugins(refresh, mainFrameOrigin, &plugins));
for (const WebPluginInfo& plugin : plugins) {
- builder->addPlugin(
- plugin.name, plugin.desc,
- plugin.path.BaseName().AsUTF16Unsafe());
+ builder->addPlugin(WebString::fromUTF16(plugin.name),
+ WebString::fromUTF16(plugin.desc),
+ blink::FilePathToWebString(plugin.path.BaseName()));
for (const WebPluginMimeType& mime_type : plugin.mime_types) {
builder->addMediaTypeToLastPlugin(
- WebString::fromUTF8(mime_type.mime_type), mime_type.description);
+ WebString::fromUTF8(mime_type.mime_type),
+ WebString::fromUTF16(mime_type.description));
for (const auto& extension : mime_type.file_extensions) {
builder->addFileExtensionToLastMediaType(
@@ -1119,7 +1119,7 @@ blink::WebCompositorSupport* RendererBlinkPlatformImpl::compositorSupport() {
blink::WebString RendererBlinkPlatformImpl::convertIDNToUnicode(
const blink::WebString& host) {
- return url_formatter::IDNToUnicode(host.utf8());
+ return WebString::fromUTF16(url_formatter::IDNToUnicode(host.utf8()));
}
//------------------------------------------------------------------------------
« no previous file with comments | « content/renderer/render_widget.cc ('k') | content/renderer/renderer_webcookiejar_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698