content/renderer/accessibility/render_accessibility_impl.cc - Issue 2537953003: WebString: makes string16 conversions explicit (part 1: blink, content)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/accessibility/render_accessibility_impl.cc

Issue 2537953003: WebString: makes string16 conversions explicit (part 1: blink, content) (Closed)

Patch Set: fix Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/accessibility/render_accessibility_impl.cc

diff --git a/content/renderer/accessibility/render_accessibility_impl.cc b/content/renderer/accessibility/render_accessibility_impl.cc

index 7a7cf23dd213f68f65325f364b665b3d479d0546..806ea65d97cd5987da4c7e3ce1c0a22cf845dca2 100644

--- a/content/renderer/accessibility/render_accessibility_impl.cc

+++ b/content/renderer/accessibility/render_accessibility_impl.cc

@@ -500,7 +500,7 @@ void RenderAccessibilityImpl::OnPerformAction(

target.setSequentialFocusNavigationStartingPoint();

break;

case ui::AX_ACTION_SET_VALUE:

- target.setValue(data.value);

+ target.setValue(blink::WebString::fromUTF16(data.value));

HandleAXEvent(target, ui::AX_EVENT_VALUE_CHANGED);

break;

case ui::AX_ACTION_SHOW_CONTEXT_MENU: