[DevTools] Turn links into spans to prevent default behavior.

[DevTools] Turn links into spans to prevent default behavior.

Also replaced two different classes with a single one.

BUG=665661
Committed: https://crrev.com/1c7d33a6563cab463e7b6893a9c18f937acadb4f
Cr-Commit-Position: refs/heads/master@{#434359}

[dgozman, 2016-11-23 23:09:49]

dgozman@chromium.org changed reviewers:
+ lushnikov@chromium.org

[dgozman, 2016-11-23 23:09:50]

Last patch! PTAL?

\o/

[dgozman, 2016-11-23 23:09:56]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 23:11:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lushnikov, 2016-11-24 00:14:40]

https://codereview.chromium.org/2527763003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/inspector/elements/elements-linkify-attributes-expected.txt
(right):

https://codereview.chromium.org/2527763003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/inspector/elements/elements-linkify-attributes-expected.txt:4:
<span class="highlight"><span class="webkit-html-tag">&lt;<span
class="webkit-html-tag-name">img</span> <span
class="webkit-html-attribute"><span
class="webkit-html-attribute-name">id</span>=​"<span
class="webkit-html-attribute-value">linkify-1</span>"</span> <span
class="webkit-html-attribute"><span
class="webkit-html-attribute-name">srcset</span>=​"<span
class="webkit-html-attribute-value"><span class="devtools-link
devtools-link-prevent-clink">./​1x/​googlelogo_color_272x92dp.png</span> 1x,
<span class="devtools-link
devtools-link-prevent-clink">./​2x/​googlelogo_color_272x92dp.png</span>
2x</span>"</span>&gt;</span>​</span>
no idea what changed here..

https://codereview.chromium.org/2527763003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
(right):

https://codereview.chromium.org/2527763003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:411:
link.classList.add('devtools-link-prevent-clink');
typo: "clink"

https://codereview.chromium.org/2527763003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/console/consoleView.css
(right):

https://codereview.chromium.org/2527763003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/console/consoleView.css:359:
#console-messages a:hover {
don't we need to change this as well?

https://codereview.chromium.org/2527763003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js
(left):

https://codereview.chromium.org/2527763003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js:526: var
anchor = element.enclosingNodeOrSelfWithClass('webkit-html-resource-link');
this is actually different. Does it work with image "src" now? Why don't you
want to use 'devtools-link' here?

https://codereview.chromium.org/2527763003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js
(right):

https://codereview.chromium.org/2527763003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js:535:
while (link && !link[Elements.ElementsTreeElement.HrefSymbol])
same question here (as in elementsPanel)

https://codereview.chromium.org/2527763003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js (right):

https://codereview.chromium.org/2527763003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js:1937:
a.classList.add('devtools-link-prevent-clinkelements');
clinkelements?

https://codereview.chromium.org/2527763003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/ui/inspectorSyntaxHighlight.css
(right):

https://codereview.chromium.org/2527763003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/inspectorSyntaxHighlight.css:108:
/* Required for consistency with view-source.css, since anchors may not have
href attributes */
let's drop this comment as well?

[lushnikov, 2016-11-24 00:43:42]

lgtm! My concern about image "src" popover was addressed offline

[dgozman, 2016-11-24 00:58:30]

https://codereview.chromium.org/2527763003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/inspector/elements/elements-linkify-attributes-expected.txt
(right):

https://codereview.chromium.org/2527763003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/inspector/elements/elements-linkify-attributes-expected.txt:4:
<span class="highlight"><span class="webkit-html-tag">&lt;<span
class="webkit-html-tag-name">img</span> <span
class="webkit-html-attribute"><span
class="webkit-html-attribute-name">id</span>=​"<span
class="webkit-html-attribute-value">linkify-1</span>"</span> <span
class="webkit-html-attribute"><span
class="webkit-html-attribute-name">srcset</span>=​"<span
class="webkit-html-attribute-value"><span class="devtools-link
devtools-link-prevent-clink">./​1x/​googlelogo_color_272x92dp.png</span> 1x,
<span class="devtools-link
devtools-link-prevent-clink">./​2x/​googlelogo_color_272x92dp.png</span>
2x</span>"</span>&gt;</span>​</span>
On 2016/11/24 00:14:39, lushnikov wrote:
> no idea what changed here..

It's all good, believe me!

https://codereview.chromium.org/2527763003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
(right):

https://codereview.chromium.org/2527763003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:411:
link.classList.add('devtools-link-prevent-clink');
On 2016/11/24 00:14:39, lushnikov wrote:
> typo: "clink"

Thanks!

https://codereview.chromium.org/2527763003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/console/consoleView.css
(right):

https://codereview.chromium.org/2527763003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/console/consoleView.css:359:
#console-messages a:hover {
On 2016/11/24 00:14:39, lushnikov wrote:
> don't we need to change this as well?

We do.

https://codereview.chromium.org/2527763003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js
(left):

https://codereview.chromium.org/2527763003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js:526: var
anchor = element.enclosingNodeOrSelfWithClass('webkit-html-resource-link');
On 2016/11/24 00:14:39, lushnikov wrote:
> this is actually different. Does it work with image "src" now? Why don't you
> want to use 'devtools-link' here?

It works.

https://codereview.chromium.org/2527763003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js (right):

https://codereview.chromium.org/2527763003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js:1937:
a.classList.add('devtools-link-prevent-clinkelements');
On 2016/11/24 00:14:39, lushnikov wrote:
> clinkelements?

Fixed :-)

https://codereview.chromium.org/2527763003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/ui/inspectorSyntaxHighlight.css
(right):

https://codereview.chromium.org/2527763003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/inspectorSyntaxHighlight.css:108:
/* Required for consistency with view-source.css, since anchors may not have
href attributes */
On 2016/11/24 00:14:40, lushnikov wrote:
> let's drop this comment as well?

Done.

[dgozman, 2016-11-24 00:58:35]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-11-24 00:58:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/2527763003/#ps20001
(title: "fixed comments")

[commit-bot: I haz the power, 2016-11-24 00:59:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 03:01:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 03:01:18]

Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[dgozman, 2016-11-24 03:54:51]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-11-24 03:55:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 05:56:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 05:56:19]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[dgozman, 2016-11-24 06:13:34]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-11-24 06:13:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 06:41:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 06:41:49]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dgozman, 2016-11-24 17:15:11]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-11-24 17:15:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 17:31:12]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480007711588920,
"parent_rev": "4fada51ac693abb7697fbef7cdd690c9d0fd0e09", "commit_rev":
"4bb1a3c48cde6438649e84d96d74a5c6bdd57591"}

[commit-bot: I haz the power, 2016-11-24 17:31:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-24 17:34:43]

Description was changed from

==========
[DevTools] Turn links into spans to prevent default behavior.

Also replaced two different classes with a single one.

BUG=665661
==========

to

==========
[DevTools] Turn links into spans to prevent default behavior.

Also replaced two different classes with a single one.

BUG=665661

Committed: https://crrev.com/1c7d33a6563cab463e7b6893a9c18f937acadb4f
Cr-Commit-Position: refs/heads/master@{#434359}
==========

[commit-bot: I haz the power, 2016-11-24 17:34:44]

Patchset 2 (id:??) landed as
https://crrev.com/1c7d33a6563cab463e7b6893a9c18f937acadb4f
Cr-Commit-Position: refs/heads/master@{#434359}