Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

Issue 2527763003: [DevTools] Turn links into spans to prevent default behavior. (Closed)
Patch Set: fixed comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js
diff --git a/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js
index c914b246686aab92cd7a158a072027551da39796..dbe32f3500d1a7ca539fc5e5d6943a2d8a925d01 100644
--- a/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js
+++ b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js
@@ -1211,9 +1211,11 @@ Elements.ElementsTreeElement = class extends TreeElement {
value = value.replace(closingPunctuationRegex, '$&\u200B');
if (value.startsWith('data:'))
value = value.trimMiddle(60);
- return node.nodeName().toLowerCase() === 'a' ?
+ var link = node.nodeName().toLowerCase() === 'a' ?
UI.createExternalLink(rewrittenHref, value, '', true) :
Components.Linkifier.linkifyURL(rewrittenHref, value, '', undefined, undefined, true);
+ link[Elements.ElementsTreeElement.HrefSymbol] = rewrittenHref;
+ return link;
}
if (node && (name === 'src' || name === 'href')) {
@@ -1556,6 +1558,8 @@ Elements.ElementsTreeElement = class extends TreeElement {
}
};
+Elements.ElementsTreeElement.HrefSymbol = Symbol('ElementsTreeElement.Href');
+
Elements.ElementsTreeElement.InitialChildrenLimit = 500;
// A union of HTML4 and HTML5-Draft elements that explicitly

Powered by Google App Engine
This is Rietveld 408576698