Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js

Issue 2527763003: [DevTools] Turn links into spans to prevent default behavior. (Closed)
Patch Set: fixed comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js b/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js
index b961b0e250b735f243808bc3d3b3861753129dcb..3a62614d4739e76dd0048d18c889ffe9fd4d1fb8 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js
@@ -1919,7 +1919,7 @@ UI.createExternalLink = function(url, linkText, className, preventClick) {
if (!linkText)
linkText = url;
- var a = createElementWithClass('a', className);
+ var a = createElementWithClass('span', className);
var href = url;
if (url.trim().toLowerCase().startsWith('javascript:'))
href = null;
@@ -1927,12 +1927,15 @@ UI.createExternalLink = function(url, linkText, className, preventClick) {
href = null;
if (href !== null) {
a.href = href;
- a.classList.add('webkit-html-external-link');
- a.addEventListener('click', (event) => {
- event.consume(true);
- if (!preventClick)
+ a.classList.add('devtools-link');
+ if (!preventClick) {
+ a.addEventListener('click', (event) => {
+ event.consume(true);
InspectorFrontendHost.openInNewTab(/** @type {string} */ (href));
- }, false);
+ }, false);
+ } else {
+ a.classList.add('devtools-link-prevent-click');
+ }
a[UI._externalLinkSymbol] = true;
}
if (linkText !== url)

Powered by Google App Engine
This is Rietveld 408576698