Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js

Issue 2527763003: [DevTools] Turn links into spans to prevent default behavior. (Closed)
Patch Set: fixed comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js b/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js
index 278654a05e978150fd2483b613547f15def07d59..9f4768ef117196d0d68b451850be8f4304c91678 100644
--- a/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js
@@ -523,21 +523,22 @@ Elements.ElementsPanel = class extends UI.Panel {
* @return {!Element|!AnchorBox|undefined}
*/
_getPopoverAnchor(element, event) {
- var anchor = element.enclosingNodeOrSelfWithClass('webkit-html-resource-link');
- if (!anchor || !anchor.href)
- return;
-
- return anchor;
+ var link = element;
+ while (link && !link[Elements.ElementsTreeElement.HrefSymbol])
+ link = link.parentElementOrShadowHost();
+ return link ? link : undefined;
}
/**
- * @param {!Element} anchor
+ * @param {!Element} link
* @param {!UI.Popover} popover
*/
- _showPopover(anchor, popover) {
+ _showPopover(link, popover) {
var node = this.selectedDOMNode();
- if (node)
- Components.DOMPresentationUtils.buildImagePreviewContents(node.target(), anchor.href, true, showPopover);
+ if (node) {
+ Components.DOMPresentationUtils.buildImagePreviewContents(
+ node.target(), link[Elements.ElementsTreeElement.HrefSymbol], true, showPopover);
+ }
/**
* @param {!Element=} contents
@@ -546,7 +547,7 @@ Elements.ElementsPanel = class extends UI.Panel {
if (!contents)
return;
popover.setCanShrink(false);
- popover.showForAnchor(contents, anchor);
+ popover.showForAnchor(contents, link);
}
}

Powered by Google App Engine
This is Rietveld 408576698