Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js

Issue 2527763003: [DevTools] Turn links into spans to prevent default behavior. (Closed)
Patch Set: fixed comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js
diff --git a/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js
index 9a4e3f02014adcaf520c4e0237f1cfa0553030df..7c309e90d7192245dfd9ab137131bc6d44d1e3d4 100644
--- a/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js
+++ b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js
@@ -531,11 +531,10 @@ Elements.ElementsTreeOutline = class extends TreeOutline {
* @return {!Element|!AnchorBox|undefined}
*/
_getPopoverAnchor(element, event) {
- var anchor = element.enclosingNodeOrSelfWithClass('webkit-html-resource-link');
- if (!anchor || !anchor.href)
- return;
-
- return anchor;
+ var link = element;
+ while (link && !link[Elements.ElementsTreeElement.HrefSymbol])
+ link = link.parentElementOrShadowHost();
+ return link ? link : undefined;
}
/**
@@ -577,15 +576,16 @@ Elements.ElementsTreeOutline = class extends TreeOutline {
}
/**
- * @param {!Element} anchor
+ * @param {!Element} link
* @param {!UI.Popover} popover
*/
- _showPopover(anchor, popover) {
- var listItem = anchor.enclosingNodeOrSelfWithNodeName('li');
+ _showPopover(link, popover) {
+ var listItem = link.enclosingNodeOrSelfWithNodeName('li');
var node = /** @type {!Elements.ElementsTreeElement} */ (listItem.treeElement).node();
this._loadDimensionsForNode(
node, Components.DOMPresentationUtils.buildImagePreviewContents.bind(
- Components.DOMPresentationUtils, node.target(), anchor.href, true, showPopover));
+ Components.DOMPresentationUtils, node.target(), link[Elements.ElementsTreeElement.HrefSymbol], true,
+ showPopover));
/**
* @param {!Element=} contents
@@ -594,7 +594,7 @@ Elements.ElementsTreeOutline = class extends TreeOutline {
if (!contents)
return;
popover.setCanShrink(false);
- popover.showForAnchor(contents, anchor);
+ popover.showForAnchor(contents, link);
}
}

Powered by Google App Engine
This is Rietveld 408576698