Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/inspector/console/console-links-in-errors-with-trace.html

Issue 2527763003: [DevTools] Turn links into spans to prevent default behavior. (Closed)
Patch Set: fixed comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/inspector/elements-test.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <html> 1 <html>
2 <head> 2 <head>
3 <script src="../inspector-test.js"></script> 3 <script src="../inspector-test.js"></script>
4 <script src="../console-test.js"></script> 4 <script src="../console-test.js"></script>
5 <script src="../resources/source3.js"></script> 5 <script src="../resources/source3.js"></script>
6 <script> 6 <script>
7 7
8 function test() 8 function test()
9 { 9 {
10 InspectorTest.evaluateInPage("foo()", step1); 10 InspectorTest.evaluateInPage("foo()", step1);
11 UI.inspectorView._tabbedPane.addEventListener(UI.TabbedPane.Events.TabSelect ed, panelChanged); 11 UI.inspectorView._tabbedPane.addEventListener(UI.TabbedPane.Events.TabSelect ed, panelChanged);
12 12
13 function panelChanged() 13 function panelChanged()
14 { 14 {
15 InspectorTest.addResult("Panel " + UI.inspectorView._tabbedPane._current Tab.id + " was opened."); 15 InspectorTest.addResult("Panel " + UI.inspectorView._tabbedPane._current Tab.id + " was opened.");
16 InspectorTest.completeTest(); 16 InspectorTest.completeTest();
17 } 17 }
18 18
19 var clickTarget; 19 var clickTarget;
20 function step1() 20 function step1()
21 { 21 {
22 var firstMessageEl = Console.ConsoleView.instance()._visibleViewMessages [0].element(); 22 var firstMessageEl = Console.ConsoleView.instance()._visibleViewMessages [0].element();
23 clickTarget = firstMessageEl.querySelectorAll(".console-message-text a") [1]; 23 clickTarget = firstMessageEl.querySelectorAll(".console-message-text .de vtools-link")[1];
24 UI.inspectorView.showPanel("console").then(testClickTarget); 24 UI.inspectorView.showPanel("console").then(testClickTarget);
25 } 25 }
26 26
27 function testClickTarget() 27 function testClickTarget()
28 { 28 {
29 InspectorTest.addResult("Clicking link " + clickTarget.textContent); 29 InspectorTest.addResult("Clicking link " + clickTarget.textContent);
30 clickTarget.click(); 30 clickTarget.click();
31 } 31 }
32 32
33 InspectorFrontendHost.openInNewTab = function() 33 InspectorFrontendHost.openInNewTab = function()
34 { 34 {
35 InspectorTest.addResult("Failure: Open link in new tab!!"); 35 InspectorTest.addResult("Failure: Open link in new tab!!");
36 InspectorTest.completeTest(); 36 InspectorTest.completeTest();
37 }; 37 };
38 } 38 }
39 </script> 39 </script>
40 </head> 40 </head>
41 <body onload="runTest()"> 41 <body onload="runTest()">
42 <p> 42 <p>
43 Test that relative links in traces open in the sources panel. 43 Test that relative links in traces open in the sources panel.
44 </p> 44 </p>
45 </body> 45 </body>
46 </html> 46 </html>
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/inspector/elements-test.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698