gpu: Rename AllocateGpuMemoryBuffer to CreateGpuMemoryBuffer.

gpu: Rename AllocateGpuMemoryBuffer to CreateGpuMemoryBuffer.

BUG=none
TBR=ben@ as toplevel owner for mass-rename
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/86a858ab98a09cc9ca9647053da33f0b8d89f2c5
Cr-Commit-Position: refs/heads/master@{#434242}

[sadrul, 2016-11-23 03:36:22]

Description was changed from

==========
gpu: Rename AllocateGpuMemoryBuffer to CreateGpuMemoryBuffer.

BUG=none
==========

to

==========
gpu: Rename AllocateGpuMemoryBuffer to CreateGpuMemoryBuffer.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[sadrul, 2016-11-23 03:36:23]

Description was changed from

==========
gpu: Rename AllocateGpuMemoryBuffer to CreateGpuMemoryBuffer.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
gpu: Rename AllocateGpuMemoryBuffer to CreateGpuMemoryBuffer.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[sadrul, 2016-11-23 03:36:30]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 03:36:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-11-23 03:37:31]

Description was changed from

==========
gpu: Rename AllocateGpuMemoryBuffer to CreateGpuMemoryBuffer.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
gpu: Rename AllocateGpuMemoryBuffer to CreateGpuMemoryBuffer.

BUG=none
master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
==========

[sadrul, 2016-11-23 03:38:28]

Description was changed from

==========
gpu: Rename AllocateGpuMemoryBuffer to CreateGpuMemoryBuffer.

BUG=none
master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
gpu: Rename AllocateGpuMemoryBuffer to CreateGpuMemoryBuffer.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
==========

[sadrul, 2016-11-23 03:39:37]

sadrul@chromium.org changed reviewers:
+ reveman@chromium.org

[sadrul, 2016-11-23 03:39:38]

As discussed in https://codereview.chromium.org/2503113002/, rename the function
in GpuMemoryBufferManager.

[sadrul, 2016-11-23 03:47:04]

My script picked up the same-named function in GpuVideoAcceleratorFactories and
GpuMemoryBufferImplSharedMemory too. I think the new name makes sense in both
places. But let me know if you want to revert any of these.

[commit-bot: I haz the power, 2016-11-23 05:19:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 05:19:39]

Dry run: This issue passed the CQ dry run.

[reveman, 2016-11-23 15:22:00]

Thanks for taking care of this. LGTM.

https://codereview.chromium.org/2526683002/diff/1/media/video/gpu_memory_buff...
File media/video/gpu_memory_buffer_video_frame_pool_unittest.cc (right):

https://codereview.chromium.org/2526683002/diff/1/media/video/gpu_memory_buff...
media/video/gpu_memory_buffer_video_frame_pool_unittest.cc:267: //
CreateGpuMemoryBuffer can return null (e.g: when the GPU process is down).
This comment is incorrect. Gpu process being down is not a valid reason for
failure. Just FYI. No need to change it now.

https://codereview.chromium.org/2526683002/diff/1/media/video/gpu_memory_buff...
media/video/gpu_memory_buffer_video_frame_pool_unittest.cc:270:
TEST_F(GpuMemoryBufferVideoFramePoolTest, AllocateGpuMemoryBufferFail) {
Maybe change the name of this test too. Not very important though.

[sadrul, 2016-11-23 15:58:29]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 15:58:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-11-23 16:01:27]

https://codereview.chromium.org/2526683002/diff/1/media/video/gpu_memory_buff...
File media/video/gpu_memory_buffer_video_frame_pool_unittest.cc (right):

https://codereview.chromium.org/2526683002/diff/1/media/video/gpu_memory_buff...
media/video/gpu_memory_buffer_video_frame_pool_unittest.cc:267: //
CreateGpuMemoryBuffer can return null (e.g: when the GPU process is down).
On 2016/11/23 15:21:59, reveman wrote:
> This comment is incorrect. Gpu process being down is not a valid reason for
> failure. Just FYI. No need to change it now.

I have left the comment as is (I am not sure if I should just remove the example
comment, or replace it with something else). Happy to make this change if you
have a suggestion though.

https://codereview.chromium.org/2526683002/diff/1/media/video/gpu_memory_buff...
media/video/gpu_memory_buffer_video_frame_pool_unittest.cc:270:
TEST_F(GpuMemoryBufferVideoFramePoolTest, AllocateGpuMemoryBufferFail) {
On 2016/11/23 15:21:59, reveman wrote:
> Maybe change the name of this test too. Not very important though.

I have changed this.

[sadrul, 2016-11-23 16:50:12]

sadrul@chromium.org changed reviewers:
+ ben@chromium.org, tsepez@chromium.org

[sadrul, 2016-11-23 16:50:13]

ben@ as the top-level owner for the mass-rename

tsepez@ as the security owner for the comment update in
gpu/ipc/common/gpu_surface_tracker.h

(will TBR since changes are just renames, and has lgtm from API owner)

[commit-bot: I haz the power, 2016-11-23 17:05:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 17:05:55]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Tom Sepez, 2016-11-23 17:10:16]

lgtm

[sadrul, 2016-11-23 17:28:55]

Description was changed from

==========
gpu: Rename AllocateGpuMemoryBuffer to CreateGpuMemoryBuffer.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
gpu: Rename AllocateGpuMemoryBuffer to CreateGpuMemoryBuffer.

BUG=none
TBR=ben@ as toplevel owner for mass-rename
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
==========

[sadrul, 2016-11-23 17:29:21]

The CQ bit was checked by sadrul@chromium.org

[sadrul, 2016-11-23 17:29:22]

The patchset sent to the CQ was uploaded after l-g-t-m from reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/2526683002/#ps20001
(title: ".")

[commit-bot: I haz the power, 2016-11-23 17:29:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 20:49:10]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479922161594600,
"parent_rev": "d9a2c919947061f038880716a299158c2133f55e", "commit_rev":
"6a6ae5a590774a0d2619017c9c9cfc2b3b892b1d"}

[commit-bot: I haz the power, 2016-11-23 20:49:36]

Description was changed from

==========
gpu: Rename AllocateGpuMemoryBuffer to CreateGpuMemoryBuffer.

BUG=none
TBR=ben@ as toplevel owner for mass-rename
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
gpu: Rename AllocateGpuMemoryBuffer to CreateGpuMemoryBuffer.

BUG=none
TBR=ben@ as toplevel owner for mass-rename
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
==========

[commit-bot: I haz the power, 2016-11-23 20:49:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-23 20:51:33]

Description was changed from

==========
gpu: Rename AllocateGpuMemoryBuffer to CreateGpuMemoryBuffer.

BUG=none
TBR=ben@ as toplevel owner for mass-rename
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
gpu: Rename AllocateGpuMemoryBuffer to CreateGpuMemoryBuffer.

BUG=none
TBR=ben@ as toplevel owner for mass-rename
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/86a858ab98a09cc9ca9647053da33f0b8d89f2c5
Cr-Commit-Position: refs/heads/master@{#434242}
==========

[commit-bot: I haz the power, 2016-11-23 20:51:35]

Patchset 2 (id:??) landed as
https://crrev.com/86a858ab98a09cc9ca9647053da33f0b8d89f2c5
Cr-Commit-Position: refs/heads/master@{#434242}