gpu: Rename AllocateGpuMemoryBuffer to CreateGpuMemoryBuffer.

media/video/gpu_memory_buffer_video_frame_pool_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdint.h>
 #include <memory>
 
 #include "base/bind.h"
 #include "base/test/test_simple_task_runner.h"
 #include "base/threading/thread_task_runner_handle.h"
@@ skipping 246 matching lines @@
       software_frame, base::Bind(MaybeCreateHardwareFrameCallback, &frame));
 
   RunUntilIdle();
 
   EXPECT_NE(software_frame.get(), frame.get());
   EXPECT_EQ(2u, gles2_->gen_textures);
   EXPECT_TRUE(frame->metadata()->IsTrue(
       media::VideoFrameMetadata::READ_LOCK_FENCES_ENABLED));
 }
 
-// AllocateGpuMemoryBuffer can return null (e.g: when the GPU process is down).
+// CreateGpuMemoryBuffer can return null (e.g: when the GPU process is down).

[reveman, 2016/11/23 15:21:59]

This comment is incorrect. Gpu process being down is not a valid reason for
failure. Just FYI. No need to change it now.

[sadrul, 2016/11/23 16:01:27]

I have left the comment as is (I am not sure if I should just remove the example
comment, or replace it with something else). Happy to make this change if you
have a suggestion though.

 // This test checks that in that case we don't crash and still create the
 // textures.
 TEST_F(GpuMemoryBufferVideoFramePoolTest, AllocateGpuMemoryBufferFail) {

[reveman, 2016/11/23 15:21:59]

Maybe change the name of this test too. Not very important though.

[sadrul, 2016/11/23 16:01:27]

I have changed this.

   scoped_refptr<VideoFrame> software_frame = CreateTestYUVVideoFrame(10);
   scoped_refptr<VideoFrame> frame;
   mock_gpu_factories_->SetFailToAllocateGpuMemoryBufferForTesting(true);
   gpu_memory_buffer_pool_->MaybeCreateHardwareFrame(
       software_frame, base::Bind(MaybeCreateHardwareFrameCallback, &frame));
 
   RunUntilIdle();
 
   EXPECT_NE(software_frame.get(), frame.get());
   EXPECT_EQ(3u, gles2_->gen_textures);
 }
 
 }  // namespace media