Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 252003002: Fix WeakPtrFactory member order in net/url_request/ (Closed)

Created:
6 years, 7 months ago by Nikhil
Modified:
6 years, 7 months ago
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix WeakPtrFactory member order in net/url_request/ BUG=303818 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272645

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M net/url_request/url_fetcher_response_writer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/url_request/url_fetcher_response_writer.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/url_request/url_request_ftp_job.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_ftp_job.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_http_job.h View 2 chunks +2 lines, -1 line 0 comments Download
M net/url_request/url_request_http_job.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Nikhil
Hello, Please have a look at the changes to fix the order of WeakPtrFactory members ...
6 years, 7 months ago (2014-04-28 09:48:57 UTC) #1
Nikhil
Adding Ryan also. PTAL. Thanks!
6 years, 7 months ago (2014-04-28 12:16:24 UTC) #2
dmichael (off chromium)
lgtm, but you'll need rsleevi for net/ OWNERS
6 years, 7 months ago (2014-04-28 15:58:54 UTC) #3
Nikhil
On 2014/04/28 15:58:54, dmichael wrote: > lgtm, but you'll need rsleevi for net/ OWNERS @Ryan ...
6 years, 7 months ago (2014-05-12 09:14:49 UTC) #4
Ryan Sleevi
I cannot find your name within the list of authorized Samsung contributors. You'll need to ...
6 years, 7 months ago (2014-05-12 09:21:26 UTC) #5
Nikhil
On 2014/05/12 09:21:26, Ryan Sleevi wrote: > I cannot find your name within the list ...
6 years, 7 months ago (2014-05-12 09:30:10 UTC) #6
Ryan Sleevi
Found in the CLA, LGTM
6 years, 7 months ago (2014-05-22 20:02:27 UTC) #7
Nikhil
The CQ bit was checked by n.bansal@samsung.com
6 years, 7 months ago (2014-05-23 06:07:37 UTC) #8
Nikhil
The CQ bit was unchecked by n.bansal@samsung.com
6 years, 7 months ago (2014-05-23 06:07:41 UTC) #9
Nikhil
The CQ bit was checked by n.bansal@samsung.com
6 years, 7 months ago (2014-05-23 06:15:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/n.bansal@samsung.com/252003002/1
6 years, 7 months ago (2014-05-23 06:16:35 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 21:02:11 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-05-24 00:04:16 UTC) #13
Message was sent while issue was closed.
Change committed as 272645

Powered by Google App Engine
This is Rietveld 408576698